Implementing PaperSource.Auto - #857
Open
protoface wants to merge 5 commits into
Open
Conversation
implements a new PaperSource which first tries to use the feeder and on fail (no pages) falls back to glass Took 3 hours 35 minutes
Took 1 hour 36 minutes
Owner
|
The way I would want to do this is:
|
also removes "FeederToGlass"-specific changes
Author
|
Thanks for your feedback. I
Feel free to request any changes |
protoface
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements a new PaperSource which auto-selects either the Feeder or Glass (Flatbed) PaperSource depending on whether there are pages in the feeder.
Currently only implemented for ESCL and WIA drivers.
Behavior
Why
Simplifies the workflow and is more in line with defaults in manufacturer-supplied software. This feature was also heavily requested in my office.
Fixes #289