tx.originneeds to be replaced bymsg.sender, otherwise any contract you call can act on your behalf.- inline assembly should be used only in rare cases.
- unclear semantics:
nowis alias forblock.timestampnot current time; use of low levelcall,callcode,delegatecallshould be avoided whenever possible; usetransferwhenever failure of ether transfer should rollback the whole transaction. - beware of caller contracts:
selfdestructcan block calling contracts unexpectedly. - invocation of local functions via
this: never usethisto call functions in the same contract, it only consumes more gas than normal call. - transferring Ether in a for/while/do-while loop should be avoided due to the block gas limit.
- erc20
decimalsshould haveuint8as return type.
- reentrancy
- randomness in ethereum
- code injection via
delegatecall - arithmetic errors
- self_destruct
- ddos attacks
- nonce reuse
- replay attacks