Skip to content

Commit 1aa5f43

Browse files
maxkfranzclaude
andcommitted
ci: verify generated type definitions in CI and release gates
npm test intentionally excludes the d.ts-build-dependent type audits, so they were not exercised in CI — meaning a change to the style inventory or a mixin could break the published .d.ts surface unnoticed. Add a "Verify type definitions" step running `npm run test:types:all` (build the declarations once, then the tsc consumer test + docmaker and css surface audits) to the push/PR workflow and both release workflows. Bump the tests workflow timeout 5->10m to accommodate the extra build. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent 29c72d5 commit 1aa5f43

3 files changed

Lines changed: 8 additions & 2 deletions

File tree

.github/workflows/feature-release.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,8 @@ jobs:
2626
- name: Run tests
2727
run : |
2828
npm test
29+
- name: Verify type definitions
30+
run: npm run test:types:all
2931
- name: Determine version for the release
3032
id: get_new_patch_version
3133
run: |

.github/workflows/patch-release.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,9 @@ jobs:
2828
run: npx playwright install --with-deps
2929
- name: Run tests
3030
run : |
31-
npm test
31+
npm test
32+
- name: Verify type definitions
33+
run: npm run test:types:all
3234
- name: Get new version string
3335
id: get_new_patch_version
3436
run: |

.github/workflows/tests.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ permissions:
55
jobs:
66
ci:
77
runs-on: ubuntu-latest
8-
timeout-minutes: 5
8+
timeout-minutes: 10
99
steps:
1010
- uses: actions/checkout@v6
1111
- uses: actions/setup-node@v6
@@ -17,3 +17,5 @@ jobs:
1717
run: npx playwright install --with-deps
1818
- name: Run tests
1919
run: npm test
20+
- name: Verify type definitions
21+
run: npm run test:types:all

0 commit comments

Comments
 (0)