fix: validate workflows against node type versions

Conceived by Romuald Członkowski - www.aiadvisors.pl/en

Author: justadityaraj

src/services/workflow-validator.ts

@@ -653,10 +653,13 @@ export class WorkflowValidator {
           '@version': node.typeVersion || 1,
           ...node.parameters
         };
+        const properties = nodeInfo.isVersioned && node.typeVersion != null
+          ? this.nodeRepository.getNodeVersion(normalizedType, String(node.typeVersion))?.propertiesSchema || nodeInfo.properties
+          : nodeInfo.properties;
         const nodeValidation = this.nodeValidator.validateWithMode(
           node.type,
           paramsWithVersion,
-          nodeInfo.properties || [],
+          properties || [],
           'operation',
           profile as any
         );
@@ -2684,4 +2687,4 @@ export class WorkflowValidator {
       );
     }
   }
-}
+}

tests/unit/services/workflow-validator-version-schema.test.ts

@@ -0,0 +1,61 @@
+import { describe, expect, it, vi } from 'vitest';
+import { EnhancedConfigValidator } from '@/services/enhanced-config-validator';
+import { WorkflowValidator } from '@/services/workflow-validator';
+import type { NodeRepository } from '@/database/node-repository';
+
+vi.mock('@/utils/logger');
+
+describe('WorkflowValidator version-specific schemas', () => {
+  it('validates a Notion 2.2 database page against its own schema', async () => {
+    const title = {
+      displayName: 'Title',
+      name: 'title',
+      type: 'string',
+      default: '',
+      required: true,
+      displayOptions: { show: { resource: ['databasePage'], operation: ['create'] } },
+    };
+    const properties = [
+      { displayName: 'Resource', name: 'resource', type: 'options', default: 'page' },
+      { displayName: 'Operation', name: 'operation', type: 'options', default: 'create', displayOptions: { show: { resource: ['databasePage'] } } },
+      title,
+    ];
+    const repository = {
+      getAllNodes: vi.fn(() => []),
+      getNode: vi.fn((type: string) => type === 'nodes-base.manualTrigger'
+        ? { nodeType: type, displayName: 'Manual Trigger', package: 'n8n-nodes-base', isTrigger: true, isVersioned: false, outputs: ['main'], properties: [] }
+        : { nodeType: type, displayName: 'Notion', package: 'n8n-nodes-base', version: 3, isVersioned: true, outputs: ['main'], properties }),
+      getNodeVersion: vi.fn(() => ({ propertiesSchema: properties.map(property => property === title ? { ...property, required: false } : property) })),
+    } as unknown as NodeRepository;
+    const validator = new WorkflowValidator(repository, EnhancedConfigValidator);
+    const workflow = {
+      name: 'notion-title-expression-repro',
+      nodes: [
+        { parameters: {}, id: 'trigger', name: 'Manual Trigger', type: 'n8n-nodes-base.manualTrigger', position: [0, 0], typeVersion: 1 },
+        {
+          parameters: {
+            resource: 'databasePage',
+            databaseId: { __rl: true, mode: 'list', value: '00000000-0000-0000-0000-000000000000', cachedResultName: 'example-db' },
+            propertiesUi: { propertyValues: [
+              { key: 'URL|url', urlValue: "={{ 'https://example.com' + $json.path }}" },
+              { key: 'title|title', title: '={{ $json.title }}' },
+              { key: 'abstract|rich_text', textContent: '={{ $json.abstract }}' },
+            ] },
+            options: {},
+          },
+          id: 'notion',
+          name: 'Store Page',
+          type: 'n8n-nodes-base.notion',
+          position: [220, 0],
+          typeVersion: 2.2,
+        },
+      ],
+      connections: { 'Manual Trigger': { main: [[{ node: 'Store Page', type: 'main', index: 0 }]] } },
+    };
+
+    const result = await validator.validateWorkflow(workflow as any, { profile: 'runtime' });
+
+    expect(result.errors).toEqual([]);
+    expect(repository.getNodeVersion).toHaveBeenCalledWith('nodes-base.notion', '2.2');
+  });
+});