Skip to content

Commit 2d6a95d

Browse files
committed
FullCharge: Stop the carried-basis KDoc from claiming a closed retirement set
The lifetime sentence listed the out-of-band check, reset, and trigger consumption as the only ways a carried arming basis is retired. Reconnect window expiry, a replug that re-derives to nothing, and the any-level revocation retire it too, so the list was not exhaustive. Describe the retirement paths without asserting closure, keeping the load-bearing point: the basis carries no timestamp, so a retry is deliberately not bounded by the original reconnect window. Fixes review finding F5.
1 parent 627fde8 commit 2d6a95d

1 file changed

Lines changed: 5 additions & 3 deletions

File tree

app/src/main/java/eu/darken/amply/fullcharge/core/QuickFullChargeGesture.kt

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,11 @@ enum class PolicyEvidence { PROTECTIVE, UNRESTRICTED, UNKNOWN }
2323
* reading alone can never reconstruct a limit hold, and every retry after a missed window used to be
2424
* inert. A rejected sub-[minReconnectMillis] gap is deliberately treated as a *non-event*: the basis
2525
* returns to the ordinary plugged-period latch and from there persists exactly as long as a freshly
26-
* observed hold would — it carries no timestamp and is retired only by the out-of-band check below,
27-
* by [reset], or by consuming a trigger. So a retry is not bounded by the original window; that is
28-
* the point (see `a retry long after the original unplug still triggers`).
26+
* observed hold would. Carrying no timestamp of its own, it is subject to the same retirement paths
27+
* as any latched basis — the out-of-band check below, an any-level revocation, expiry of a reconnect
28+
* window it later opens, a replug that re-derives to nothing, [reset], or consuming a trigger. What
29+
* it is *not* bound by is the original reconnect window; that is the point (see `a retry long after
30+
* the original unplug still triggers`).
2931
*
3032
* Two arming bases exist:
3133
* - Limit hold (default): Android's charging-policy hardware state reports the Pixel policy actively

0 commit comments

Comments
 (0)