Dashboard: Hold back the upgrade promo card for launch

Pre-launch decision: build a user base before asking for the upgrade on
the dashboard's main surface. Both render sites of UpgradePromoCard (the
unsupported branch and the supported branch, after the quick-access
promotion) are removed, so the dashboard no longer carries an upgrade
ask of its own.

The upgrade stays discoverable through the Pro badges, the locked
tile/widget, and the settings row. shouldShowUpgradePromo still gates
those badges, and the DashboardScreen onUpgrade parameter plus its
MainActivity wiring are kept, so reintroducing the card after launch is
a one-line change. The composable, its previews, strings, and component
test are untouched.

Author: d4rken

app/src/main/java/eu/darken/amply/main/ui/dashboard/DashboardScreen.kt

@@ -127,6 +127,8 @@ fun DashboardScreen(
     onOpenSupportIssue: () -> Unit,
     onEmailSupport: () -> Unit,
     onHelp: () -> Unit,
+    // Unused while UpgradePromoCard is held back for launch (see its docs). Kept — together with the
+    // root wiring in MainActivity — so re-adding the card is a one-line change here.
     onUpgrade: () -> Unit = {},
     // Injectable so a screenshot/preview fixture can render a live session at a believable age instead
     // of at "0m" — the screen is otherwise pure, and this is the one value it reads from the clock.
@@ -332,12 +334,6 @@ fun DashboardScreen(
                             )
                         }
                     }
-                    // Outside the contributionWanted block: an unsupported device we want no
-                    // contribution data from still gets the promo, same as a supported one. The two
-                    // branches are mutually exclusive, so the item key stays unique.
-                    if (shouldShowUpgradePromo(state.upgrade)) {
-                        item(key = "dashboard.upgrade") { UpgradePromoCard(onUpgrade = onUpgrade) }
-                    }
                 } else {
                     // Promote the widget/tile shortcuts only once setup is done (the setup guide above
                     // has disappeared) and while at least one shortcut is still undiscovered.
@@ -354,20 +350,15 @@ fun DashboardScreen(
                                 widgetAdded = state.quickAccess.widgetAdded,
                                 tileAdded = state.quickAccess.tileAdded,
                                 tileRequestPending = state.tileRequestPending,
-                                // Same settled-and-not-Pro condition as the promo card below: an
-                                // unsettled entitlement badges nothing.
+                                // Settled and not upgraded only: an unsettled entitlement badges
+                                // nothing.
                                 showProBadge = shouldShowUpgradePromo(state.upgrade),
                                 onPinWidget = onPinWidget,
                                 onAddTile = onAddTile,
                                 onDismiss = onDismissQuickAccess,
                             )
                         }
                     }
-                    // Directly after the quick-access promotion, which advertises the two shortcuts
-                    // this card is the way to unlock.
-                    if (shouldShowUpgradePromo(state.upgrade)) {
-                        item(key = "dashboard.upgrade") { UpgradePromoCard(onUpgrade = onUpgrade) }
-                    }
                     val access = state.charging.access
                     when {
                         // System-namespace adapters (OnePlus/ColorOS): writes need Shizuku even
@@ -920,7 +911,7 @@ private fun DashboardScreenPreview() = PreviewWrapper {
             quickFullChargeEnabled = true,
             // Presence check done, nothing discovered yet — renders the quick-access promotion.
             quickAccessChecked = true,
-            // Settled and not upgraded: the one combination that renders the upgrade promo.
+            // Settled and not upgraded: the plain app-name title, plus the quick-access Pro badge.
             upgrade = UpgradeSnapshot(isPro = false, isSettled = true),
             // A resolved interruption: the warning card sits under the hero until dismissed.
             interruption = InterruptionEvent(

app/src/main/java/eu/darken/amply/main/ui/dashboard/DashboardViewModel.kt

@@ -121,7 +121,10 @@ data class UpgradeSnapshot(
     val isSettled: Boolean,
 )
 
-/** The promo card is an ask; it has no business appearing before we know the answer, or after a yes. */
+/**
+ * The upgrade ask — currently the Pro badges, and the promo card once it returns — has no business
+ * appearing before we know the answer, or after a yes.
+ */
 fun shouldShowUpgradePromo(upgrade: UpgradeSnapshot?): Boolean =
     upgrade != null && upgrade.isSettled && !upgrade.isPro
 

app/src/main/java/eu/darken/amply/main/ui/dashboard/UpgradePromoCard.kt

@@ -30,6 +30,12 @@ import eu.darken.amply.common.compose.PreviewWrapper
  * The whole card is the tap target: it has exactly one action, and a card-sized ask whose only live
  * target was a small button in its corner made the rest of the card look inert. The action label
  * below is therefore just a label — the surface owns the tap.
+ *
+ * Currently **not rendered on the dashboard**: a pre-launch decision holds the upgrade ask back until
+ * there is a user base to promote it to (the upgrade stays discoverable through the Pro badges, the
+ * locked tile/widget, and the settings row). It used to sit in `DashboardScreen` after the alarm card
+ * — after the quick-access promotion on a supported device, and after the contribution card on an
+ * unsupported one — and is kept intact for that reintroduction.
  */
 @Composable
 fun UpgradePromoCard(