FullCharge: Describe the arming basis the device will actually use

Found on hardware during the device pass for the previous commit, which
put the reconnect card in front of non-Pixel adapters for the first time
and so exposed copy that had only ever been read on a Pixel.

The dashboard off-state promised "a quick unplug/replug at the 80%
limit". On an SM-G781B that was wrong twice: One UI reports no hold for
the gesture to wait on, and the card directly above it read "85% limit".
Split it into a hold variant and an any-level variant, chosen by the
same effective basis the on-state already used, and drop the hardcoded
number from both since the hold wording was equally wrong at 85%.

Onboarding said "Reconnect at the 80% hold". That page runs before any
adapter resolves, so it cannot name a basis or a limit at all.

Author: d4rken

app/src/main/java/eu/darken/amply/main/ui/dashboard/DashboardScreen.kt

@@ -839,6 +839,11 @@ private fun QuickFullChargeCard(
             when {
                 enabled && anyLevel -> stringResource(R.string.dashboard_reconnect_body_on_any_level)
                 enabled -> stringResource(R.string.dashboard_reconnect_body_on)
+                // The off-state has to describe the basis this device would actually use. Naming
+                // the hold where it can never happen was wrong twice over on a legacy Samsung: it
+                // promised a hold the ROM does not report, and named 80% next to that device's
+                // real 85% limit shown one card above.
+                anyLevel -> stringResource(R.string.dashboard_reconnect_body_off_any_level)
                 else -> stringResource(R.string.dashboard_reconnect_body_off)
             },
             style = MaterialTheme.typography.bodySmall,

app/src/main/res/values/strings.xml

@@ -64,7 +64,7 @@
     <string name="onboarding_feature_fullcharge_title">Charge fully once</string>
     <string name="onboarding_feature_fullcharge_body">Protection returns automatically at full or when unplugged.</string>
     <string name="onboarding_feature_shortcut_title">Optional reconnect gesture</string>
-    <string name="onboarding_feature_shortcut_body" formatted="false">Reconnect at the 80% hold to request one full charge.</string>
+    <string name="onboarding_feature_shortcut_body">Unplug and reconnect quickly to request one full charge.</string>
     <string name="onboarding_next_action">Next</string>
     <string name="onboarding_continue_action">Get started</string>
     <string name="onboarding_caveats_title">Before you start</string>
@@ -536,7 +536,8 @@
     <string name="dashboard_reconnect_title">Reconnect gesture</string>
     <string name="dashboard_reconnect_body_on" formatted="false">At the 80% limit, unplug for at least 2 seconds and reconnect within 10. An ongoing notification keeps the gesture reliable.</string>
     <string name="dashboard_reconnect_body_on_any_level">At any charge level while a protective policy is set, unplug for at least 2 seconds and reconnect within 10. An ongoing notification keeps the gesture reliable.</string>
-    <string name="dashboard_reconnect_body_off" formatted="false">Optionally use a quick unplug/replug at the 80% limit to charge fully once.</string>
+    <string name="dashboard_reconnect_body_off">Optionally use a quick unplug/replug while your charge limit is holding to charge fully once.</string>
+    <string name="dashboard_reconnect_body_off_any_level">Optionally use a quick unplug/replug at any charge level to charge fully once.</string>
     <string name="settings_charging_title">Charging</string>
     <string name="settings_charging_subtitle_on">Reconnect gesture on</string>
     <string name="settings_charging_subtitle_off">Reconnect gesture off</string>

app/src/test/java/eu/darken/amply/main/ui/dashboard/DashboardScreenGestureTest.kt

@@ -76,6 +76,49 @@ class DashboardScreenGestureTest {
         compose.onAllNodesWithContentDescription(string(R.string.action_settings)).assertCountEquals(1)
     }
 
+    // Found on a real SM-G781B: the off-state copy promised a hold that One UI never reports AND
+    // named 80% while the card directly above it read "85% limit". An adapter that can only arm
+    // any-level must describe that, in the off state too.
+    @Test
+    fun `an any-level-only device describes the basis it will actually use`() {
+        render(
+            state = DashboardUiState(
+                onboardingComplete = true,
+                quickFullChargeEnabled = false,
+                charging = ChargingState(
+                    adapterResolved = true,
+                    reconnectSupported = true,
+                    reconnectAnyLevelOnly = true,
+                ),
+            ),
+        )
+
+        compose.onNode(hasScrollAction())
+            .performScrollToNode(hasText(string(R.string.dashboard_reconnect_title)))
+        compose.onNodeWithText(string(R.string.dashboard_reconnect_body_off_any_level)).assertExists()
+        compose.onAllNodesWithText(string(R.string.dashboard_reconnect_body_off)).assertCountEquals(0)
+    }
+
+    // The hold wording survives where the hold can actually happen (Pixel with the sub-option off).
+    @Test
+    fun `a full-support device keeps the limit-hold wording`() {
+        render(
+            state = DashboardUiState(
+                onboardingComplete = true,
+                quickFullChargeEnabled = false,
+                charging = ChargingState(
+                    adapterResolved = true,
+                    reconnectSupported = true,
+                    reconnectAnyLevelOnly = false,
+                ),
+            ),
+        )
+
+        compose.onNode(hasScrollAction())
+            .performScrollToNode(hasText(string(R.string.dashboard_reconnect_title)))
+        compose.onNodeWithText(string(R.string.dashboard_reconnect_body_off)).assertExists()
+    }
+
     @Test
     fun `the hero states the policy and is not a navigation surface`() {
         render(