Refactor: Externalize strings for UI components

This commit externalizes user-facing strings in various UI components across the app, including Workspace Manager, Explorer, Searcher, Editor, and Settings screens. It replaces hardcoded strings with string resources for better localization and maintainability.

Author: d4rken

app-workspace-editor/src/main/java/eu/darken/butler/editor/ui/editor/EditorWorkspacePage.kt

@@ -163,7 +163,7 @@ fun EditorWorkspacePage(
         // Header that draws under status bar
         EditorHeader(
             design = design,
-            fileName = state.fileName,
+            fileName = if (state.hasFile) state.fileName else stringResource(R.string.editor_file_untitled),
             isModified = state.isModified,
             hasFile = state.hasFile || state.currentContent.isNotEmpty(),
             isLoading = state.isLoading,

app-workspace-editor/src/main/res/values/strings.xml

@@ -47,4 +47,7 @@
     <string name="editor_dialog_search_label">Search text</string>
     <string name="editor_dialog_action_go">Go</string>
     <string name="editor_dialog_action_cancel">Cancel</string>
+
+    <!-- Editor File Names -->
+    <string name="editor_file_untitled">Untitled</string>
 </resources>

app-workspace-explorer/src/main/java/eu/darken/butler/explorer/ui/explorer/rows/ApkFileRow.kt

@@ -7,11 +7,12 @@ import androidx.compose.material3.Icon
 import androidx.compose.material3.MaterialTheme
 import androidx.compose.runtime.Composable
 import androidx.compose.ui.Modifier
+import androidx.compose.ui.res.stringResource
 import androidx.compose.ui.unit.dp
 import eu.darken.butler.common.compose.Preview2
+import eu.darken.butler.explorer.R
 import eu.darken.butler.explorer.core.engine.ExplorerPathItem
 import eu.darken.butler.explorer.ui.explorer.preview.MockDataProvider
-import eu.darken.butler.explorer.ui.explorer.rows.FileRowBase
 
 @Composable
 internal fun ApkFileRow(
@@ -33,7 +34,7 @@ internal fun ApkFileRow(
             // TODO: Replace with AsyncImage when Coil integration is complete
             Icon(
                 imageVector = Icons.Default.Android,
-                contentDescription = "APK file",
+                contentDescription = stringResource(R.string.explorer_file_apk_content_desc),
                 tint = MaterialTheme.colorScheme.tertiary,
                 modifier = Modifier.size(32.dp)
             )

app-workspace-explorer/src/main/java/eu/darken/butler/explorer/ui/explorer/rows/ArchiveFileRow.kt

@@ -7,8 +7,10 @@ import androidx.compose.material3.Icon
 import androidx.compose.material3.MaterialTheme
 import androidx.compose.runtime.Composable
 import androidx.compose.ui.Modifier
+import androidx.compose.ui.res.stringResource
 import androidx.compose.ui.unit.dp
 import eu.darken.butler.common.compose.Preview2
+import eu.darken.butler.explorer.R
 import eu.darken.butler.explorer.core.engine.ExplorerPathItem
 import eu.darken.butler.explorer.ui.explorer.preview.MockDataProvider
 
@@ -31,15 +33,15 @@ internal fun ArchiveFileRow(
         leadingContent = {
             Icon(
                 imageVector = Icons.Default.Archive,
-                contentDescription = "Archive",
+                contentDescription = stringResource(R.string.explorer_file_archive_content_desc),
                 tint = MaterialTheme.colorScheme.tertiary,
                 modifier = Modifier.size(32.dp)
             )
         },
         primaryText = item.displayName,
         secondaryText = buildString {
-            item.entryCount?.let { 
-                append("$it items")
+            item.entryCount?.let {
+                append(stringResource(R.string.explorer_file_items_count, it))
                 append(" • ")
             }
             append(item.displaySize)

app-workspace-explorer/src/main/java/eu/darken/butler/explorer/ui/explorer/rows/DirectoryRow.kt

@@ -7,8 +7,10 @@ import androidx.compose.material3.Icon
 import androidx.compose.material3.MaterialTheme
 import androidx.compose.runtime.Composable
 import androidx.compose.ui.Modifier
+import androidx.compose.ui.res.stringResource
 import androidx.compose.ui.unit.dp
 import eu.darken.butler.common.compose.Preview2
+import eu.darken.butler.explorer.R
 import eu.darken.butler.explorer.core.engine.ExplorerPathItem
 import eu.darken.butler.explorer.ui.explorer.preview.MockDataProvider
 
@@ -31,15 +33,15 @@ internal fun DirectoryRow(
         leadingContent = {
             Icon(
                 imageVector = Icons.Default.Folder,
-                contentDescription = "Folder",
+                contentDescription = stringResource(R.string.explorer_file_folder_content_desc),
                 tint = MaterialTheme.colorScheme.primary,
                 modifier = Modifier.size(32.dp)
             )
         },
         primaryText = item.displayName,
         secondaryText = buildString {
             item.childCount?.let { count ->
-                append("$count items")
+                append(stringResource(R.string.explorer_file_items_count, count))
                 append(" • ")
             }
             append(item.displayDate)

app-workspace-explorer/src/main/java/eu/darken/butler/explorer/ui/explorer/rows/DocumentFileRow.kt

@@ -7,8 +7,10 @@ import androidx.compose.material3.Icon
 import androidx.compose.material3.MaterialTheme
 import androidx.compose.runtime.Composable
 import androidx.compose.ui.Modifier
+import androidx.compose.ui.res.stringResource
 import androidx.compose.ui.unit.dp
 import eu.darken.butler.common.compose.Preview2
+import eu.darken.butler.explorer.R
 import eu.darken.butler.explorer.core.engine.ExplorerPathItem
 import eu.darken.butler.explorer.ui.explorer.preview.MockDataProvider
 
@@ -31,15 +33,15 @@ internal fun DocumentFileRow(
         leadingContent = {
             Icon(
                 imageVector = Icons.Default.Description,
-                contentDescription = "Document",
+                contentDescription = stringResource(R.string.explorer_file_document_content_desc),
                 tint = MaterialTheme.colorScheme.outline,
                 modifier = Modifier.size(32.dp)
             )
         },
         primaryText = item.displayName,
         secondaryText = buildString {
-            item.pageCount?.let { 
-                append("$it pages")
+            item.pageCount?.let {
+                append(stringResource(R.string.explorer_file_pages_count, it))
                 append(" • ")
             }
             append(item.displaySize)

app-workspace-explorer/src/main/java/eu/darken/butler/explorer/ui/explorer/rows/ImageFileRow.kt

@@ -7,8 +7,10 @@ import androidx.compose.material3.Icon
 import androidx.compose.material3.MaterialTheme
 import androidx.compose.runtime.Composable
 import androidx.compose.ui.Modifier
+import androidx.compose.ui.res.stringResource
 import androidx.compose.ui.unit.dp
 import eu.darken.butler.common.compose.Preview2
+import eu.darken.butler.explorer.R
 import eu.darken.butler.explorer.core.engine.ExplorerPathItem
 import eu.darken.butler.explorer.ui.explorer.preview.MockDataProvider
 
@@ -32,7 +34,7 @@ internal fun ImageFileRow(
             // TODO: Replace with AsyncImage when Coil integration is complete
             Icon(
                 imageVector = Icons.Default.Image,
-                contentDescription = "Image",
+                contentDescription = stringResource(R.string.explorer_file_image_content_desc),
                 tint = MaterialTheme.colorScheme.secondary,
                 modifier = Modifier.size(32.dp)
             )

app-workspace-explorer/src/main/java/eu/darken/butler/explorer/ui/explorer/rows/MediaFileRow.kt

@@ -8,8 +8,10 @@ import androidx.compose.material3.Icon
 import androidx.compose.material3.MaterialTheme
 import androidx.compose.runtime.Composable
 import androidx.compose.ui.Modifier
+import androidx.compose.ui.res.stringResource
 import androidx.compose.ui.unit.dp
 import eu.darken.butler.common.compose.Preview2
+import eu.darken.butler.explorer.R
 import eu.darken.butler.explorer.core.engine.ExplorerPathItem
 import eu.darken.butler.explorer.ui.explorer.preview.MockDataProvider
 
@@ -34,14 +36,14 @@ internal fun MediaFileRow(
                 // TODO: Replace with AsyncImage when Coil integration is complete
                 Icon(
                     imageVector = Icons.Default.Movie,
-                    contentDescription = "Video file",
+                    contentDescription = stringResource(R.string.explorer_file_video_content_desc),
                     tint = MaterialTheme.colorScheme.secondary,
                     modifier = Modifier.size(32.dp)
                 )
             } else {
                 Icon(
                     imageVector = Icons.Default.MusicNote,
-                    contentDescription = "Audio file",
+                    contentDescription = stringResource(R.string.explorer_file_audio_content_desc),
                     tint = MaterialTheme.colorScheme.secondary,
                     modifier = Modifier.size(32.dp)
                 )

app-workspace-explorer/src/main/java/eu/darken/butler/explorer/ui/explorer/rows/RegularFileRow.kt

@@ -7,8 +7,10 @@ import androidx.compose.material3.Icon
 import androidx.compose.material3.MaterialTheme
 import androidx.compose.runtime.Composable
 import androidx.compose.ui.Modifier
+import androidx.compose.ui.res.stringResource
 import androidx.compose.ui.unit.dp
 import eu.darken.butler.common.compose.Preview2
+import eu.darken.butler.explorer.R
 import eu.darken.butler.explorer.core.engine.ExplorerPathItem
 import eu.darken.butler.explorer.ui.explorer.preview.MockDataProvider
 
@@ -31,7 +33,7 @@ internal fun RegularFileRow(
         leadingContent = {
             Icon(
                 imageVector = Icons.AutoMirrored.Filled.InsertDriveFile,
-                contentDescription = "File",
+                contentDescription = stringResource(R.string.explorer_file_regular_content_desc),
                 tint = MaterialTheme.colorScheme.onSurfaceVariant,
                 modifier = Modifier.size(32.dp)
             )

app-workspace-explorer/src/main/java/eu/darken/butler/explorer/ui/explorer/rows/ShortcutRow.kt

@@ -21,7 +21,9 @@ import androidx.compose.ui.Alignment
 import androidx.compose.ui.Modifier
 import androidx.compose.ui.draw.clip
 import androidx.compose.ui.platform.LocalContext
+import androidx.compose.ui.res.stringResource
 import androidx.compose.ui.unit.dp
+import eu.darken.butler.explorer.R
 import eu.darken.butler.explorer.core.engine.ExplorerPathItem
 
 @Composable
@@ -79,7 +81,7 @@ fun ShortcutRow(
                 color = MaterialTheme.colorScheme.onSurface
             )
             Text(
-                text = "Shortcut",
+                text = stringResource(R.string.explorer_file_shortcut_label),
                 style = MaterialTheme.typography.bodySmall,
                 color = MaterialTheme.colorScheme.onSurfaceVariant
             )