chore: remove unused UPLOADED and EXPIRED session states

Both enum values were dead writes — no code path ever assigned them. The defensive reads in isExpired() and terminateSession() collapse cleanly: ABORTED is the only terminal that suppresses quota release, and time-based expiry is computed live from the timestamp fields rather than persisted via a state mutation.

Re-adding either case is a 5-minute change if a future status-polling endpoint wants to surface session-expired or finalize-in-flight as observable states.

Author: d4rken

src/main/kotlin/eu/darken/octi/server/module/UploadSessionMeta.kt

@@ -28,10 +28,10 @@ data class UploadSessionMeta(
     val state: State,
 ) {
     @Serializable
-    enum class State { ACTIVE, UPLOADED, COMPLETE, ABORTED, EXPIRED }
+    enum class State { ACTIVE, COMPLETE, ABORTED }
 
     fun isExpired(now: Instant = Instant.now()): Boolean {
-        if (state == State.ABORTED || state == State.EXPIRED) return true
+        if (state == State.ABORTED) return true
         // Absolute expiry
         if (now.isAfter(expiresAt)) return true
         // Idle expiry

src/main/kotlin/eu/darken/octi/server/module/UploadSessionRepo.kt

@@ -257,7 +257,7 @@ class UploadSessionRepo @Inject constructor(
                 return@withLock FinalizeResult.AlreadyComplete(meta.blobId, meta.expectedSizeBytes)
             }
 
-            if (meta.state != UploadSessionMeta.State.ACTIVE && meta.state != UploadSessionMeta.State.UPLOADED) {
+            if (meta.state != UploadSessionMeta.State.ACTIVE) {
                 return@withLock FinalizeResult.SessionNotFound
             }
 
@@ -333,7 +333,7 @@ class UploadSessionRepo @Inject constructor(
         } catch (e: Exception) {
             log(TAG, WARN) { "terminateSession(${meta.sessionId}): failed to delete dir: ${e.message}" }
         }
-        if (meta.expectedSizeBytes > 0 && meta.state != UploadSessionMeta.State.ABORTED && meta.state != UploadSessionMeta.State.EXPIRED) {
+        if (meta.expectedSizeBytes > 0 && meta.state != UploadSessionMeta.State.ABORTED) {
             storageTracker.releaseReservation(meta.accountId, meta.expectedSizeBytes)
         }
         log(TAG) { "terminateSession(${meta.sessionId}): $reason" }