Complete filter migration cleanup: move filter definitions off PupilProxy, fix naming, remove dead code

- Move static filter lists (schoolGrade, gender, religionCourse, familyLanguage, afterSchoolCare, migrationSupport) from PupilProxy to PupilsFilterImplementation
- Delete commented-out authorization_pupils_filter_bottom_sheet.dart (replaced by authorization_pupils_filters_widget.dart)
- Rename FilterState.pupilLegacy to FilterState.learningSupport
- Fix refreshs() typo to refresh() across 25 files
- Rename setTextFilter parameter to shouldRefresh to avoid shadowing

Author: dabblingwithcode

school_data_hub_flutter/lib/common/domain/filters/filters_state_manager.dart

@@ -3,7 +3,7 @@ import 'package:flutter/foundation.dart';
 
 enum FilterState {
   pupil,
-  pupilLegacy,
+  learningSupport,
   attendance,
   schooldayEvent,
   schoolList,
@@ -16,7 +16,7 @@ enum FilterState {
 
 const Map<FilterState, bool> _initialFilterGlobalValues = {
   FilterState.pupil: false,
-  FilterState.pupilLegacy: false,
+  FilterState.learningSupport: false,
   FilterState.attendance: false,
   FilterState.schooldayEvent: false,
   FilterState.schoolList: false,

school_data_hub_flutter/lib/features/_attendance/domain/filters/attendance_pupil_filter.dart

@@ -34,7 +34,7 @@ class AttendancePupilFilterManager implements Resettable {
         false) {
       return;
     }
-    _pupilsFilter.refreshs();
+    _pupilsFilter.refresh();
   }
 
   void dispose() {
@@ -64,7 +64,7 @@ class AttendancePupilFilterManager implements Resettable {
       filterState: FilterState.attendance,
       value: !attendanceFilterStateEqualsInitialState,
     );
-    _pupilsFilter.refreshs();
+    _pupilsFilter.refresh();
   }
 
   @override

school_data_hub_flutter/lib/features/_attendance/presentation/attendance_page/attendance_list_page.dart

@@ -92,7 +92,7 @@ class AttendanceListPage extends WatchingWidget {
                     statsWidget: const AttendanceSearchBarStatsWidget(),
                     searchType: SearchType.pupil,
                     hintText: 'Schüler/in suchen',
-                    refreshFunction: pupilsFilter.refreshs,
+                    refreshFunction: pupilsFilter.refresh,
                     onChanged: (value) =>
                         pupilsFilter.textFilter.setFilterText(value),
                     searchTextSource: pupilsFilter.textFilter,

school_data_hub_flutter/lib/features/_attendance/presentation/missed_schooldays_pupil_list_page/missed_schooldays_pupil_list_page.dart

@@ -37,7 +37,7 @@ class MissedSchooldaysPupilListPage extends StatelessWidget {
         ),
         searchType: SearchType.pupil,
         hintText: 'Schüler/in suchen',
-        refreshFunction: pupilsFilter.refreshs,
+        refreshFunction: pupilsFilter.refresh,
         onChanged: (value) => pupilsFilter.textFilter.setFilterText(value),
         searchTextSource: pupilsFilter.textFilter,
         filtersActive: di<FiltersStateManager>().filtersActive,

school_data_hub_flutter/lib/features/_authorizations/domain/filters/pupil_authorization_filter_manager.dart

@@ -72,7 +72,7 @@ class PupilAuthorizationFilterManager implements Resettable {
       value: !authorizationFilterStateEqualsInitialValues,
     );
 
-    di<PupilsFilter>().refreshs();
+    di<PupilsFilter>().refresh();
   }
 
   List<PupilAuthorization> applyAuthorizationFiltersToPupilAuthorizations(

school_data_hub_flutter/lib/features/_authorizations/presentation/authorization_pupils_page/authorization_pupils_page.dart

@@ -63,7 +63,7 @@ class AuthorizationPupilsPage extends WatchingWidget {
         ),
         searchType: SearchType.pupil,
         hintText: 'Schüler/in suchen',
-        refreshFunction: pupilsFilter.refreshs,
+        refreshFunction: pupilsFilter.refresh,
         onChanged: (value) => pupilsFilter.textFilter.setFilterText(value),
         searchTextSource: pupilsFilter.textFilter,
         filtersActive: filterStateManager.filtersActive,

school_data_hub_flutter/lib/features/_authorizations/presentation/authorization_pupils_page/widgets/authorization_pupils_filter_bottom_sheet.dart

@@ -81,7 +81,7 @@ class PupilMediaAuthFilterManager implements Resettable {
       filterState: FilterState.pupil,
       value: !filterStateEqualsInitial,
     );
-    _pupilsFilter.refreshs();
+    _pupilsFilter.refresh();
   }
 
   @override

school_data_hub_flutter/lib/features/_pupil/domain/filters/pupil_media_auth_filters.dart

@@ -63,7 +63,7 @@ abstract class PupilsFilter implements Listenable, Resettable {
 
   // updates the filtered pupils with current filters
   // and sort mode
-  void refreshs();
+  void refresh();
 
   void clearFilteredPupils();
 
@@ -77,6 +77,6 @@ abstract class PupilsFilter implements Listenable, Resettable {
   // void setFilterState();
   void setSortMode(PupilSortMode sortMode);
   void sortPupils();
-  void setTextFilter(String? text, {bool refresh = true});
+  void setTextFilter(String? text, {bool shouldRefresh = true});
   void populateGroupFilters(List<String> groupIds);
 }