Build failing after update to v2.0.0

[johnsimons]

Here is the output from the build:

vite build

vite v7.2.4 building client environment for production...
✓ 1267 modules transformed.
src/components/messages/FlowDiagram/useLayout.ts:1:19 - error TS7016: Could not find a declaration file for module '@dagrejs/dagre'. '/Users/xxxxx/Projects/xxxxxxx/src/Frontend/node_modules/@dagrejs/dagre/dist/dagre.esm.js' implicitly has an 'any' type.
  Try `npm i --save-dev @types/dagrejs__dagre` if it exists or add a new declaration (.d.ts) file containing `declare module '@dagrejs/dagre';`

1 import dagre from "@dagrejs/dagre";

[rustedgrail]

I updated the types. Can you try again off the master branch and let me know if that helps?

I want to make sure these issues are resolved before publishing to npm.

[johnsimons]

I tried the master version and still failing.

I also tried changing the import to import { graphlib, layout } from "@dagrejs/dagre"; and still no good.

The error:

src/components/messages/FlowDiagram/useLayout.ts:1:34 - error TS7016: Could not find a declaration file for module '@dagrejs/dagre'. 'xxxx/src/Frontend/node_modules/@dagrejs/dagre/dist/dagre.esm.js' implicitly has an 'any' type.
  There are types at '/xxxx/src/Frontend/node_modules/@dagrejs/dagre/dist/dagre.d.ts', but this result could not be resolved when respecting package.json "exports". The '@dagrejs/dagre' library may need to update its package.json or typings.

1 import { graphlib, layout } from "@dagrejs/dagre";
                                   ~

[rustedgrail]

But that's a more helpful error message! I added the types to the exports section. That should take care of this issue.

[johnsimons]

@rustedgrail I tried the latest master, and it seems index.d.ts is not defining all the types.
So we are close.
Here are the latest errors from the build.

vite v7.2.4 building client environment for production...
✓ 1267 modules transformed.
src/components/messages/FlowDiagram/useLayout.ts:16:16 - error TS2339: Property 'setDefaultEdgeLabel' does not exist on type 'Graph<{}>'.

16     dagreGraph.setDefaultEdgeLabel(() => ({}));
                  ~~~~~~~~~~~~~~~~~~~

src/components/messages/FlowDiagram/useLayout.ts:19:16 - error TS2339: Property 'setGraph' does not exist on type 'Graph<{}>'.

19     dagreGraph.setGraph({ rankdir: "TB" });
                  ~~~~~~~~

src/components/messages/FlowDiagram/useLayout.ts:25:18 - error TS2339: Property 'setNode' does not exist on type 'Graph<{}>'.

25       dagreGraph.setNode(node.id, { width: graphNode.dimensions.width || 250, height: graphNode.dimensions.height || 55 });
                    ~~~~~~~

src/components/messages/FlowDiagram/useLayout.ts:29:18 - error TS2339: Property 'setEdge' does not exist on type 'Graph<{}>'.

29       dagreGraph.setEdge(edge.source, edge.target);
                    ~~~~~~~

src/components/messages/FlowDiagram/useLayout.ts:36:43 - error TS2339: Property 'node' does not exist on type 'Graph<{}>'.

36       const nodeWithPosition = dagreGraph.node(node.id);
                                             ~~~~


Found 5 errors in the same file, starting at: src/components/messages/FlowDiagram/useLayout.ts:16

[rustedgrail]

Take 3, pushed to master again. Thanks for working on this with me. I'll upgrade Graphlib as well once this is all resolved and hopefully be able to avoid these issues.

[johnsimons]

Just tried master again, and the only errors now are:

vite v7.2.4 building client environment for production...
✓ 1278 modules transformed.
src/components/messages/FlowDiagram/useLayout.ts:8:40 - error TS2339: Property 'Graph' does not exist on type 'typeof graphlib'.

8   const graph = ref(new dagre.graphlib.Graph());
                                         ~~~~~

src/components/messages/FlowDiagram/useLayout.ts:12:43 - error TS2339: Property 'Graph' does not exist on type 'typeof graphlib'.

12     const dagreGraph = new dagre.graphlib.Graph();
                                             ~~~~~


Found 2 errors in the same file, starting at: src/components/messages/FlowDiagram/useLayout.ts:8

So once you fix the Graphlib, that should be it 🤞

[johnsimons]

Actually, just read the error better, it seems the latest change broke it more than before, sorry.

[johnsimons]

You may need to add more JSDoc tags to the code so that the generation of the d.ts file includes all the public APIs.

[rustedgrail]

I think that was because I changed to exporting a type instead of a class, when the real issue was just the name was being shadowed. I expect (and saw in a simple example) that there should be an error, but I think the .d.ts file doesn't go through as much checking as a .ts file does.

[rodrigomsrocha]

any updates on this, i'm getting the same error

[baraknaveh]

Also experiencing: error TS7016: Could not find a declaration file for module '@dagrejs/dagre'.

Looks like the index.d.ts file is missing from the build. It's declared in package.json but not actually packaged.