|
5 | 5 | - Strategy: `single-pr` with explicit user-approved `size-exception`. |
6 | 6 | - Branch: `feat/migrate-catalog-skills-phase1`; base: `main`. |
7 | 7 | - Scope: only the three MIT-backed Bobmatnyc entries `drizzle-orm`, `pydantic`, and `sqlalchemy`. |
8 | | -- Sibling source: `agents-skills` commit `c2e79fbb72d146305f82a8e979270795557d24fd` (PR #18) |
| 8 | +- Sibling source: `agents-skills` merge commit `be4570aa6f23931f51692661d163ddd663b57488` (PR #18) |
9 | 9 | contains the three migrated skill directories and `PROVENANCE.md`; CI checks out this committed |
10 | 10 | revision into `agents-skills` for deterministic resolution. |
11 | 11 |
|
12 | 12 | ## Completed |
13 | 13 |
|
14 | 14 | - Added the three canonical sibling skill directories under `agents-skills/skills/`, including all |
15 | 15 | source-declared reference files and explicit full-source companions for the long Pydantic and |
16 | | - SQLAlchemy documents. These directories are committed in `agents-skills` commit `70298da` (PR |
17 | | - #18); the provenance record pins the upstream immutable source and target file hashes. |
| 16 | + SQLAlchemy documents. These directories are committed in the `agents-skills` PR #18 merge; the |
| 17 | + provenance record pins the upstream immutable source and target file hashes. |
18 | 18 | - Added `agents-skills/PROVENANCE.md` with immutable repository commit, source paths, Git blob/tree |
19 | 19 | identities, attribution, MIT license evidence, materialized file inventory, and companion status. |
20 | 20 | - Remapped only the three catalog definitions and their Drizzle/Pydantic/SQLAlchemy technology |
|
28 | 28 | - Preserved the ignored full-catalog E2E early return because unrelated external entries remain |
29 | 29 | broken. |
30 | 30 |
|
| 31 | +## QA Remediation Handoff (2026-08-14) |
| 32 | + |
| 33 | +- Added `tests/acceptance/phase1_catalog.sh`, a narrow black-box harness that launches an external |
| 34 | + `agentsync` executable, copies only `drizzle-orm`, `pydantic`, and `sqlalchemy` into temporary |
| 35 | + source fixtures, and asserts local installation, companions, registry keys, override precedence, |
| 36 | + fail-closed missing-source behavior, and direct/suggestion project-root propagation. |
| 37 | +- Documented the explicit target as |
| 38 | + `make acceptance-phase1 AGENTSYNC_BIN=target/release/agentsync AGENTSYNC_SOURCE_REPO=../agents-skills`. |
| 39 | + The harness fails clearly when the release-like binary is absent and never calls Rust modules |
| 40 | + directly. The full-catalog early return remains untouched. |
| 41 | +- Refreshed the eight stale materialized hashes in the merged `agents-skills` Phase 1 provenance |
| 42 | + record and added `scripts/validate_provenance.py`, wired into `scripts/validate-skills.sh`, so |
| 43 | + future materialized-byte drift is caught by a focused check. Run |
| 44 | + `AGENTSYNC_SOURCE_REPO=../agents-skills tests/acceptance/test_phase1_provenance.sh` to invoke it. |
| 45 | +- TDD evidence: the missing-binary harness contract failed before the harness existed and passed |
| 46 | + after implementation; provenance validation first failed on the eight stale hashes and passed |
| 47 | + after the refresh. |
| 48 | +- No production source, catalog, registry manifest, full-catalog test, or unrelated untracked |
| 49 | + sibling candidates were changed. QA remains `NOT TESTED`; `sdd-qa` must rerun against the |
| 50 | + documented external target before any acceptance or archive decision. |
| 51 | + |
31 | 52 | ## Verification |
32 | 53 |
|
33 | 54 | - Target sibling validator: pinned `skills-ref validate` passed for all three migrated directories |
|
0 commit comments