Skip to content

Commit c7a2c22

Browse files
authored
docs(sdd): record Phase 1 verification evidence (#559)
1 parent 22e9122 commit c7a2c22

4 files changed

Lines changed: 173 additions & 103 deletions

File tree

openspec/changes/migrate-catalog-skills-phase1/apply-report.md

Lines changed: 24 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,16 +5,16 @@
55
- Strategy: `single-pr` with explicit user-approved `size-exception`.
66
- Branch: `feat/migrate-catalog-skills-phase1`; base: `main`.
77
- Scope: only the three MIT-backed Bobmatnyc entries `drizzle-orm`, `pydantic`, and `sqlalchemy`.
8-
- Sibling source: `agents-skills` commit `c2e79fbb72d146305f82a8e979270795557d24fd` (PR #18)
8+
- Sibling source: `agents-skills` merge commit `be4570aa6f23931f51692661d163ddd663b57488` (PR #18)
99
contains the three migrated skill directories and `PROVENANCE.md`; CI checks out this committed
1010
revision into `agents-skills` for deterministic resolution.
1111

1212
## Completed
1313

1414
- Added the three canonical sibling skill directories under `agents-skills/skills/`, including all
1515
source-declared reference files and explicit full-source companions for the long Pydantic and
16-
SQLAlchemy documents. These directories are committed in `agents-skills` commit `70298da` (PR
17-
#18); the provenance record pins the upstream immutable source and target file hashes.
16+
SQLAlchemy documents. These directories are committed in the `agents-skills` PR #18 merge; the
17+
provenance record pins the upstream immutable source and target file hashes.
1818
- Added `agents-skills/PROVENANCE.md` with immutable repository commit, source paths, Git blob/tree
1919
identities, attribution, MIT license evidence, materialized file inventory, and companion status.
2020
- Remapped only the three catalog definitions and their Drizzle/Pydantic/SQLAlchemy technology
@@ -28,6 +28,27 @@
2828
- Preserved the ignored full-catalog E2E early return because unrelated external entries remain
2929
broken.
3030

31+
## QA Remediation Handoff (2026-08-14)
32+
33+
- Added `tests/acceptance/phase1_catalog.sh`, a narrow black-box harness that launches an external
34+
`agentsync` executable, copies only `drizzle-orm`, `pydantic`, and `sqlalchemy` into temporary
35+
source fixtures, and asserts local installation, companions, registry keys, override precedence,
36+
fail-closed missing-source behavior, and direct/suggestion project-root propagation.
37+
- Documented the explicit target as
38+
`make acceptance-phase1 AGENTSYNC_BIN=target/release/agentsync AGENTSYNC_SOURCE_REPO=../agents-skills`.
39+
The harness fails clearly when the release-like binary is absent and never calls Rust modules
40+
directly. The full-catalog early return remains untouched.
41+
- Refreshed the eight stale materialized hashes in the merged `agents-skills` Phase 1 provenance
42+
record and added `scripts/validate_provenance.py`, wired into `scripts/validate-skills.sh`, so
43+
future materialized-byte drift is caught by a focused check. Run
44+
`AGENTSYNC_SOURCE_REPO=../agents-skills tests/acceptance/test_phase1_provenance.sh` to invoke it.
45+
- TDD evidence: the missing-binary harness contract failed before the harness existed and passed
46+
after implementation; provenance validation first failed on the eight stale hashes and passed
47+
after the refresh.
48+
- No production source, catalog, registry manifest, full-catalog test, or unrelated untracked
49+
sibling candidates were changed. QA remains `NOT TESTED`; `sdd-qa` must rerun against the
50+
documented external target before any acceptance or archive decision.
51+
3152
## Verification
3253

3354
- Target sibling validator: pinned `skills-ref validate` passed for all three migrated directories

openspec/changes/migrate-catalog-skills-phase1/state.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,4 +10,4 @@ completed:
1010
- verify
1111
- qa
1212
next: archive
13-
updated: 2026-08-13
13+
updated: 2026-08-14

openspec/changes/migrate-catalog-skills-phase1/tasks.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,3 +47,10 @@ Size exception: Approved by user for the coherent three-skill Phase 1 unit; bran
4747
- [x] 3.2 Preserve the known full-catalog early return, `#[ignore]`, and `RUN_E2E` gate in `tests/test_catalog_integration.rs`; distinguish subset results from full-catalog status.
4848
- [x] 3.3 Run both-repo validation against the committed sibling revision: target validator/companion audit plus AgentSync focused/unit tests and formatting checks.
4949
- [x] 3.4 Verify `src/skills/registry.v1.toml`, `src/skills/registry.lock.toml`, unrelated sibling skills, and installed-state semantics remain unchanged.
50+
51+
## QA Remediation
52+
53+
- [x] 4.1 Add a reproducible external-CLI acceptance harness with isolated sibling, override, and missing-source fixtures for the three migrated skills.
54+
- [x] 4.2 Exercise direct and suggestion installs through an explicit project root, assert companions and local registry keys, and preserve the full-catalog early return by keeping the harness Phase 1-only.
55+
- [x] 4.3 Refresh the eight stale materialized SHA-256 entries in `../agents-skills/PROVENANCE.md` and add focused provenance validation to the sibling validation wrapper.
56+
- [x] 4.4 Document the acceptance command and hand off results without changing production source or promoting QA to PASS.

0 commit comments

Comments
 (0)