morphology.segment_skeleton returned segment_objects to list#1720
Merged
Conversation
|
Here's the code health analysis summary for commits Analysis Summary
Code Coverage Report
|
k034b363
approved these changes
Jun 24, 2025
k034b363
left a comment
k034b363
left a comment
Contributor
There was a problem hiding this comment.
Using a different image and my own code, I can replicate the error described by the issue that prompted this change. The modification made in this PR fixes it and allows for downstream use of the objects from segment_skeleton.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
The
segment_objectsreturned bypcv.morphology.segment_skeletonis supposed to be a list of OpenCV contours. This change casts the tuple type list of objects into a properlisttype object.Type of update
Is this a:
Associated issues
Additional context
It appears that something upstream changed within
cv2.findContourswhich formats the contours inside a tuple. This causes an error downstream within thepcv.morphology.fill_segmentsanalysis function, sincetupletype objects are not supported with the operation.copy()which the function does to preserve the input list of objects/contours.For the reviewer
See this page for instructions on how to review the pull request.
plantcv/mkdocs.ymlupdating.md