add "thermal" mode to readimage()#1727
Merged
Merged
Conversation
|
Here's the code health analysis summary for commits Analysis Summary
Code Coverage Report
|
k034b363
requested changes
Jul 7, 2025
k034b363
left a comment
k034b363
left a comment
Contributor
There was a problem hiding this comment.
Tested on an example image from Annika and also a random image from a dataset available on the internet, and both worked just fine. Just making this comment because Annika and I already talked about perhaps finding a smaller example image for the tests if possible. It should be good to go after that.
k034b363
approved these changes
Jul 7, 2025
k034b363
left a comment
k034b363
left a comment
Contributor
There was a problem hiding this comment.
Looks good now, tests are passing with the new image.
nfahlgren
added
new feature
nfahlgren
requested changes
Jul 9, 2025
nfahlgren
left a comment
nfahlgren
left a comment
Member
There was a problem hiding this comment.
The PR looks great! I just want to add a blocking step because we need to create a conda-forge recipe for flyr before we merge (or really just before we release v4.9).
nfahlgren
approved these changes
Aug 25, 2025
nfahlgren
added
ready to review
and removed
work in progress
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
A clear and concise description of what changes are made by this pull request.
An addition to
readimagethat can read in thermal images using the flyr package.Type of update
Is this a:
Associated issues
Reference associated issue numbers. Does this pull request close any issues?
#1724
Additional context
Add any other context about the problem here.
For the reviewer
See this page for instructions on how to review the pull request.
plantcv/mkdocs.ymlupdating.md