Hi,
The function DSToken.transferFrom emits an event Transfer, which is not documented in the README doc.
|
emit Transfer(src, dst, wad); |
A potential fix could be adding "Emits a Transfer event" to the README doc.
Furthermore, function DSToken.transfer calls the function transferFrom. So it also emits the event Transfer.
|
return transferFrom(msg.sender, dst, wad); |
A potential fix could be also adding "Emits a Transfer event" to this function in the README doc.
Could you please check it?
Thanks.
Hi,
The function
DSToken.transferFromemits an eventTransfer, which is not documented in the README doc.ds-token/src/token.sol
Line 80 in 16f187a
A potential fix could be adding "Emits a
Transferevent" to the README doc.Furthermore, function
DSToken.transfercalls the functiontransferFrom. So it also emits the eventTransfer.ds-token/src/token.sol
Line 63 in 16f187a
A potential fix could be also adding "Emits a
Transferevent" to this function in the README doc.Could you please check it?
Thanks.