Skip to content

Commit e88153b

Browse files
committed
fix vignettes
1 parent d5626ac commit e88153b

2 files changed

Lines changed: 6 additions & 14 deletions

File tree

vignettes/migration.Rmd

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -424,16 +424,16 @@ Creating objects is the `log4r` way of handling multiple log environments, while
424424

425425
Sorry, no direct replacement for [`loggit`](https://cran.r-project.org/package=loggit) -- capturing `message`, `warning` and `stop` function messages, but it's on the [roadmap](https://github.com/daroczig/logger/issues/6) to provide helper functions to be used as message hooks feed `logger`.
426426

427-
```{r echo=FALSE, results='hide'}
428-
detach('package:logger', unload = TRUE)
429-
detach('package:futile.logger', unload = TRUE)
430-
detach('package:logging', unload = TRUE)
431-
```
432-
433427
```{r cleanup, include = FALSE}
434428
## restore settings
435429
log_threshold(oldconf$threshold)
436430
log_layout(oldconf$layout)
437431
log_formatter(oldconf$formatter)
438432
log_appender(oldconf$appender)
439433
```
434+
435+
```{r echo=FALSE, results='hide'}
436+
detach('package:logger', unload = TRUE)
437+
detach('package:futile.logger', unload = TRUE)
438+
detach('package:logging', unload = TRUE)
439+
```

vignettes/performance.Rmd

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -107,11 +107,3 @@ microbenchmark(async(), times = 1e3)
107107
```
108108

109109
Please note that although this ~0.6 ms is significantly higher than the ~0.15 ms we achieved above with the `sprintf` formatter, but this time we are calling an appender that would take 1 full second to deliver the log message (and not just printing to the console), so bringing that down to less than 1 millisecond is not too bad. If you need even higher throughput, then a custom `appender_async` without checking on the background process and potentially a faster message queue can bring this even below to 200 µs.
110-
111-
```{r cleanup, include = FALSE}
112-
## restore settings
113-
log_threshold(oldconf$threshold)
114-
log_layout(oldconf$layout)
115-
log_formatter(oldconf$formatter)
116-
log_appender(oldconf$appender)
117-
```

0 commit comments

Comments
 (0)