Windows paths with driver letters not supported

[FelixSchwarz]

I'm trying to use requests-file on Windows using an absolute path like this: "file://C:/foo/bar".

The problem is that the current code uses urlparse() and .netloc contains "C:" in that case which triggers an exception:

requests-file/requests_file.py

Line 36 in 829ecea

if url_parts.netloc and url_parts.netloc != "localhost":

Just to demonstrate the problem:

>>> from requests.compat import urlparse
>>> urlparse('file://C:/foo/bar')
ParseResult(scheme='file', netloc='C:', path='/foo/bar', params='', query='', fragment='')

Background: I'm trying to add support for local repositories in conda-lock and that project tries to support also Windows users.

Do you think we could add a workaround to support Windows drive letters? (just on Windows)

[dashea]

Hi. There are a handful of ways to express windows paths containing drive letters as file URIs. This is not one of them. Two /'s after the file: indicates that the next component is a hostname, which is allowed in the file URI format for certain platform-specific non-local file locations, and that isn't what you want here.

Here's how the urlparse results look using a few of the examples from RFC 8089:

>>> urlparse('file:///C:/foo/bar')
ParseResult(scheme='file', netloc='', path='/C:/foo/bar', params='', query='', fragment='')
>>> urlparse('file:///C|/foo/bar')
ParseResult(scheme='file', netloc='', path='/C|/foo/bar', params='', query='', fragment='')
>>> urlparse('file:C:/foo/bar')
ParseResult(scheme='file', netloc='', path='C:/foo/bar', params='', query='', fragment='')

There is handling for both the C: and C| style of drive letters in URIs. Hope this helps.

[FelixSchwarz]

Doh - somehow I missed that. Thank you very much for the explanation.