Skip to content

Commit d9ae2b2

Browse files
EdsonPetryclaude
andauthored
Fix benchmarks build: remove nonexistent with_distributed_dynamic_task_count call (#488)
## Summary - Commit `0d4e239` (Benchmarks housekeeping) introduced a `dynamic: bool` field in `RunOpt` and called `.with_distributed_dynamic_task_count(self.dynamic)?` in `RunOpt::run_local` - That method was never implemented in `distributed_ext.rs`, so the `dfbench` binary has been broken since that commit - This PR removes the two dead lines (the struct field and the call site) ## Verification Checked out to `0d4e239` and confirmed the compile error: ``` error[E0599]: no method named `with_distributed_dynamic_task_count` found for struct `SessionStateBuilder` --> benchmarks/src/run.rs:212:14 ``` After this fix, `cargo build -p datafusion-distributed-benchmarks --bin dfbench` compiles cleanly. Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent 003ee87 commit d9ae2b2

1 file changed

Lines changed: 0 additions & 5 deletions

File tree

benchmarks/src/run.rs

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -105,10 +105,6 @@ pub struct RunOpt {
105105
#[structopt(long, default_value = "0")]
106106
max_tasks_per_stage: usize,
107107

108-
/// Activate dynamic task count
109-
#[structopt(long)]
110-
dynamic: bool,
111-
112108
/// Number of iterations of each test run
113109
#[structopt(short = "i", long = "iterations", default_value = "5")]
114110
iterations: usize,
@@ -209,7 +205,6 @@ impl RunOpt {
209205
.with_distributed_cardinality_effect_task_scale_factor(
210206
self.cardinality_task_sf.unwrap_or(1.0),
211207
)?
212-
.with_distributed_dynamic_task_count(self.dynamic)?
213208
.with_distributed_compression(match self.compression.as_str() {
214209
"zstd" => Some(CompressionType::ZSTD),
215210
"lz4" => Some(CompressionType::LZ4_FRAME),

0 commit comments

Comments
 (0)