Run dbatools.Tests.ps1 in any case

[andreasjordan]

Summarize Functionality

If tests are filtered to changed files, dbatools.Tests.ps1 is not run and does not check for correct styling. So this test should always be included.

@niphlod - Do you have time to change the code? Otherwise I can try to have a look at the logic.

Are there other "general" tests that should be run in any case?

Is there a command that is similiar or close to what you are looking for?

Yes

Technical Details

No response

[andreasjordan]

Currently the test is not doing what it should:

Completed C:\github\dbatools\tests\dbatools.Tests.ps1 in 56ms

That is way to fast to check all formatting.

[andreasjordan]

I ran the formatting test manually and these commands are failing:

Mode                 LastWriteTime         Length Name                                                                                                                                               
----                 -------------         ------ ----                                                                                                                                               
-a----         1/25/2026   2:21 PM           9995 Compare-DbaAgReplicaAgentJob.ps1                                                                                                                   
-a----         1/25/2026   2:21 PM           8413 Compare-DbaAgReplicaCredential.ps1                                                                                                                 
-a----         1/25/2026   2:21 PM          11389 Compare-DbaAgReplicaLogin.ps1                                                                                                                      
-a----         1/25/2026   2:21 PM           8236 Compare-DbaAgReplicaOperator.ps1                                                                                                                   
-a----         1/25/2026   2:21 PM          31081 Compare-DbaAgReplicaSync.ps1                                                                                                                       
-a----         1/25/2026   2:21 PM          20900 Export-DbaDacPackage.ps1                                                                                                                           
-a----         1/25/2026   2:21 PM          13426 Get-DbaAgentJob.ps1                                                                                                                                
-a----         1/25/2026   2:21 PM          10473 Get-DbaReplArticleColumn.ps1                                                                                                                       
-a----         1/25/2026   2:21 PM          85142 Import-DbaCsv.ps1                                                                                                                                  
-a----         1/25/2026   2:21 PM         117397 Invoke-DbaDbLogShipping.ps1                                                                                                                        
-a----         1/25/2026   2:21 PM          26293 Reset-DbaAdmin.ps1  

[andreasjordan]

I changed my mind. We should have a look at what the tests actually tests. I think some parts don't work. And testing the format of every command every time is a bad idea. We test the parameters in every command-test, so should we do with the formatting.

[andreasjordan]

Formating is a rabbit hole... As we use Where-Object $x -eq A we can not use Invoke-DbatoolsFormatter anymore. We would need a custom ruleset and exclude "PSUseCorrectCasing".

Copilot says this would work:

@{
    # Disable the rule that would upcase -in in the parameterized Where-Object form
    Rules = @{
        PSUseCorrectCasing = @{
            Enable = $false
        }
    }

    # Formatting choices equivalent to the "OTBS" style
    CodeFormatting = @{
        OpenBraceOnSameLine        = $true     # OTBS: { on same line
        NewLineAfterOpenBrace      = $true
        NewLineBeforeCloseBrace    = $true
        IgnoreOneLineBlock         = $true

        WhitespaceBeforeOpenBrace  = $true
        WhitespaceBeforeOpenParen  = $true
        WhitespaceAroundOperator   = $true
        WhitespaceAfterSeparator   = $true

        PipelineIndentation        = 'IncreaseIndentationForFirstPipeline'
        AlignPropertyValuePairs    = $true
        UseConstantStrings         = $false
        AutoCorrectFormatting      = $true
    }

    # (Optional) Choose which formatting rules to run explicitly
    IncludeRules = @(
        'PSPlaceOpenBrace',
        'PSPlaceCloseBrace',
        'PSUseConsistentWhitespace',
        'PSUseConsistentIndentation',
        'PSAlignAssignmentStatement',
        'PSUseConsistentDelimiter',
        'PSAvoidSemicolonsAsLineTerminators',
        'PSAvoidUsingEmptyCatchBlock'
    )
}

[niphlod]

It's a "problem" on the version of psscriptanalyzer rather than anything else and we already raised an issue in their own repo. Keep pinned the version of psscriptanalyzer that Always has been there and for the time being we won't have to switch to uppercase operators. Il mar 27 gen 2026, 19:46 Andreas Jordan ***@***.***> ha scritto:

…

*andreasjordan* left a comment (dataplat/dbatools#10119) <#10119 (comment)> Formating is a rabbit hole... As we use Where-Object $x -eq A we can not use Invoke-DbatoolsFormatter anymore. We would need a custom ruleset and exclude "PSUseCorrectCasing". Copilot says this would work: @{ # Disable the rule that would upcase -in in the parameterized Where-Object form Rules = @{ PSUseCorrectCasing = @{ Enable = $false } } # Formatting choices equivalent to the "OTBS" style CodeFormatting = @{ OpenBraceOnSameLine = $true # OTBS: { on same line NewLineAfterOpenBrace = $true NewLineBeforeCloseBrace = $true IgnoreOneLineBlock = $true WhitespaceBeforeOpenBrace = $true WhitespaceBeforeOpenParen = $true WhitespaceAroundOperator = $true WhitespaceAfterSeparator = $true PipelineIndentation = 'IncreaseIndentationForFirstPipeline' AlignPropertyValuePairs = $true UseConstantStrings = $false AutoCorrectFormatting = $true } # (Optional) Choose which formatting rules to run explicitly IncludeRules = @( 'PSPlaceOpenBrace', 'PSPlaceCloseBrace', 'PSUseConsistentWhitespace', 'PSUseConsistentIndentation', 'PSAlignAssignmentStatement', 'PSUseConsistentDelimiter', 'PSAvoidSemicolonsAsLineTerminators', 'PSAvoidUsingEmptyCatchBlock' ) } — Reply to this email directly, view it on GitHub <#10119 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAA52B5VMLW6MCWQZYVQ7SL4I6XABAVCNFSM6AAAAACTBRXM6CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTQMBWHA4DKNZZGA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[niphlod]

BTW, I can work on it but after mid-Feb