Vim themes have been broken for 3 years

[gpakosz]

Hello,

Today, switching from Mac to Linux, I noticed the Vim themes have been broken for a while. The reason is that all the colorscheme files have lowercase + dash separator filenames, e.g. patriot-contrast.vim while inside the colorscheme definition file, the colors_name variable uses title case and spaces, e.g.

let g:colors_name = "Patriot Contrast"
let colors_name   = "Patriot Contrast"

As such, when you do colorscheme patriot-contrast, colors don't apply properly. And if you do :syntax enable you get the following error message:

Error detected while processing /usr/share/vim/vim80/syntax/synload.vim:
line 19:
E185: Cannot find color scheme 'Patriot Contrast'

It seems either renaming the patriot-contrast.vim file or changing the value of the colors_name variable fixes it.