Skip to content

Commit 41667dd

Browse files
committed
fix: creator-hub e2e runner
1 parent c0bfe6f commit 41667dd

4 files changed

Lines changed: 15 additions & 14 deletions

File tree

.github/workflows/e2e.yml

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -16,22 +16,27 @@ jobs:
1616

1717
- uses: actions/setup-node@v4
1818
with:
19-
node-version: 22.12.0
19+
node-version: 22
20+
cache: 'npm'
2021

21-
- name: Install dependencies
22-
run: npm ci
22+
- name: install
23+
run: make install
2324

24-
- name: Build
25-
run: npm run build
25+
- name: protoc
26+
run: make protoc
27+
28+
- name: build
29+
run: make build
2630
env:
2731
NODE_OPTIONS: "--max-old-space-size=8192"
2832
MODE: production
2933
E2E: true
3034
E2E_WALLET: ${{ secrets.E2E_WALLET }}
3135

32-
- name: Run Playwright tests
33-
run: npx playwright test
36+
- name: e2e
37+
run: make test-creator-hub-e2e
3438
env:
39+
NODE_OPTIONS: "--max-old-space-size=8192"
3540
E2E_NAME: ${{ secrets.E2E_NAME }}
3641
E2E_PRIVATE_KEY: ${{ secrets.E2E_PRIVATE_KEY }}
3742
E2E_EXPIRATION_MINUTES: 10

.github/workflows/tests.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ jobs:
7272
npx http-server public -p 8000 --cors -a localhost &
7373
sleep 5
7474
75-
- name: e2e
76-
run: make test-e2e
75+
- name: e2e inspector
76+
run: make test-inspector-e2e
7777
env:
7878
NODE_OPTIONS: "--max-old-space-size=8192"

Makefile

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -82,10 +82,6 @@ typecheck:
8282
test:
8383
npm run test
8484

85-
test-e2e:
86-
make test-inspector-e2e
87-
make test-creator-hub-e2e
88-
8985
test-inspector-e2e:
9086
cd $(INSPECTOR_PATH)/; npm run test:e2e
9187

packages/creator-hub/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@
7575
"postinstall": "cross-env ELECTRON_RUN_AS_NODE=1 electron scripts/update-electron-vendors.js",
7676
"start": "npm run watch",
7777
"test": "npm run test:unit",
78-
"test:e2e": "cross-env E2E='true' npm run build && playwright test",
78+
"test:e2e": "cross-env E2E='true' playwright test",
7979
"test:main": "vitest run -r main --passWithNoTests",
8080
"test:preload": "vitest run -r preload --passWithNoTests",
8181
"test:renderer": "vitest run -r renderer --passWithNoTests",

0 commit comments

Comments
 (0)