Skip to content

Commit 1ef1f51

Browse files
committed
fix(perf): bump build URL + preserve perf.csv on PerfSampler.End failure
Bump cloud_build_url default to pr-22430-3a0b8d5, which carries the PerfSampler.PercentWorst guard against tiny sample windows (decentraland/unity-explorer#8826). Improve AttachPerf diagnostics: log ex.ToString() instead of just ex.Message so AltTester's wrapped TargetInvocationException reveals the real Player-side stack in the Allure report. Best-effort attach perf.csv on the End-failure path — PerfSampler.End disposes the CSV before WriteSummary runs, so a summary-side crash still leaves a complete CSV on disk that can be inspected post-mortem.
1 parent 76e500a commit 1ef1f51

2 files changed

Lines changed: 13 additions & 2 deletions

File tree

.github/workflows/runner-validation-windows.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ on:
5252
# at every severity), AND the TEMP-gut that bypasses MinimumSpecsScreen modal
5353
# so the T4 runner (4 vCPU - fails MinimumSpecsGuard) doesn't hang awaiting
5454
# a human click. Revert to '' to fall back to "latest non-prerelease release".
55-
default: 'https://explorer-artifacts.decentraland.org/@dcl/unity-explorer/branch/feat/test-automation/autopilot-alttester/pr-22429-d800d89/Decentraland_windows64.zip'
55+
default: 'https://explorer-artifacts.decentraland.org/@dcl/unity-explorer/branch/feat/test-automation/autopilot-alttester/pr-22430-3a0b8d5/Decentraland_windows64.zip'
5656
test_filter:
5757
description: 'NUnit --filter expression. Default runs the full InWorld category (~17 tests).'
5858
type: string

explorer/Tests/Tests/BaseTest.cs

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,18 @@ public void AttachPerf()
7171
}
7272
catch (Exception ex)
7373
{
74-
Reporter.Log($"PerfSampler.End call failed (Player crash?): {ex.Message}");
74+
// AltTester wraps the Player-side exception in a TargetInvocationException;
75+
// ex.Message is the unhelpful "Exception has been thrown by the target of an
76+
// invocation." Log ToString() so the inner trace from AltTester's error
77+
// payload makes it into the Allure report.
78+
Reporter.Log($"PerfSampler.End call failed (Player crash?):\n{ex}");
79+
80+
// Best-effort: PerfSampler closes the CSV BEFORE writing the summary, so a
81+
// summary-side crash still leaves a complete perf.csv on disk. Attach what
82+
// we have so a chassis run with a broken summary writer is still
83+
// post-mortemable.
84+
if (File.Exists(_perfCsvPath))
85+
AllureApi.AddAttachment("perf.csv", "text/csv", File.ReadAllBytes(_perfCsvPath));
7586
return;
7687
}
7788

0 commit comments

Comments
 (0)