Skip to content

docs: add REVIEW.md with blocking PR review rules #9102

docs: add REVIEW.md with blocking PR review rules

docs: add REVIEW.md with blocking PR review rules #9102

Triggered via pull request August 18, 2026 16:24
Status Success
Total duration 3m 47s
Artifacts 7

ci.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

10 errors and 21 warnings
lint: packages/@dcl/ecs/src/components/extended/Material.ts#L486
Replace `private·getMaterial:·()·=>·PBMaterial,·private·field:·TextureField` with `⏎····private·getMaterial:·()·=>·PBMaterial,⏎····private·field:·TextureField⏎··`
lint: packages/@dcl/ecs/src/components/extended/AudioSource.ts#L49
Replace `existing?.currentTime·??·0` with `(existing?.currentTime·??·0)`
lint: packages/@dcl/ecs/src/components/extended/AudioAnalysis.ts#L114
Replace `⏎······entity:·Entity,⏎······mode?:·PBAudioAnalysisMode,⏎······amplitudeGain?:·number,⏎······bandsGain?:·number⏎····` with `entity:·Entity,·mode?:·PBAudioAnalysisMode,·amplitudeGain?:·number,·bandsGain?:·number`
lint: packages/@dcl/ecs/src/components/extended/AudioAnalysis.ts#L6
Replace `⏎··extends·LastWriteWinElementSetComponentDefinition<PBAudioAnalysis>·{⏎` with `·extends·LastWriteWinElementSetComponentDefinition<PBAudioAnalysis>·{`
lint
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: actions/setup-node@v3. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
lint: packages/@dcl/sdk-commands/src/logic/dcl-ignore.ts#L35
'e' is defined but never used. Allowed unused caught errors must match /^_/u
lint: packages/@dcl/sdk-commands/src/components/fs.ts#L46
'error' is defined but never used. Allowed unused caught errors must match /^_/u
lint: packages/@dcl/sdk-commands/src/components/fs.ts#L39
'error' is defined but never used. Allowed unused caught errors must match /^_/u
lint: packages/@dcl/sdk-commands/src/commands/quests/utils.ts#L242
'error' is defined but never used. Allowed unused caught errors must match /^_/u
lint: packages/@dcl/sdk-commands/src/commands/quests/utils.ts#L182
'error' is defined but never used. Allowed unused caught errors must match /^_/u
lint: packages/@dcl/sdk-commands/src/commands/quests/index.ts#L117
'error' is defined but never used. Allowed unused caught errors must match /^_/u
lint: packages/@dcl/sdk-commands/src/commands/get-context-files/index.ts#L92
'error' is defined but never used. Allowed unused caught errors must match /^_/u
lint: packages/@dcl/sdk-commands/src/commands/code-to-composite/scene-executor.ts#L276
'args' is defined but never used. Allowed unused args must match /^_/u
lint: packages/@dcl/sdk/src/testing/assert.ts#L121
'e' is defined but never used. Allowed unused caught errors must match /^_/u
lint: packages/@dcl/ecs/src/systems/events.ts#L271
'interactionType' is assigned a value but never used. Allowed unused args must match /^_/u
docs
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: actions/setup-node@v3. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
build
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: actions/setup-node@v3, actions/upload-artifact@v4, decentraland/oddish-action@master. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
Check for development dependencies
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: actions/checkout@v3, actions/download-artifact@v4, actions/setup-node@v3. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
Deployment Notification
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: actions/github-script@v6, peter-evans/create-or-update-comment@v1, peter-evans/find-comment@v1. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
Deployment Notification
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Deployment Notification
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Deployment Notification
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Deployment Notification
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
CLI E2E
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: actions/setup-node@v3. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
test
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: actions/setup-node@v3, codecov/codecov-action@v3. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/

Artifacts

Produced during runtime
Name Size Digest
built-artifacts
3.69 MB
sha256:86b03e251370d9e48d8ba77f82ef400a7afcab6e08010afc7225889c35f451a3
dcl-ecs-7.26.1-32160133941.commit-0d52f85.tgz
264 KB
sha256:07766d11504d08d3545871fd5d923dd97c328560424092784424d4234fb3335c
dcl-js-runtime-7.26.1-32160133941.commit-0d52f85.tgz
12.7 KB
sha256:4105e908d59eb899a063f5f9200cfa7fd2188a05e61a3a8c2aec0815cdc93ac1
dcl-playground-assets-7.26.1-32160133941.commit-0d52f85.tgz
604 KB
sha256:ff1f98c75440b5c586fd7b3e8586a0a63e167e7ae10a86b157b97816d26f4722
dcl-react-ecs-7.26.1-32160133941.commit-0d52f85.tgz
27.5 KB
sha256:a1a47a28db6f0c4e55818a44915eee615c8d53e0f9506b3c6f75001d3aa26ef2
dcl-sdk-7.26.1-32160133941.commit-0d52f85.tgz
116 KB
sha256:dbb57f7a4c7cd0aaae9a9d5a2e53e5788cf6acecd12af7e001f888809927a954
dcl-sdk-commands-7.26.1-32160133941.commit-0d52f85.tgz
143 KB
sha256:1968a5c40236c0f99c89b24ccd320adc1fb84cf141a2f029294dd00e9010c54a