Skip to content

Commit 1309a55

Browse files
authored
chore: update particle system bursts property (#1375)
1 parent 33014a1 commit 1309a55

20 files changed

Lines changed: 77 additions & 66 deletions

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ temp
44
tsdoc-metadata.json
55
coverage
66
**/.DS_Store
7+
.idea
78
packages/**/*.js
89
packages/@dcl/sdk/package-lock.json
910
packages/@dcl/sdk/**/*.js

package-lock.json

Lines changed: 7 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
"bugs": "https://github.com/decentraland/js-sdk-toolchain/issues",
77
"dependencies": {
88
"@actions/core": "^1.10.0",
9-
"@dcl/protocol": "1.0.0-23951495761.commit-bf007b9",
9+
"@dcl/protocol": "1.0.0-24513367586.commit-0ed6dc3",
1010
"@dcl/quickjs-emscripten": "^0.21.0-3680274614.commit-1808aa1",
1111
"@dcl/ts-proto": "1.153.0",
1212
"@types/fs-extra": "^9.0.12",

packages/@dcl/playground-assets/etc/playground-assets.api.md

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3013,7 +3013,7 @@ export interface PBParticleSystem {
30133013
additionalForce?: PBVector3 | undefined;
30143014
billboard?: boolean | undefined;
30153015
blendMode?: PBParticleSystem_BlendMode | undefined;
3016-
bursts: PBParticleSystem_Burst[];
3016+
bursts?: PBParticleSystem_BurstConfiguration | undefined;
30173017
// Warning: (tsdoc-escape-right-brace) The "}" character should be escaped using a backslash to avoid confusion with a TSDoc inline tag
30183018
// Warning: (tsdoc-malformed-inline-tag) Expecting a TSDoc tag starting with "{@"
30193019
colorOverTime?: ColorRange | undefined;
@@ -3102,6 +3102,20 @@ export namespace PBParticleSystem_Burst {
31023102
export function encode(message: PBParticleSystem_Burst, writer?: _m0.Writer): _m0.Writer;
31033103
}
31043104

3105+
// @public (undocumented)
3106+
export interface PBParticleSystem_BurstConfiguration {
3107+
// (undocumented)
3108+
values: PBParticleSystem_Burst[];
3109+
}
3110+
3111+
// @public (undocumented)
3112+
export namespace PBParticleSystem_BurstConfiguration {
3113+
// (undocumented)
3114+
export function decode(input: _m0.Reader | Uint8Array, length?: number): PBParticleSystem_BurstConfiguration;
3115+
// (undocumented)
3116+
export function encode(message: PBParticleSystem_BurstConfiguration, writer?: _m0.Writer): _m0.Writer;
3117+
}
3118+
31053119
// @public (undocumented)
31063120
export interface PBParticleSystem_Cone {
31073121
angle?: number | undefined;

packages/@dcl/sdk-commands/package-lock.json

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/@dcl/sdk-commands/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
"@dcl/inspector": "7.25.0",
1515
"@dcl/linker-dapp": "0.15.2",
1616
"@dcl/mini-comms": "1.0.1-20230216163137.commit-a4c75be",
17-
"@dcl/protocol": "1.0.0-23951495761.commit-bf007b9",
17+
"@dcl/protocol": "1.0.0-24513367586.commit-0ed6dc3",
1818
"@dcl/quests-client": "^1.0.3",
1919
"@dcl/quests-manager": "^0.1.4",
2020
"@dcl/rpc": "^1.1.1",

test/ecs/components/ParticleSystem.spec.ts

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ const emptyPS = {
3434
simulationSpace: undefined,
3535
limitVelocity: undefined,
3636
playbackState: undefined,
37-
bursts: [] as const
37+
bursts: undefined
3838
}
3939

4040
describe('Generated ParticleSystem ProtoBuf', () => {
@@ -189,10 +189,10 @@ describe('Generated ParticleSystem ProtoBuf', () => {
189189
...emptyPS,
190190
rate: 10,
191191
lifetime: 5,
192-
bursts: [
192+
bursts: { values: [
193193
{ time: 0, count: 20, cycles: 3, interval: 0.5, probability: 1.0 },
194194
{ time: 2.0, count: 50, cycles: undefined, interval: undefined, probability: undefined }
195-
]
195+
] }
196196
})
197197
})
198198

@@ -204,7 +204,6 @@ describe('Generated ParticleSystem ProtoBuf', () => {
204204
ParticleSystem.create(entity, {
205205
rate: 10,
206206
lifetime: 5,
207-
bursts: [],
208207
shape: ParticleSystem.Shape.Cone({ angle: 30, radius: 1 })
209208
})
210209

@@ -219,7 +218,6 @@ describe('Generated ParticleSystem ProtoBuf', () => {
219218

220219
ParticleSystem.create(entity, {
221220
rate: 5,
222-
bursts: [],
223221
shape: ParticleSystem.Shape.Point()
224222
})
225223

@@ -232,7 +230,6 @@ describe('Generated ParticleSystem ProtoBuf', () => {
232230
const entity = newEngine.addEntity()
233231

234232
ParticleSystem.create(entity, {
235-
bursts: [],
236233
shape: ParticleSystem.Shape.Sphere({ radius: 3 })
237234
})
238235

@@ -245,7 +242,6 @@ describe('Generated ParticleSystem ProtoBuf', () => {
245242
const entity = newEngine.addEntity()
246243

247244
ParticleSystem.create(entity, {
248-
bursts: [],
249245
shape: ParticleSystem.Shape.Box({ size: { x: 1, y: 2, z: 3 } })
250246
})
251247

test/snapshots/development-bundles/static-scene.test.ts.crdt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
SCENE_COMPILED_JS_SIZE_PROD=551.2k bytes
1+
SCENE_COMPILED_JS_SIZE_PROD=552.5k bytes
22
THE BUNDLE HAS SOURCEMAPS
33
(start empty vm 0.21.0-3680274614.commit-1808aa1)
44
OPCODES ~= 0k
@@ -11,8 +11,8 @@ EVAL test/snapshots/development-bundles/static-scene.test.js
1111
REQUIRE: ~system/EngineApi
1212
REQUIRE: ~system/EngineApi
1313
OPCODES ~= 65k
14-
MALLOC_COUNT = 15824
15-
ALIVE_OBJS_DELTA ~= 3.13k
14+
MALLOC_COUNT = 15843
15+
ALIVE_OBJS_DELTA ~= 3.14k
1616
CALL onStart()
1717
main.crdt: PUT_COMPONENT e=0x200 c=1 t=0 data={"position":{"x":5.880000114440918,"y":2.7916901111602783,"z":7.380000114440918},"rotation":{"x":0,"y":0,"z":0,"w":1},"scale":{"x":1,"y":1,"z":1},"parent":0}
1818
main.crdt: PUT_COMPONENT e=0x202 c=1 t=0 data={"position":{"x":4,"y":0.800000011920929,"z":8},"rotation":{"x":0,"y":0,"z":0,"w":1},"scale":{"x":1,"y":1,"z":1},"parent":0}
@@ -56,4 +56,4 @@ CALL onUpdate(0.1)
5656
OPCODES ~= 4k
5757
MALLOC_COUNT = -5
5858
ALIVE_OBJS_DELTA ~= 0.00k
59-
MEMORY_USAGE_COUNT ~= 1397.63k bytes
59+
MEMORY_USAGE_COUNT ~= 1399.84k bytes

test/snapshots/development-bundles/testing-fw.test.ts.crdt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
SCENE_COMPILED_JS_SIZE_PROD=551.7k bytes
1+
SCENE_COMPILED_JS_SIZE_PROD=553k bytes
22
THE BUNDLE HAS SOURCEMAPS
33
(start empty vm 0.21.0-3680274614.commit-1808aa1)
44
OPCODES ~= 0k
@@ -11,8 +11,8 @@ EVAL test/snapshots/development-bundles/testing-fw.test.js
1111
REQUIRE: ~system/EngineApi
1212
REQUIRE: ~system/EngineApi
1313
OPCODES ~= 74k
14-
MALLOC_COUNT = 16376
15-
ALIVE_OBJS_DELTA ~= 3.29k
14+
MALLOC_COUNT = 16395
15+
ALIVE_OBJS_DELTA ~= 3.30k
1616
CALL onStart()
1717
LOG: ["Adding one to position.y=0"]
1818
Renderer: PUT_COMPONENT e=0x0 c=1 t=1 data={"position":{"x":1,"y":0,"z":0},"rotation":{"x":0,"y":0,"z":0,"w":1},"scale":{"x":9,"y":9,"z":9},"parent":0}
@@ -62,4 +62,4 @@ CALL onUpdate(0.1)
6262
OPCODES ~= 6k
6363
MALLOC_COUNT = -53
6464
ALIVE_OBJS_DELTA ~= -0.01k
65-
MEMORY_USAGE_COUNT ~= 1404.04k bytes
65+
MEMORY_USAGE_COUNT ~= 1406.25k bytes

test/snapshots/development-bundles/two-way-crdt.test.ts.crdt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
SCENE_COMPILED_JS_SIZE_PROD=551.7k bytes
1+
SCENE_COMPILED_JS_SIZE_PROD=553k bytes
22
THE BUNDLE HAS SOURCEMAPS
33
(start empty vm 0.21.0-3680274614.commit-1808aa1)
44
OPCODES ~= 0k
@@ -11,8 +11,8 @@ EVAL test/snapshots/development-bundles/two-way-crdt.test.js
1111
REQUIRE: ~system/EngineApi
1212
REQUIRE: ~system/EngineApi
1313
OPCODES ~= 74k
14-
MALLOC_COUNT = 16376
15-
ALIVE_OBJS_DELTA ~= 3.29k
14+
MALLOC_COUNT = 16395
15+
ALIVE_OBJS_DELTA ~= 3.30k
1616
CALL onStart()
1717
LOG: ["Adding one to position.y=0"]
1818
Renderer: PUT_COMPONENT e=0x0 c=1 t=1 data={"position":{"x":1,"y":0,"z":0},"rotation":{"x":0,"y":0,"z":0,"w":1},"scale":{"x":9,"y":9,"z":9},"parent":0}
@@ -62,4 +62,4 @@ CALL onUpdate(0.1)
6262
OPCODES ~= 6k
6363
MALLOC_COUNT = -53
6464
ALIVE_OBJS_DELTA ~= -0.01k
65-
MEMORY_USAGE_COUNT ~= 1404.04k bytes
65+
MEMORY_USAGE_COUNT ~= 1406.25k bytes

0 commit comments

Comments
 (0)