Skip to content

Commit 196680f

Browse files
authored
chore: pin Node to 24.16.0 to avoid regressions in newer 24.x (#1425) (#1426)
CI resolved node-version: 24 to the latest 24.x, risking drift past 24.16.0, which introduces bugs. Lock CI, .node-version, and engines to the exact known-good version.
1 parent 2ed854e commit 196680f

4 files changed

Lines changed: 9 additions & 9 deletions

File tree

.github/workflows/ci.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ jobs:
2020
- uses: actions/checkout@master
2121
- uses: actions/setup-node@v3
2222
with:
23-
node-version: 24
23+
node-version: 24.16.0
2424
cache: 'npm'
2525
- name: install
2626
run: make install
@@ -35,7 +35,7 @@ jobs:
3535
- uses: actions/checkout@master
3636
- uses: actions/setup-node@v3
3737
with:
38-
node-version: 24
38+
node-version: 24.16.0
3939
cache: 'npm'
4040
- name: docs
4141
run: make docs
@@ -47,7 +47,7 @@ jobs:
4747

4848
- uses: actions/setup-node@v3
4949
with:
50-
node-version: 24
50+
node-version: 24.16.0
5151
cache: 'npm'
5252

5353
- name: install
@@ -88,7 +88,7 @@ jobs:
8888
- uses: actions/checkout@master
8989
- uses: actions/setup-node@v3
9090
with:
91-
node-version: 24
91+
node-version: 24.16.0
9292
cache: 'npm'
9393

9494
- name: install
@@ -399,7 +399,7 @@ jobs:
399399
steps:
400400
- uses: actions/setup-node@v3
401401
with:
402-
node-version: 24
402+
node-version: 24.16.0
403403
- run: mkdir -p scene
404404
- name: npx @dcl/sdk-commands init --skip-install
405405
run: npx ${{ secrets.SDK_TEAM_S3_BASE_URL }}/${{ needs.build.outputs.decentraland_sdk_commands_s3_bucket_key }} init --skip-install
@@ -450,7 +450,7 @@ jobs:
450450

451451
- uses: actions/setup-node@v3
452452
with:
453-
node-version: 24
453+
node-version: 24.16.0
454454

455455
- name: Download prepared packages
456456
uses: actions/download-artifact@v4

.github/workflows/update-unity-renderer.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ jobs:
1010
- name: Use Node.js
1111
uses: actions/setup-node@v2
1212
with:
13-
node-version: 24
13+
node-version: 24.16.0
1414
- uses: actions/checkout@v2
1515
- name: Update explorer
1616
run: npm i --save-exact @dcl/explorer@latest

.node-version

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
20
1+
24.16.0

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
"typedoc": "^0.23.28"
3131
},
3232
"engines": {
33-
"node": "20"
33+
"node": "24.16.0"
3434
},
3535
"homepage": "https://github.com/decentraland/js-sdk-toolchain#readme",
3636
"keywords": [],

0 commit comments

Comments
 (0)