Skip to content

Commit 26cb925

Browse files
popuzpopuz
authored
feat: expose openExplorerUi in ~system/RestrictedActions (#1503)
## What Bumps `@dcl/protocol` to the **main** build `1.0.0-30373157983.commit-2c475cb` ([decentraland/protocol#451](decentraland/protocol#451), merged) so `~system/RestrictedActions` regenerates with: - `openExplorerUi(body: OpenExplorerUiRequest): Promise<OpenExplorerUiResponse>` - `ExplorerUi` enum (7 sections: `EU_MAP`, `EU_SETTINGS`, `EU_BACKPACK`, `EU_CAMERA_REEL`, `EU_COMMUNITIES`, `EU_PLACES`, `EU_EVENTS`) - `OpenExplorerUiResult` enum + `OpenExplorerUiResponse` Main-based counterpart of #1485 (experimental, pinned a protocol branch build): once this lands and main syncs into experimental, #1485 will be closed. ## Why Lets SDK7 scenes open native Explorer fullscreen panels from a user gesture and receive a typed verdict. Client implementation: [decentraland/unity-explorer#9472](decentraland/unity-explorer#9472). Test world: `flutterecho.dcl.eth` + `sdk7-test-scenes` parcel `80,-5`.
1 parent 9c1b99d commit 26cb925

19 files changed

Lines changed: 136 additions & 78 deletions

‎package-lock.json‎

Lines changed: 7 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
"bugs": "https://github.com/decentraland/js-sdk-toolchain/issues",
77
"dependencies": {
88
"@actions/core": "^1.10.0",
9-
"@dcl/protocol": "1.0.0-29286492043.commit-0010e70",
9+
"@dcl/protocol": "1.0.0-30373157983.commit-2c475cb",
1010
"@dcl/quickjs-emscripten": "^0.21.0-3680274614.commit-1808aa1",
1111
"@dcl/ts-proto": "1.153.0",
1212
"@types/fs-extra": "^9.0.12",

‎packages/@dcl/playground-assets/etc/playground-assets.api.md‎

Lines changed: 54 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -732,6 +732,7 @@ export const componentDefinitionByName: {
732732
"core::RealmInfo": LwwComponentGetter<LastWriteWinElementSetComponentDefinition<PBRealmInfo>>;
733733
"core::SkyboxTime": LwwComponentGetter<LastWriteWinElementSetComponentDefinition<PBSkyboxTime>>;
734734
"core::TextShape": LwwComponentGetter<LastWriteWinElementSetComponentDefinition<PBTextShape>>;
735+
"core::TouchScreenControls": LwwComponentGetter<LastWriteWinElementSetComponentDefinition<PBTouchScreenControls>>;
735736
"core::TriggerArea": LwwComponentGetter<LastWriteWinElementSetComponentDefinition<PBTriggerArea>>;
736737
"core::TriggerAreaResult": GSetComponentGetter<GrowOnlyValueSetComponentDefinition<PBTriggerAreaResult>>;
737738
"core::Tween": LwwComponentGetter<LastWriteWinElementSetComponentDefinition<PBTween>>;
@@ -742,6 +743,7 @@ export const componentDefinitionByName: {
742743
"core::UiDropdown": LwwComponentGetter<LastWriteWinElementSetComponentDefinition<PBUiDropdown>>;
743744
"core::UiDropdownResult": LwwComponentGetter<LastWriteWinElementSetComponentDefinition<PBUiDropdownResult>>;
744745
"core::UiInput": LwwComponentGetter<LastWriteWinElementSetComponentDefinition<PBUiInput>>;
746+
"core::UiInputBinding": LwwComponentGetter<LastWriteWinElementSetComponentDefinition<PBUiInputBinding>>;
745747
"core::UiInputResult": LwwComponentGetter<LastWriteWinElementSetComponentDefinition<PBUiInputResult>>;
746748
"core::UiText": LwwComponentGetter<LastWriteWinElementSetComponentDefinition<PBUiText>>;
747749
"core::UiTransform": LwwComponentGetter<LastWriteWinElementSetComponentDefinition<PBUiTransform>>;
@@ -3604,6 +3606,38 @@ export namespace PBTextShape {
36043606
export function encode(message: PBTextShape, writer?: _m0.Writer): _m0.Writer;
36053607
}
36063608

3609+
// @public (undocumented)
3610+
export interface PBTouchScreenControls {
3611+
hideCrosshair: boolean;
3612+
hideJoystick: boolean;
3613+
mainAction?: InputAction | undefined;
3614+
// (undocumented)
3615+
touchInputs: PBTouchScreenControls_TouchInput[];
3616+
}
3617+
3618+
// @public (undocumented)
3619+
export namespace PBTouchScreenControls {
3620+
// (undocumented)
3621+
export function decode(input: _m0.Reader | Uint8Array, length?: number): PBTouchScreenControls;
3622+
// (undocumented)
3623+
export function encode(message: PBTouchScreenControls, writer?: _m0.Writer): _m0.Writer;
3624+
}
3625+
3626+
// @public (undocumented)
3627+
export interface PBTouchScreenControls_TouchInput {
3628+
hide: boolean;
3629+
icon?: TextureUnion | undefined;
3630+
inputAction: InputAction;
3631+
}
3632+
3633+
// @public (undocumented)
3634+
export namespace PBTouchScreenControls_TouchInput {
3635+
// (undocumented)
3636+
export function decode(input: _m0.Reader | Uint8Array, length?: number): PBTouchScreenControls_TouchInput;
3637+
// (undocumented)
3638+
export function encode(message: PBTouchScreenControls_TouchInput, writer?: _m0.Writer): _m0.Writer;
3639+
}
3640+
36073641
// @public (undocumented)
36083642
export interface PBTriggerArea {
36093643
collisionMask?: number | undefined;
@@ -3826,6 +3860,19 @@ export namespace PBUiInput {
38263860
export function encode(message: PBUiInput, writer?: _m0.Writer): _m0.Writer;
38273861
}
38283862

3863+
// @public (undocumented)
3864+
export interface PBUiInputBinding {
3865+
actions: InputAction[];
3866+
}
3867+
3868+
// @public (undocumented)
3869+
export namespace PBUiInputBinding {
3870+
// (undocumented)
3871+
export function decode(input: _m0.Reader | Uint8Array, length?: number): PBUiInputBinding;
3872+
// (undocumented)
3873+
export function encode(message: PBUiInputBinding, writer?: _m0.Writer): _m0.Writer;
3874+
}
3875+
38293876
// @public (undocumented)
38303877
export interface PBUiInputResult {
38313878
isSubmit?: boolean | undefined;
@@ -4057,6 +4104,7 @@ export namespace PBVideoPlayer {
40574104
export interface PBVirtualCamera {
40584105
// (undocumented)
40594106
defaultTransition?: CameraTransition | undefined;
4107+
fov?: number | undefined;
40604108
// (undocumented)
40614109
lookAtEntity?: number | undefined;
40624110
}
@@ -5055,6 +5103,9 @@ export const ToLinearSpace = 2.2;
50555103
// @public (undocumented)
50565104
export type ToOptional<T> = OnlyOptionalUndefinedTypes<T> & OnlyNonUndefinedTypes<T>;
50575105

5106+
// @public (undocumented)
5107+
export const TouchScreenControls: LastWriteWinElementSetComponentDefinition<PBTouchScreenControls>;
5108+
50585109
// Warning: (ae-missing-release-tag) "Transform" is part of the package's API, but it is missing a release tag (@alpha, @beta, @public, or @internal)
50595110
//
50605111
// @public (undocumented)
@@ -5300,6 +5351,9 @@ export type UiFontType = 'sans-serif' | 'serif' | 'monospace';
53005351
// @public (undocumented)
53015352
export const UiInput: LastWriteWinElementSetComponentDefinition<PBUiInput>;
53025353

5354+
// @public (undocumented)
5355+
export const UiInputBinding: LastWriteWinElementSetComponentDefinition<PBUiInputBinding>;
5356+
53035357
// @public (undocumented)
53045358
export interface UiInputProps extends Omit<PBUiInput, 'font' | 'textAlign' | 'fontSize'> {
53055359
// (undocumented)

‎packages/@dcl/sdk-commands/package-lock.json‎

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎packages/@dcl/sdk-commands/package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
"@dcl/inspector": "7.36.3",
1515
"@dcl/linker-dapp": "0.15.2",
1616
"@dcl/mini-comms": "1.0.1-20230216163137.commit-a4c75be",
17-
"@dcl/protocol": "1.0.0-29286492043.commit-0010e70",
17+
"@dcl/protocol": "1.0.0-30373157983.commit-2c475cb",
1818
"@dcl/quests-client": "^1.0.3",
1919
"@dcl/quests-manager": "^0.1.4",
2020
"@dcl/rpc": "^1.1.1",

‎test/ecs/components/VirtualCamera.spec.ts‎

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,8 @@ describe('VirtualCamera component', () => {
1111
time: 3
1212
}
1313
},
14-
lookAtEntity: 35
14+
lookAtEntity: 35,
15+
fov: 45
1516
})
1617
})
1718

@@ -22,7 +23,8 @@ describe('VirtualCamera component', () => {
2223
defaultTransition: {
2324
transitionMode: vCamera.Transition.Time(6)
2425
},
25-
lookAtEntity: 86
26+
lookAtEntity: 86,
27+
fov: 50
2628
})
2729
})
2830

@@ -35,7 +37,8 @@ describe('VirtualCamera component', () => {
3537
speed: 13
3638
}
3739
},
38-
lookAtEntity: 86
40+
lookAtEntity: 86,
41+
fov: 30
3942
})
4043
})
4144

@@ -46,7 +49,8 @@ describe('VirtualCamera component', () => {
4649
defaultTransition: {
4750
transitionMode: vCamera.Transition.Speed(15)
4851
},
49-
lookAtEntity: 86
52+
lookAtEntity: 86,
53+
fov: 48
5054
})
5155
})
5256
})

‎test/snapshots/development-bundles/static-scene.test.ts.crdt‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
SCENE_COMPILED_JS_SIZE_PROD=567.9k bytes
1+
SCENE_COMPILED_JS_SIZE_PROD=575.3k bytes
22
THE BUNDLE HAS SOURCEMAPS
33
(start empty vm 0.21.0-3680274614.commit-1808aa1)
44
OPCODES ~= 0k
@@ -11,9 +11,9 @@ EVAL test/snapshots/development-bundles/static-scene.test.js
1111
REQUIRE: ~system/EngineApi
1212
REQUIRE: ~system/EngineApi
1313
REQUIRE: ~system/Runtime
14-
OPCODES ~= 73k
15-
MALLOC_COUNT = 16329
16-
ALIVE_OBJS_DELTA ~= 3.25k
14+
OPCODES ~= 74k
15+
MALLOC_COUNT = 16530
16+
ALIVE_OBJS_DELTA ~= 3.29k
1717
CALL onStart()
1818
main.crdt: PUT_COMPONENT e=0x200 c=1 t=0 data={"position":{"x":5.880000114440918,"y":2.7916901111602783,"z":7.380000114440918},"rotation":{"x":0,"y":0,"z":0,"w":1},"scale":{"x":1,"y":1,"z":1},"parent":0}
1919
main.crdt: PUT_COMPONENT e=0x202 c=1 t=0 data={"position":{"x":4,"y":0.800000011920929,"z":8},"rotation":{"x":0,"y":0,"z":0,"w":1},"scale":{"x":1,"y":1,"z":1},"parent":0}
@@ -57,4 +57,4 @@ CALL onUpdate(0.1)
5757
OPCODES ~= 5k
5858
MALLOC_COUNT = -5
5959
ALIVE_OBJS_DELTA ~= 0.00k
60-
MEMORY_USAGE_COUNT ~= 1432.77k bytes
60+
MEMORY_USAGE_COUNT ~= 1446.63k bytes

‎test/snapshots/development-bundles/testing-fw.test.ts.crdt‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
SCENE_COMPILED_JS_SIZE_PROD=568.4k bytes
1+
SCENE_COMPILED_JS_SIZE_PROD=575.8k bytes
22
THE BUNDLE HAS SOURCEMAPS
33
(start empty vm 0.21.0-3680274614.commit-1808aa1)
44
OPCODES ~= 0k
@@ -11,9 +11,9 @@ EVAL test/snapshots/development-bundles/testing-fw.test.js
1111
REQUIRE: ~system/EngineApi
1212
REQUIRE: ~system/EngineApi
1313
REQUIRE: ~system/Runtime
14-
OPCODES ~= 83k
15-
MALLOC_COUNT = 16881
16-
ALIVE_OBJS_DELTA ~= 3.40k
14+
OPCODES ~= 84k
15+
MALLOC_COUNT = 17082
16+
ALIVE_OBJS_DELTA ~= 3.45k
1717
CALL onStart()
1818
LOG: ["Adding one to position.y=0"]
1919
Renderer: PUT_COMPONENT e=0x0 c=1 t=1 data={"position":{"x":1,"y":0,"z":0},"rotation":{"x":0,"y":0,"z":0,"w":1},"scale":{"x":9,"y":9,"z":9},"parent":0}
@@ -63,4 +63,4 @@ CALL onUpdate(0.1)
6363
OPCODES ~= 6k
6464
MALLOC_COUNT = -53
6565
ALIVE_OBJS_DELTA ~= -0.01k
66-
MEMORY_USAGE_COUNT ~= 1438.53k bytes
66+
MEMORY_USAGE_COUNT ~= 1452.39k bytes

‎test/snapshots/development-bundles/two-way-crdt.test.ts.crdt‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
SCENE_COMPILED_JS_SIZE_PROD=568.4k bytes
1+
SCENE_COMPILED_JS_SIZE_PROD=575.9k bytes
22
THE BUNDLE HAS SOURCEMAPS
33
(start empty vm 0.21.0-3680274614.commit-1808aa1)
44
OPCODES ~= 0k
@@ -11,9 +11,9 @@ EVAL test/snapshots/development-bundles/two-way-crdt.test.js
1111
REQUIRE: ~system/EngineApi
1212
REQUIRE: ~system/EngineApi
1313
REQUIRE: ~system/Runtime
14-
OPCODES ~= 83k
15-
MALLOC_COUNT = 16881
16-
ALIVE_OBJS_DELTA ~= 3.40k
14+
OPCODES ~= 84k
15+
MALLOC_COUNT = 17082
16+
ALIVE_OBJS_DELTA ~= 3.45k
1717
CALL onStart()
1818
LOG: ["Adding one to position.y=0"]
1919
Renderer: PUT_COMPONENT e=0x0 c=1 t=1 data={"position":{"x":1,"y":0,"z":0},"rotation":{"x":0,"y":0,"z":0,"w":1},"scale":{"x":9,"y":9,"z":9},"parent":0}
@@ -63,4 +63,4 @@ CALL onUpdate(0.1)
6363
OPCODES ~= 6k
6464
MALLOC_COUNT = -53
6565
ALIVE_OBJS_DELTA ~= -0.01k
66-
MEMORY_USAGE_COUNT ~= 1438.54k bytes
66+
MEMORY_USAGE_COUNT ~= 1452.40k bytes

‎test/snapshots/package-lock.json‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)