tmp

Author: nicoecheza

.github/workflows/ci.yml

@@ -569,6 +569,7 @@ jobs:
 
   pr-preview:
     name: Creator Hub Build
+    needs: [build]
     strategy:
       fail-fast: true
       matrix:
@@ -588,6 +589,12 @@ jobs:
           node-version: 22
           cache: 'npm'
 
+      - name: Install @dcl/inspector@branch package
+        run: npm install "${{ secrets.SDK_TEAM_S3_BASE_URL }}/${{ needs.build.outputs.decentraland_inspector_s3_bucket_key }}"
+        working-directory: ${{ env.WORKING_DIRECTORY }}
+        env:
+          PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1
+
       - name: 'Install dependencies'
         run: npm ci
         working-directory: ${{ env.WORKING_DIRECTORY }}
@@ -607,6 +614,13 @@ jobs:
           SENTRY_AUTH_TOKEN: ${{ secrets.SENTRY_AUTH_TOKEN }}
           VITE_SENTRY_DSN: ${{ secrets.SENTRY_DSN }}
 
+      - name: copy creator-hub package.json to root to run semantic-version
+        if: ${{ github.event.pull_request.number }}
+        run: |
+          ls -l
+          mv package.json package.json.bak
+          cp ${{ env.WORKING_DIRECTORY }}/package.json package.json
+
       - name: Generate release version
         id: version
         uses: paulhatch/semantic-version@v5.4.0
@@ -621,6 +635,12 @@ jobs:
           user_format_type: "json"
           change_path: ${{ env.WORKING_DIRECTORY }}
 
+      - name: move versioned package.json to creator-hub package
+        if: ${{ github.event.pull_request.number }}
+        run: |
+          mv package.json ${{ env.WORKING_DIRECTORY }}
+          mv package.json.bak package.json
+
       # Download 'SSLcom/esigner-codesign' to a folder called 'esigner-codesign' inside creator-hub package
       - name: Checkout esigner-codesign repository (Windows)
         if: ${{github.ref == 'refs/heads/main' && matrix.os == 'windows-latest' && !github.event.pull_request.number}}
@@ -629,6 +649,10 @@ jobs:
           repository: 'SSLcom/esigner-codesign'
           path: ${{ env.WORKING_DIRECTORY }}/esigner-codesign
 
+      - name: check version in package.json
+        if: ${{ github.event.pull_request.number }}
+        run: cat package.json
+
       - name: Compile artifacts ${{ github.event.pull_request.number && ' ' || 'and upload them to github release' }}
         # I use this action because it is capable of retrying multiple times if there are any issues with the distribution server
         uses: nick-fields/retry@v3

.github/workflows/creator-hub.yml

@@ -112,124 +112,3 @@ jobs:
         env:
           NODE_OPTIONS: "--max-old-space-size=8192"
           ENABLE_E2E_TESTS: true
-
-  # ============================================================================
-  # Release Jobs (Only run on main branch)
-  # ============================================================================
-
-  drop-pre-release:
-    name: Drop Pre-releases
-    runs-on: ubuntu-latest
-    needs: [ typechecking, tests ]
-    if: github.ref == 'refs/heads/main'
-    permissions:
-      contents: write
-    steps:
-      - uses: actions/checkout@v4
-      - uses: actions/setup-node@v4
-        with:
-          cache: 'npm'
-
-      - name: Drop pre releases
-        uses: sgpublic/delete-release-action@v1.2
-        with:
-          pre-release-drop: true
-          pre-release-keep-count: -1
-          pre-release-drop-tag: true
-        env:
-          GITHUB_TOKEN: ${{ secrets.github_token }}
-
-  build-and-release:
-    name: Build and Release
-    strategy:
-      fail-fast: true
-      matrix:
-        os: [ macos-latest, windows-latest ]
-    runs-on: ${{ matrix.os }}
-    needs: [ drop-pre-release ]
-    if: github.ref == 'refs/heads/main'
-    permissions:
-      contents: write
-      issues: write
-      pull-requests: write
-    steps:
-      - uses: actions/checkout@v4
-        with:
-          fetch-depth: 0
-          fetch-tags: true
-
-      - uses: actions/setup-node@v4
-        with:
-          node-version: 22
-          cache: 'npm'
-          cache-dependency-path: ${{ env.WORKING_DIRECTORY }}/package-lock.json
-
-      - name: Install dependencies
-        run: npm ci
-        working-directory: ${{ env.WORKING_DIRECTORY }}
-        env:
-          PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1
-
-      - name: Build application
-        run: echo MODE=production && npm run build
-        working-directory: ${{ env.WORKING_DIRECTORY }}
-        env:
-          NODE_OPTIONS: "--max-old-space-size=8192"
-          MODE: production
-          VITE_SEGMENT_CREATORS_HUB_API_KEY: ${{ secrets.VITE_SEGMENT_CREATORS_HUB_API_KEY }}
-          VITE_SEGMENT_INSPECTOR_API_KEY: ${{ secrets.VITE_SEGMENT_INSPECTOR_API_KEY }}
-          VITE_ALLOWED_EXTERNAL_ORIGINS: ${{ secrets.VITE_ALLOWED_EXTERNAL_ORIGINS }}
-          SENTRY_AUTH_TOKEN: ${{ secrets.SENTRY_AUTH_TOKEN }}
-          VITE_SENTRY_DSN: ${{ secrets.SENTRY_DSN }}
-
-      - name: Generate release version
-        id: version
-        uses: paulhatch/semantic-version@v5.4.0
-        with:
-          tag_prefix: ""
-          version_format: ${major}.${minor}.${patch}
-          major_pattern: "/^(major|breaking).+/"
-          minor_pattern: "/^(minor|feat).+/"
-          bump_each_commit: false
-          bump_each_commit_patch_pattern: "/^(patch|fix).+/"
-          search_commit_body: true
-          user_format_type: "json"
-
-      - name: Checkout esigner-codesign repository (Windows)
-        if: matrix.os == 'windows-latest'
-        uses: actions/checkout@v3
-        with:
-          repository: 'SSLcom/esigner-codesign'
-          path: esigner-codesign
-
-      - name: Build and publish artifacts
-        uses: nick-fields/retry@v3
-        with:
-          timeout_minutes: 60
-          max_attempts: 6
-          retry_wait_seconds: 15
-          retry_on: error
-          shell: 'bash'
-          command: npx electron-builder --config electron-builder.cjs --config.extraMetadata.version=${{ steps.version.outputs.version }} ${{ matrix.os == 'macos-latest' && '--config.mac.notarize=true' || '' }} --publish always
-          working-directory: ${{ env.WORKING_DIRECTORY }}
-        env:
-          USE_HARD_LINKS: false
-          CSC_LINK: ${{ secrets.MACOS_CSC_LINK }}
-          CSC_KEY_PASSWORD: ${{ secrets.MACOS_CSC_KEY_PASSWORD }}
-          APPLE_ID: ${{ secrets.MACOS_NOTARIZATION_APPLE_ID }}
-          APPLE_TEAM_ID: ${{ secrets.MACOS_NOTARIZATION_TEAM_ID }}
-          APPLE_APP_SPECIFIC_PASSWORD: ${{ secrets.MACOS_NOTARIZATION_PWD }}
-          GH_TOKEN: ${{ secrets.github_token }}
-          EP_PRE_RELEASE: true
-          CODE_SIGN_SCRIPT_PATH: ${{ matrix.os == 'windows-latest' && format('{0}\\esigner-codesign\\dist\\index.js', github.workspace) || '' }}
-          INPUT_COMMAND: "sign"
-          INPUT_FILE_PATH: "${{ github.workspace }}\\${{ env.WORKING_DIRECTORY }}\\dist\\Decentraland Creator Hub-${{ steps.version.outputs.version }}-win-x64.exe"
-          INPUT_OVERRIDE: "true"
-          INPUT_MALWARE_BLOCK: "false"
-          INPUT_CLEAN_LOGS: "false"
-          INPUT_JVM_MAX_MEMORY: "1024M"
-          INPUT_ENVIRONMENT_NAME: "PROD"
-          INPUT_USERNAME: ${{ secrets.ES_USERNAME }}
-          INPUT_PASSWORD: ${{ secrets.ES_PASSWORD }}
-          INPUT_TOTP_SECRET: ${{ secrets.ES_TOTP_SECRET }}
-          INPUT_CREDENTIAL_ID: ${{ secrets.WINDOWS_CREDENTIAL_ID_SIGNER }}