feat: remove visibility component when there's no mesh or GLTF

Author: alejandralevy

packages/@dcl/inspector/src/components/EntityInspector/GltfInspector/GltfInspector.tsx

@@ -30,9 +30,18 @@ export default withSdk<Props>(({ sdk, entity }) => {
   )
 
   const handleRemove = useCallback(async () => {
+    const { VisibilityComponent, MeshCollider } = sdk.components
+    const hasMeshCollider = MeshCollider.has(entity)
+    const hasVisibility = VisibilityComponent.has(entity)
+
     sdk.operations.removeComponent(entity, GltfContainer)
+
+    if (hasVisibility && !hasMeshCollider) {
+      sdk.operations.removeComponent(entity, VisibilityComponent)
+    }
+
     await sdk.operations.dispatch()
-  }, [])
+  }, [sdk, entity])
 
   const handleDrop = useCallback(async (src: string) => {
     const { operations } = sdk

packages/@dcl/inspector/src/components/EntityInspector/MeshColliderInspector/MeshColliderInspector.tsx

@@ -19,9 +19,20 @@ export default withSdk<Props>(({ sdk, entity }) => {
   const { getInputProps } = useComponentInput(entity, MeshCollider, fromMeshCollider, toMeshCollider, isValidInput)
 
   const handleRemove = useCallback(async () => {
+    const { VisibilityComponent, GltfContainer } = sdk.components
+    const hasGltfContainer = GltfContainer.has(entity)
+    const hasVisibility = VisibilityComponent.has(entity)
+
+    // Borrar MeshCollider
     sdk.operations.removeComponent(entity, MeshCollider)
+
+    // Si se borra mesh: fijarse si hay GLTF, si NO hay borrar visibility
+    if (hasVisibility && !hasGltfContainer) {
+      sdk.operations.removeComponent(entity, VisibilityComponent)
+    }
+
     await sdk.operations.dispatch()
-  }, [])
+  }, [sdk, entity])
 
   if (!hasMeshCollider) return null
 

packages/@dcl/inspector/src/components/EntityInspector/VisibilityComponentInspector/VisibilityComponentInspector.tsx

@@ -100,7 +100,7 @@ export default withSdk<Props>(({ sdk, entity }) => {
     )
   }, [])
 
-  if (!hasVisibilityComponent || (!hasGltfContainer && !hasMeshCollider)) return null
+  if (!hasVisibilityComponent) return null
 
   return (
     <Container label="Visibility" className={cx('VisibilityContainer')} onRemoveContainer={handleRemove}>