fix(sdk-commands): stop bundling a second copy of @dcl/ecs into every scene (#1450)

* fix(sdk-commands): stop bundling a second copy of @dcl/ecs into every scene

The runtime script embedded into scenes as ~sdk/script-utils imported
@dcl/ecs/dist-cjs. EntityState is a runtime enum, so the import survives into
the bundle and drags the whole CommonJS build of ecs (~319 KB minified) in
next to the ESM build the rest of the scene already uses. Importing @dcl/ecs
resolves both to the same ESM copy.

A standard production scene drops from 650 KB to 355 KB (-45%); a scene on
the published SDK 7.24.4 drops from 668 KB to 361 KB. The CLI still uses
dist-cjs where it runs under Node - that was the convention this file
followed (#584), correct there but costly inside bundles (#1245).

The size-tracked bundle snapshots could not catch this because they build
with --customEntryPoint, which skips script-utils; with-main-function is the
one snapshot that exercises the real path, and its expectation is regenerated
here.

* fix(sdk-commands): keep @dcl/ecs tree-shakeable in scene bundles

Requiring the @dcl/ecs barrel from the embedded runtime script makes
esbuild materialize its full CommonJS namespace, keeping every core
component initializer alive: the engine registers 65 component
definitions instead of the 20 the scene uses, and the per-frame CRDT
dirty sweep doubles. Import the types as type-only and the one runtime
value, EntityState, from the dist-cjs leaf (engine/entity.js plus its
single dependency, ~2 KB minified), so the barrel stays import-only and
shakeable and the compiled file stays requirable under Node.

with-main-function vs the previous commit: production bundle 318.6k to
292.2k, eval opcodes 145k to 102k, onUpdate back to the pre-change 5k,
VM memory 1606k to 1301k.

Author: eordano

packages/@dcl/sdk-commands/src/logic/runtime-script.ts

@@ -1,5 +1,6 @@
 /* eslint-disable no-console */
-import { IEngine, Entity, EntityState } from '@dcl/ecs/dist-cjs'
+import type { IEngine, Entity } from '@dcl/ecs'
+import { EntityState } from '@dcl/ecs/dist-cjs/engine/entity'
 import { type ActionRef, getActionEvents } from '@dcl/inspector/node_modules/@dcl/asset-packs'
 
 declare global {

test/sdk-commands/logic/runtime-script.spec.ts

@@ -9,7 +9,7 @@ jest.mock(
 )
 
 import { runScripts } from '../../../packages/@dcl/sdk-commands/src/logic/runtime-script'
-import { IEngine, Entity, EntityState } from '../../../packages/@dcl/ecs/dist-cjs'
+import { IEngine, Entity, EntityState } from '../../../packages/@dcl/ecs/dist'
 
 describe('runtime-script', () => {
   let mockEngine: IEngine

test/snapshots/production-bundles/with-main-function.ts.crdt

@@ -1,4 +1,4 @@
-SCENE_COMPILED_JS_SIZE_PROD=608.6k bytes
+SCENE_COMPILED_JS_SIZE_PROD=292.2k bytes
 (start empty vm 0.21.0-3680274614.commit-1808aa1)
   OPCODES ~= 0k
   MALLOC_COUNT = 1005
@@ -9,9 +9,9 @@ EVAL test/snapshots/production-bundles/with-main-function.js
   REQUIRE: ~system/EngineApi
   REQUIRE: ~system/EngineApi
   REQUIRE: ~system/Runtime
-  OPCODES ~= 222k
-  MALLOC_COUNT = 43890
-  ALIVE_OBJS_DELTA ~= 9.89k
+  OPCODES ~= 102k
+  MALLOC_COUNT = 21120
+  ALIVE_OBJS_DELTA ~= 4.95k
 CALL onStart()
   OPCODES ~= 0k
   MALLOC_COUNT = 6
@@ -38,4 +38,4 @@ CALL onUpdate(0.1)
   OPCODES ~= 5k
   MALLOC_COUNT = 13
   ALIVE_OBJS_DELTA ~= 0.00k
-  MEMORY_USAGE_COUNT ~= 2968.93k bytes
+  MEMORY_USAGE_COUNT ~= 1300.70k bytes