Merge pull request #1538 from decentraland/chore/sync-main-to-authserver

chore: sync main to authserver

Author: pravusjif

.eslintignore

@@ -14,7 +14,7 @@ For deeper context on a specific subsystem (component serialization, CRDT suppre
 
 ## Packages
 
-Six packages under `packages/@dcl/` (npm workspaces):
+Six packages under `packages/@dcl/` (a monorepo layout, but **not** npm workspaces):
 
 | Package | Purpose |
 | --- | --- |
@@ -27,6 +27,8 @@ Six packages under `packages/@dcl/` (npm workspaces):
 
 Internal references use `file:../` paths during development; published versions get pinned semver ranges (managed via syncpack — see `make sync-deps`).
 
+The root `package.json` has no `workspaces` field — root `make install` only installs root-level tooling deps. Each package keeps its own standalone `package-lock.json`, and per-package `node_modules/` are populated by `make build`, which runs `npm i` inside each package (`scripts/build.spec.ts`). Don't expect package deps to be hoisted to the root `node_modules/`.
+
 ## Development commands
 
 The repo is orchestrated via **`make`** (the Makefile is the source of truth — `package.json` only carries `postinstall`). All commands run from the repo root:
@@ -47,10 +49,10 @@ The repo is orchestrated via **`make`** (the Makefile is the source of truth —
 The full Jest suite is slow. For faster iteration, scope to a path pattern:
 
 ```bash
-node_modules/.bin/jest --colors --forceExit --testPathPattern='test/sdk-commands'
-node_modules/.bin/jest --colors --forceExit --testPathPattern='test/ecs'
-node_modules/.bin/jest --colors --forceExit --testPathPattern='test/react-ecs'
-node_modules/.bin/jest --colors --forceExit --testPathPattern='test/snapshots'
+node_modules/.bin/jest --colors --forceExit --testPathPatterns='test/sdk-commands'
+node_modules/.bin/jest --colors --forceExit --testPathPatterns='test/ecs'
+node_modules/.bin/jest --colors --forceExit --testPathPatterns='test/react-ecs'
+node_modules/.bin/jest --colors --forceExit --testPathPatterns='test/snapshots'
 ```
 
 ### Per-package typecheck
@@ -73,6 +75,21 @@ An `ERR!` line means the QuickJS eval threw mid-execution (commonly a missing mo
 
 **Anti-pattern:** committing snapshots containing `ERR! Error: Unknown module ...`, `ERR! TypeError: ... is not a function`, or any other `ERR!` trace. Treat them as broken artifacts — fix the mock (or the underlying scene-load failure), regenerate, and re-verify before committing.
 
+### Bumping `@dcl/inspector` (the vehicle for `@dcl/asset-packs`)
+
+`@dcl/asset-packs` is not a direct dependency of this repo — it ships nested inside `@dcl/inspector`, and `packages/@dcl/sdk-commands/src/logic/bundle.ts` resolves it from the inspector's `node_modules`. To bump (prior art: commits `04270ca5`, `8b6bd63d`):
+
+1. `cd packages/@dcl/sdk-commands && npm i --save-exact @dcl/inspector@<x.y.z>` — updates the pin, the package's standalone lockfile, and its `node_modules/` in one step (same pattern as the Makefile's `update-protocol` target).
+2. `make build` from the repo root.
+3. Regenerate snapshots with a `UPDATE_SNAPSHOTS=true` scoped Jest run — `test/snapshots/package-lock.json` updates itself during this run. Verify no `ERR!` lines (see above).
+
+Asset-packs injection is gated behind `isEditorScene` (requires `assets/scene/main.composite` — see `packages/@dcl/sdk-commands/src/logic/project-validations.ts`), so inspector bumps no longer change `.crdt` snapshots. An empty snapshot diff is expected, not a stale artifact.
+
+## Committing hygiene gotchas
+
+- A newer local npm rewrites committed lockfiles with `"peer": true` / `"dev": true` metadata churn during installs (root and per-package lockfiles). Revert lockfile changes unrelated to your dependency change before committing.
+- `make format` runs prettier over the whole repo, including paths CI's `make lint` does not check (`test/`, `scripts/`, dot-files), where HEAD may carry drift — a blind `make format` can dirty dozens of unrelated files. Check your own files, revert the rest.
+
 ## Code conventions
 
 - **TypeScript** 5.0.2, strict mode.

AGENTS.md

@@ -110,14 +110,14 @@ Uses esbuild with `platform: 'browser'`, `format: 'cjs'`, `target: 'es2020'`, an
 | `-p, --port <number>` | HTTP port (auto-detected if omitted) |
 | `--dclenv <env>` | Explorer environment: `org` (mainnet production, default), `zone` (staging), `today` |
 | `--realm <name>` | Realm name shown in Explorer (default: `Localhost`) |
-| `--web3` | Enable Web3 wallet integration in the preview |
+| `--web3` | (deprecated) No effect; kept for backwards compatibility |
 | `--skip-build` | Serve pre-built files without rebuilding |
 | `--no-watch` | Disable file watching / hot reload |
 | `--no-browser` | Don't auto-open Explorer |
 | `--ci` | CI mode: disable browser and debug panel |
 | `--debug` | Enable scene debug panel (on by default with `--explorer-alpha`) |
 | `--explorer-alpha` | Use the new Alpha Explorer deeplink (default) |
-| `--web-explorer` | Use legacy web-based Explorer |
+| `--web, --bevy-web` | Open the preview in Bevy Web (`https://decentraland.org/bevy-web/`) instead of the desktop Explorer. Chrome 142+ requires the Local Network Access permission ("Apps on device" in 145+) for the page to reach the localhost preview server; the CLI prints instructions |
 | `--mobile` | Print ASCII QR code for mobile preview |
 | `--position <x,y>` | Initial spawn position (default: from `scene.json`) |
 | `--skip-auth-screen` | Skip Explorer's authentication screen |

docs/ai-agent-context.md

@@ -0,0 +1,61 @@
+import { FlatCompat } from '@eslint/eslintrc'
+import path from 'path'
+import { fileURLToPath } from 'url'
+
+// @dcl/eslint-config still publishes an eslintrc-style config; wrap it for eslint 9.
+const compat = new FlatCompat({ baseDirectory: path.dirname(fileURLToPath(import.meta.url)) })
+
+export default [
+  ...compat.config({
+    extends: '@dcl/eslint-config/sdk',
+    parserOptions: {
+      project: [
+        'packages/@dcl/ecs/tsconfig.json',
+        'packages/@dcl/sdk-commands/tsconfig.json',
+        'packages/@dcl/sdk/tsconfig.json',
+        'packages/@dcl/playground-assets/tsconfig.json',
+        'packages/@dcl/react-ecs/tsconfig.json',
+        'scripts/tsconfig.json',
+        'test/tsconfig.json',
+        'test/ecs/snippets/tsconfig.json'
+      ]
+    }
+  }),
+  {
+    rules: {
+      'no-param-reassign': 'warn',
+      'no-console': 'error',
+      '@typescript-eslint/no-unused-vars': [
+        'warn',
+        {
+          ignoreRestSiblings: true,
+          argsIgnorePattern: '^_',
+          varsIgnorePattern: '^_|ReactEcs',
+          caughtErrorsIgnorePattern: '^_'
+        }
+      ]
+    }
+  },
+  {
+    files: ['packages/@dcl/ecs/**/*.ts', 'packages/@dcl/sdk/**/*.ts', 'scripts/**/*.ts', 'test/**/*.ts'],
+    rules: { 'no-console': 'off' }
+  },
+  {
+    ignores: [
+      '**/*.gen.ts',
+      '**/dist/**',
+      '**/node_modules/**',
+      '**/*.d.ts',
+      '**/*.js',
+      'packages/@dcl/ecs/dist/**',
+      'packages/@dcl/ecs/src/components/generated',
+      'packages/@dcl/js-runtime',
+      'packages/@dcl/playground-assets/dist',
+      'packages/@dcl/sdk/dist/**',
+      'packages/@dcl/sdk/internal/**',
+      'packages/@dcl/sdk/testing/**',
+      'test/sdk/simple-scene',
+      'tmp'
+    ]
+  }
+]

eslint.config.mjs

@@ -3,9 +3,14 @@ module.exports = {
   moduleFileExtensions: ['ts', 'js', 'tsx', 'jsx'],
   transform: {
     '^.+\\.(js|jsx|ts|tsx)$': [
-      'ts-jest',
+      'babel-jest',
       {
-        tsconfig: 'test/tsconfig.json'
+        presets: [['@babel/preset-typescript', { isTSX: true, allExtensions: true, onlyRemoveTypeImports: true }]],
+        plugins: [
+          '@babel/plugin-transform-modules-commonjs',
+          '@babel/plugin-transform-dynamic-import',
+          ['@babel/plugin-transform-react-jsx', { pragma: 'ReactEcs.createElement' }]
+        ]
       }
     ]
   },