Merge pull request #1161 from decentraland/feat/improve-light-proto

feat: improved light proto

Author: daniele-dcl

package-lock.json

@@ -6,7 +6,7 @@
   "bugs": "https://github.com/decentraland/js-sdk-toolchain/issues",
   "dependencies": {
     "@actions/core": "^1.10.0",
-    "@dcl/protocol": "1.0.0-16429465125.commit-bac58dd",
+    "@dcl/protocol": "1.0.0-16564528964.commit-5630df7",
     "@dcl/quickjs-emscripten": "^0.21.0-3680274614.commit-1808aa1",
     "@dcl/ts-proto": "1.153.0",
     "@types/fs-extra": "^9.0.12",

package.json

@@ -2477,9 +2477,11 @@ export namespace PBInputModifier_StandardInput {
 // @public (undocumented)
 export interface PBLightSource {
     active?: boolean | undefined;
-    brightness?: number | undefined;
     color?: PBColor3 | undefined;
+    intensity?: number | undefined;
     range?: number | undefined;
+    shadow?: boolean | undefined;
+    shadowMaskTexture?: TextureUnion | undefined;
     // (undocumented)
     type?: {
         $case: "point";
@@ -2500,30 +2502,20 @@ export namespace PBLightSource {
 
 // @public (undocumented)
 export interface PBLightSource_Point {
-    shadow?: PBLightSource_ShadowType | undefined;
 }
 
 // @public (undocumented)
 export namespace PBLightSource_Point {
     // (undocumented)
     export function decode(input: _m0.Reader | Uint8Array, length?: number): PBLightSource_Point;
     // (undocumented)
-    export function encode(message: PBLightSource_Point, writer?: _m0.Writer): _m0.Writer;
-}
-
-// @public (undocumented)
-export const enum PBLightSource_ShadowType {
-    ST_HARD = 2,
-    ST_NONE = 0,
-    ST_SOFT = 1
+    export function encode(_: PBLightSource_Point, writer?: _m0.Writer): _m0.Writer;
 }
 
 // @public (undocumented)
 export interface PBLightSource_Spot {
     innerAngle?: number | undefined;
     outerAngle?: number | undefined;
-    shadow?: PBLightSource_ShadowType | undefined;
-    shadowMaskTexture?: TextureUnion | undefined;
 }
 
 // @public (undocumented)

packages/@dcl/playground-assets/etc/playground-assets.api.md

@@ -13,7 +13,7 @@
     "@dcl/inspector": "file:../inspector",
     "@dcl/linker-dapp": "^0.14.2",
     "@dcl/mini-comms": "1.0.1-20230216163137.commit-a4c75be",
-    "@dcl/protocol": "1.0.0-16429465125.commit-bac58dd",
+    "@dcl/protocol": "1.0.0-16564528964.commit-5630df7",
     "@dcl/quests-client": "^1.0.3",
     "@dcl/quests-manager": "^0.1.4",
     "@dcl/rpc": "^1.1.1",

packages/@dcl/sdk-commands/package-lock.json

@@ -7,13 +7,13 @@ describe('Generated LightSource ProtoBuf', () => {
     const LightSource = components.LightSource(newEngine)
 
     testComponentSerialization(LightSource, {
-      type: LightSource.Type.Point({
-        shadow: components.PBLightSource_ShadowType.ST_NONE
-      }),
       active: true,
       color: { r: 1, g: 1, b: 1 },
-      brightness: 1,
-      range: 10
+      intensity: 1,
+      range: 10,
+      shadowMaskTexture: undefined,
+      shadow: true,
+      type: LightSource.Type.Point({})
     })
   })
 
@@ -22,16 +22,16 @@ describe('Generated LightSource ProtoBuf', () => {
     const LightSource = components.LightSource(newEngine)
 
     testComponentSerialization(LightSource, {
-      type: LightSource.Type.Spot({
-        innerAngle: 0,
-        outerAngle: 0,
-        shadowMaskTexture: undefined,
-        shadow: components.PBLightSource_ShadowType.ST_NONE
-      }),
       active: true,
       color: { r: 1, g: 1, b: 1 },
-      brightness: 1,
-      range: 10
+      intensity: 1,
+      range: 10,
+      shadowMaskTexture: undefined,
+      shadow: true,
+      type: LightSource.Type.Spot({
+        innerAngle: 0,
+        outerAngle: 0
+      })
     })
   })
 })

packages/@dcl/sdk-commands/package.json

@@ -1,4 +1,4 @@
-SCENE_COMPILED_JS_SIZE_PROD=481.1k bytes
+SCENE_COMPILED_JS_SIZE_PROD=480.5k bytes
 THE BUNDLE HAS SOURCEMAPS
 (start empty vm 0.21.0-3680274614.commit-1808aa1)
   OPCODES ~= 0k
@@ -11,7 +11,7 @@ EVAL test/snapshots/development-bundles/static-scene.test.js
   REQUIRE: ~system/EngineApi
   REQUIRE: ~system/EngineApi
   OPCODES ~= 56k
-  MALLOC_COUNT = 14180
+  MALLOC_COUNT = 14173
   ALIVE_OBJS_DELTA ~= 2.80k
 CALL onStart()
   main.crdt: PUT_COMPONENT e=0x200 c=1 t=0 data={"position":{"x":5.880000114440918,"y":2.7916901111602783,"z":7.380000114440918},"rotation":{"x":0,"y":0,"z":0,"w":1},"scale":{"x":1,"y":1,"z":1},"parent":0}
@@ -56,4 +56,4 @@ CALL onUpdate(0.1)
   OPCODES ~= 3k
   MALLOC_COUNT = -5
   ALIVE_OBJS_DELTA ~= 0.00k
-  MEMORY_USAGE_COUNT ~= 1242.86k bytes
+  MEMORY_USAGE_COUNT ~= 1242.23k bytes

test/ecs/components/LightSource.spec.ts

@@ -1,4 +1,4 @@
-SCENE_COMPILED_JS_SIZE_PROD=481.6k bytes
+SCENE_COMPILED_JS_SIZE_PROD=481k bytes
 THE BUNDLE HAS SOURCEMAPS
 (start empty vm 0.21.0-3680274614.commit-1808aa1)
   OPCODES ~= 0k
@@ -11,7 +11,7 @@ EVAL test/snapshots/development-bundles/testing-fw.test.js
   REQUIRE: ~system/EngineApi
   REQUIRE: ~system/EngineApi
   OPCODES ~= 65k
-  MALLOC_COUNT = 14705
+  MALLOC_COUNT = 14698
   ALIVE_OBJS_DELTA ~= 2.95k
 CALL onStart()
   LOG: ["Adding one to position.y=0"]
@@ -64,4 +64,4 @@ CALL onUpdate(0.1)
   OPCODES ~= 5k
   MALLOC_COUNT = -40
   ALIVE_OBJS_DELTA ~= -0.01k
-  MEMORY_USAGE_COUNT ~= 1251.55k bytes
+  MEMORY_USAGE_COUNT ~= 1250.91k bytes

test/snapshots/development-bundles/static-scene.test.ts.crdt

@@ -1,4 +1,4 @@
-SCENE_COMPILED_JS_SIZE_PROD=481.6k bytes
+SCENE_COMPILED_JS_SIZE_PROD=481k bytes
 THE BUNDLE HAS SOURCEMAPS
 (start empty vm 0.21.0-3680274614.commit-1808aa1)
   OPCODES ~= 0k
@@ -11,7 +11,7 @@ EVAL test/snapshots/development-bundles/two-way-crdt.test.js
   REQUIRE: ~system/EngineApi
   REQUIRE: ~system/EngineApi
   OPCODES ~= 65k
-  MALLOC_COUNT = 14705
+  MALLOC_COUNT = 14698
   ALIVE_OBJS_DELTA ~= 2.95k
 CALL onStart()
   LOG: ["Adding one to position.y=0"]
@@ -64,4 +64,4 @@ CALL onUpdate(0.1)
   OPCODES ~= 5k
   MALLOC_COUNT = -40
   ALIVE_OBJS_DELTA ~= -0.01k
-  MEMORY_USAGE_COUNT ~= 1251.55k bytes
+  MEMORY_USAGE_COUNT ~= 1250.92k bytes