Skip to content

Commit c1537f5

Browse files
authored
chore: pin Node to 24.16.0 to avoid regressions in newer 24.x (#1425)
CI resolved node-version: 24 to the latest 24.x, risking drift past 24.16.0, which introduces bugs. Lock CI, .node-version, and engines to the exact known-good version.
1 parent aed4ecf commit c1537f5

4 files changed

Lines changed: 9 additions & 9 deletions

File tree

.github/workflows/ci.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ jobs:
1919
- uses: actions/checkout@master
2020
- uses: actions/setup-node@v3
2121
with:
22-
node-version: 24
22+
node-version: 24.16.0
2323
cache: 'npm'
2424
- name: install
2525
run: make install
@@ -34,7 +34,7 @@ jobs:
3434
- uses: actions/checkout@master
3535
- uses: actions/setup-node@v3
3636
with:
37-
node-version: 24
37+
node-version: 24.16.0
3838
cache: 'npm'
3939
- name: docs
4040
run: make docs
@@ -46,7 +46,7 @@ jobs:
4646

4747
- uses: actions/setup-node@v3
4848
with:
49-
node-version: 24
49+
node-version: 24.16.0
5050
cache: 'npm'
5151

5252
- name: install
@@ -87,7 +87,7 @@ jobs:
8787
- uses: actions/checkout@master
8888
- uses: actions/setup-node@v3
8989
with:
90-
node-version: 24
90+
node-version: 24.16.0
9191
cache: 'npm'
9292

9393
- name: install
@@ -397,7 +397,7 @@ jobs:
397397
steps:
398398
- uses: actions/setup-node@v3
399399
with:
400-
node-version: 24
400+
node-version: 24.16.0
401401
- run: mkdir -p scene
402402
- name: npx @dcl/sdk-commands init --skip-install
403403
run: npx ${{ secrets.SDK_TEAM_S3_BASE_URL }}/${{ needs.build.outputs.decentraland_sdk_commands_s3_bucket_key }} init --skip-install
@@ -448,7 +448,7 @@ jobs:
448448

449449
- uses: actions/setup-node@v3
450450
with:
451-
node-version: 24
451+
node-version: 24.16.0
452452

453453
- name: Download prepared packages
454454
uses: actions/download-artifact@v4

.github/workflows/update-unity-renderer.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ jobs:
1010
- name: Use Node.js
1111
uses: actions/setup-node@v2
1212
with:
13-
node-version: 24
13+
node-version: 24.16.0
1414
- uses: actions/checkout@v2
1515
- name: Update explorer
1616
run: npm i --save-exact @dcl/explorer@latest

.node-version

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
20
1+
24.16.0

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
"typedoc": "^0.23.28"
3131
},
3232
"engines": {
33-
"node": "20"
33+
"node": "24.16.0"
3434
},
3535
"homepage": "https://github.com/decentraland/js-sdk-toolchain#readme",
3636
"keywords": [],

0 commit comments

Comments
 (0)