Commit fc8cfc6
authored
feat: add ExplorerUiEventsResult component and share the ExplorerUi enum (#1511)
Round 2 of scene-triggered explorer UI. Round 1 (#1503) gave scenes `openExplorerUi`; this adds the result channel, so a scene can observe when the panel it opened is actually shown or dismissed.
Depends on decentraland/protocol#455 — **do not merge before it**.
## What changes
- `ExplorerUiEventsResult` is registered in `GROWN_ONLY_COMPONENTS`, so it generates as a grow-only value set (`APPEND`) rather than LWW, matching `PointerEventsResult` and friends. The generated `maxElements: 100` lines up with the explorer's `MAX_APPEND_COMPONENTS_COUNT`.
- `~system/RestrictedActions` no longer re-declares `ExplorerUi`. The enum moved to `sdk/components/common/explorer_ui.proto` upstream, so `apis.d.ts` now reads `ui: import('../ecs').ExplorerUi` and scene code sees a single nominal type:
```ts
for (const e of ExplorerUiEventsResult.get(engine.RootEntity)) {
if (e.ui === ExplorerUi.EU_MAP) { /* no cast needed */ }
}
```
- Regenerated: `playground-assets.api.md`, 12 CRDT snapshots, three lockfiles.
- New: `test/ecs/components/ExplorerUiEventsResult.spec.ts` (3 tests). The accumulation test is a deliberate guard — the serialization tests alone would still pass if the `GROWN_ONLY_COMPONENTS` entry were dropped.
## Before merging
- [ ] decentraland/protocol#455 merged
- [ ] `@dcl/protocol` repinned from the PR tarball to the published version, lockfiles refreshed, snapshots and `api.md` regenerated
The pin is currently a tarball URL in both `package.json` and `packages/@dcl/sdk-commands/package.json`, because PR builds are not published to npm. It carries one unrelated delta into `api.md` — `AvatarEmoteMask`, from `avatar_shape.proto` — which disappears on repin.
## Verification
Locally: `make build` exit 0 (38/38, including the `check no conflict in types` and `ae-forgotten-export` gates); snapshot comparison 17/17.
`make test` on this Windows checkout reports 12 failures in `test/ecs/composite.spec.ts` plus 3 jest timeouts in sdk-commands. The composite failures are a CRLF artifact: the fixtures are `i/lf w/crlf` under `core.autocrlf=true`, and `composite.spec.ts` compares without the `\r\n` normalization that `snapshots.spec.ts` applies. No `ExplorerUi` line appears in any of those diffs and this branch touches no fixture. CI on Linux is the real signal.
## Follow-up
`openExplorerUiAndWaitClose` — a promise-based helper wrapping the call and its matching result event — is a separate PR.1 parent f858f90 commit fc8cfc6
20 files changed
Lines changed: 216 additions & 98 deletions
File tree
- packages/@dcl
- playground-assets/etc
- sdk-commands
- scripts/protocol-buffer-generation
- test
- ecs/components
- snapshots
- development-bundles
- production-bundles
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | | - | |
| 12 | + | |
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
| |||
Lines changed: 68 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
726 | 726 | | |
727 | 727 | | |
728 | 728 | | |
| 729 | + | |
729 | 730 | | |
730 | 731 | | |
731 | 732 | | |
| |||
1278 | 1279 | | |
1279 | 1280 | | |
1280 | 1281 | | |
| 1282 | + | |
| 1283 | + | |
| 1284 | + | |
| 1285 | + | |
| 1286 | + | |
| 1287 | + | |
| 1288 | + | |
| 1289 | + | |
| 1290 | + | |
| 1291 | + | |
| 1292 | + | |
| 1293 | + | |
| 1294 | + | |
| 1295 | + | |
| 1296 | + | |
| 1297 | + | |
| 1298 | + | |
| 1299 | + | |
| 1300 | + | |
| 1301 | + | |
| 1302 | + | |
1281 | 1303 | | |
1282 | 1304 | | |
1283 | 1305 | | |
| |||
2747 | 2769 | | |
2748 | 2770 | | |
2749 | 2771 | | |
| 2772 | + | |
| 2773 | + | |
| 2774 | + | |
| 2775 | + | |
| 2776 | + | |
| 2777 | + | |
| 2778 | + | |
| 2779 | + | |
| 2780 | + | |
| 2781 | + | |
| 2782 | + | |
| 2783 | + | |
| 2784 | + | |
| 2785 | + | |
| 2786 | + | |
| 2787 | + | |
| 2788 | + | |
| 2789 | + | |
| 2790 | + | |
| 2791 | + | |
| 2792 | + | |
| 2793 | + | |
| 2794 | + | |
| 2795 | + | |
| 2796 | + | |
| 2797 | + | |
| 2798 | + | |
| 2799 | + | |
| 2800 | + | |
| 2801 | + | |
| 2802 | + | |
| 2803 | + | |
| 2804 | + | |
| 2805 | + | |
| 2806 | + | |
| 2807 | + | |
| 2808 | + | |
| 2809 | + | |
| 2810 | + | |
| 2811 | + | |
| 2812 | + | |
| 2813 | + | |
| 2814 | + | |
| 2815 | + | |
| 2816 | + | |
| 2817 | + | |
2750 | 2818 | | |
2751 | 2819 | | |
2752 | 2820 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
17 | | - | |
| 17 | + | |
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
18 | | - | |
| 18 | + | |
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
Lines changed: 4 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
14 | | - | |
| 13 | + | |
| 14 | + | |
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
| |||
55 | 55 | | |
56 | 56 | | |
57 | 57 | | |
58 | | - | |
| 58 | + | |
Lines changed: 5 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | | - | |
13 | | - | |
14 | | - | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
| |||
61 | 61 | | |
62 | 62 | | |
63 | 63 | | |
64 | | - | |
| 64 | + | |
0 commit comments