fix: deep link to world redirects to Genesis after account change (#8848)

* fix: deep link to world redirects to Genesis after account change

- Moved world access check from bootstrap to post-auth in the loading flow, so it runs against the identity the user actually picked (rather than
  the cached one). Remove the now-dead IsUserAuthorisedToAccessWorldAsync
  from IRealmController.

* Added async suffix

* Replaced rethrowing with filtering for OperationCanceledException

* Fixed OperationCanceledException handling as per code style guidelines

* Removed unused TryExtractWorldName

* Removed unused IsUserAuthorisedToAccessWorldAsync from Fake realm controller as well

Author: Maurizio-dcl

Explorer/Assets/DCL/Infrastructure/ECS/SceneLifeCycle/Realm/IRealmController.cs

@@ -1,6 +1,5 @@
 using CommunicationData.URLHelpers;
 using Cysharp.Threading.Tasks;
-using System;
 using System.Threading;
 
 namespace ECS.SceneLifeCycle.Realm
@@ -15,8 +14,6 @@ public interface IRealmController
 
         UniTask<bool> IsReachableAsync(URLDomain realm, CancellationToken ct);
 
-        UniTask<bool> IsUserAuthorisedToAccessWorldAsync(URLDomain realm, CancellationToken ct);
-
         /// <summary>
         ///     Dispose everything on application quit
         /// </summary>
@@ -36,9 +33,6 @@ public UniTask SetRealmAsync(URLDomain realm, CancellationToken ct) =>
             public async UniTask<bool> IsReachableAsync(URLDomain realm, CancellationToken ct) =>
                 false;
 
-            public async UniTask<bool> IsUserAuthorisedToAccessWorldAsync(URLDomain realm, CancellationToken ct) =>
-                false;
-
             public void DisposeGlobalWorld()
             {
                 //ignore

Explorer/Assets/DCL/Infrastructure/Global/Dynamic/Bootstraper.cs

@@ -2,7 +2,6 @@
 using CommunicationData.URLHelpers;
 using Cysharp.Threading.Tasks;
 using DCL.Audio;
-using DCL.Chat.History;
 using DCL.DebugUtilities;
 using DCL.Diagnostics;
 using DCL.FeatureFlags;
@@ -287,27 +286,6 @@ public async UniTask LoadStartingRealmAsync(DynamicWorldContainer dynamicWorldCo
             if (startingRealm.HasValue == false)
                 throw new InvalidOperationException("Starting realm is not set");
 
-            if (realmLaunchSettings.initialRealm is InitialRealm.World)
-            {
-                bool isAuthorized = await dynamicWorldContainer.RealmController
-                    .IsUserAuthorisedToAccessWorldAsync(startingRealm.Value, ct);
-
-                if (!isAuthorized)
-                {
-                    ReportHub.LogWarning(ReportCategory.REALM,
-                        $"[Bootstrap] Startup world '{realmLaunchSettings.TargetWorld}' is not authorized for auto-entry, falling back to Genesis.");
-
-                    dynamicWorldContainer.ChatHistory.AddMessage(
-                        ChatChannel.NEARBY_CHANNEL_ID,
-                        ChatChannel.ChatChannelType.NEARBY,
-                        ChatMessage.NewFromSystem($"Could not auto-enter '{realmLaunchSettings.TargetWorld}' due to world permissions. You were sent to Genesis Plaza."));
-
-                    await dynamicWorldContainer.RealmController
-                        .SetRealmAsync(URLDomain.FromString(realmUrls.GenesisRealm()), ct);
-                    return;
-                }
-            }
-
             await dynamicWorldContainer.RealmController.SetRealmAsync(startingRealm.Value, ct);
         }
 

Explorer/Assets/DCL/Infrastructure/Global/Dynamic/DynamicWorldContainer.cs

@@ -387,7 +387,6 @@ static IMultiPool MultiPoolFactory() =>
 
             var realmContainer = RealmContainer.Create(
                 staticContainer,
-                identityCache,
                 dynamicWorldParams.StaticLoadPositions,
                 debugBuilder,
                 loadingScreenTimeout,
@@ -396,8 +395,7 @@ static IMultiPool MultiPoolFactory() =>
                 bootstrapContainer.DecentralandUrlsSource,
                 appArgs,
                 teleportController,
-                bootstrapContainer.Environment,
-                worldPermissionsService);
+                bootstrapContainer.Environment);
 
             var terrainContainer = TerrainContainer.Create(staticContainer, realmContainer, dynamicWorldParams.EnableLandscape, localSceneDevelopment);
 
@@ -525,7 +523,9 @@ static IMultiPool MultiPoolFactory() =>
                 roomHub,
                 localSceneDevelopment,
                 staticContainer.CharacterContainer,
-                moderationDataProvider);
+                moderationDataProvider,
+                worldPermissionsService,
+                chatHistory);
 
             IRealmNavigator realmNavigator = realmNavigatorContainer.RealmNavigator;
             HomePlaceEventBus homePlaceEventBus = new HomePlaceEventBus();

Explorer/Assets/DCL/Infrastructure/Global/Dynamic/InitializationFlowContainer.cs

@@ -1,9 +1,11 @@
 using DCL.ApplicationBlocklistGuard;
 using DCL.Audio;
 using DCL.Character.Plugin;
+using DCL.Chat.History;
 using DCL.Diagnostics;
 using DCL.Multiplayer.Connections.RoomHubs;
 using DCL.Multiplayer.HealthChecks;
+using DCL.PrivateWorlds;
 using DCL.Profiles.Self;
 using DCL.RealmNavigation;
 using DCL.RealmNavigation.LoadingOperation;
@@ -37,7 +39,9 @@ public static InitializationFlowContainer Create(
             IRoomHub roomHub,
             bool localSceneDevelopment,
             CharacterContainer characterContainer,
-            ModerationDataProvider moderationDataProvider)
+            ModerationDataProvider moderationDataProvider,
+            IWorldPermissionsService worldPermissionsService,
+            IChatHistory chatHistory)
         {
             ILoadingStatus? loadingStatus = staticContainer.LoadingStatus;
 
@@ -100,7 +104,9 @@ public static InitializationFlowContainer Create(
                     characterContainer.CharacterObject,
                     characterContainer.Transform,
                     dynamicWorldParams.StartParcel,
-                    localSceneDevelopment),
+                    localSceneDevelopment,
+                    worldPermissionsService,
+                    chatHistory),
             };
         }
     }

Explorer/Assets/DCL/Infrastructure/Global/Dynamic/RealmController.cs

@@ -8,10 +8,8 @@
 using DCL.Ipfs;
 using DCL.Multiplayer.Connections.DecentralandUrls;
 using DCL.Optimization.Pools;
-using DCL.PluginSystem.Global;
 using DCL.Utilities;
 using DCL.Utilities.Extensions;
-using DCL.Web3.Identities;
 using DCL.WebRequests;
 using ECS;
 using ECS.Prioritization.Components;
@@ -31,7 +29,6 @@
 using Global.AppArgs;
 using Unity.Mathematics;
 using UnityEngine;
-using DCL.PrivateWorlds;
 using DCL.UserInAppInitializationFlow.StartupOperations;
 using Utility;
 
@@ -54,11 +51,9 @@ public class RealmController : IGlobalRealmController
 
         private readonly List<ISceneFacade> allScenes = new (PoolConstants.SCENES_COUNT);
         private readonly ServerAbout serverAbout = new ();
-        private readonly IWeb3IdentityCache web3IdentityCache;
         private readonly IWebRequestController webRequestController;
         private readonly IReadOnlyList<int2> staticLoadPositions;
         private readonly RealmData realmData;
-        private readonly IWorldPermissionsService worldPermissionsService;
         private readonly RetrieveSceneFromFixedRealm retrieveSceneFromFixedRealm;
         private readonly RetrieveSceneFromVolatileWorld retrieveSceneFromVolatileWorld;
         private readonly TeleportController teleportController;
@@ -92,7 +87,6 @@ public GlobalWorld GlobalWorld
         }
 
         public RealmController(
-            IWeb3IdentityCache web3IdentityCache,
             IWebRequestController webRequestController,
             TeleportController teleportController,
             RetrieveSceneFromFixedRealm retrieveSceneFromFixedRealm,
@@ -107,14 +101,11 @@ public RealmController(
             IAppArgs appArgs,
             IDecentralandUrlsSource decentralandUrlsSource,
             DecentralandEnvironment environment,
-            WorldManifestProvider worldManifestProvider,
-            IWorldPermissionsService worldPermissionsService)
+            WorldManifestProvider worldManifestProvider)
         {
-            this.web3IdentityCache = web3IdentityCache;
             this.webRequestController = webRequestController;
             this.staticLoadPositions = staticLoadPositions;
             this.realmData = realmData;
-            this.worldPermissionsService = worldPermissionsService;
             this.teleportController = teleportController;
             this.retrieveSceneFromFixedRealm = retrieveSceneFromFixedRealm;
             this.retrieveSceneFromVolatileWorld = retrieveSceneFromVolatileWorld;
@@ -203,50 +194,6 @@ public async UniTask SetRealmAsync(URLDomain realm, CancellationToken ct)
         public async UniTask<bool> IsReachableAsync(URLDomain realm, CancellationToken ct) =>
             await webRequestController.IsHeadReachableAsync(ReportCategory.REALM, realm.Append(new URLPath("/about")), ct);
 
-        public async UniTask<bool> IsUserAuthorisedToAccessWorldAsync(URLDomain realm, CancellationToken ct)
-        {
-            if (!TryExtractWorldName(realm, out string worldName))
-            {
-                ReportHub.LogWarning(ReportCategory.REALM,
-                    $"[RealmController] Failed to extract world name from realm '{realm}'.");
-                return false;
-            }
-
-            WorldAccessCheckContext context;
-            try
-            {
-                context = await worldPermissionsService.CheckWorldAccessAsync(worldName, ct);
-            }
-            catch (OperationCanceledException) { throw; }
-            catch (Exception e)
-            {
-                ReportHub.LogWarning(ReportCategory.REALM,
-                    $"[RealmController] Failed to verify world access for '{worldName}' via world permissions: {e.Message}");
-                return false;
-            }
-
-            return context.Result == WorldAccessCheckResult.Allowed;
-        }
-
-        private static bool TryExtractWorldName(URLDomain realm, out string worldName)
-        {
-            worldName = string.Empty;
-
-            if (!Uri.TryCreate(realm.Value, UriKind.Absolute, out Uri? uri))
-                return false;
-
-            string path = uri.AbsolutePath.Trim('/');
-            if (string.IsNullOrEmpty(path))
-                return false;
-
-            string[] segments = path.Split('/', StringSplitOptions.RemoveEmptyEntries);
-            if (segments.Length == 0)
-                return false;
-
-            worldName = segments[^1];
-            return !string.IsNullOrEmpty(worldName);
-        }
-
         public async UniTask<List<SceneEntityDefinition>> WaitForFixedScenePromisesAsync(CancellationToken ct)
         {
             FixedScenePointers fixedScenePointers = default;

Explorer/Assets/DCL/RealmNavigation/Container/RealmContainer.cs

@@ -32,7 +32,6 @@ public class RealmContainer
 
         public static RealmContainer Create(
             StaticContainer staticContainer,
-            IWeb3IdentityCache identityCache,
             IReadOnlyList<int2> staticLoadPositions,
             IDebugContainerBuilder debugContainerBuilder,
             LoadingScreenTimeout loadingScreenTimeout,
@@ -41,16 +40,14 @@ public static RealmContainer Create(
             IDecentralandUrlsSource urlsSource,
             IAppArgs appArgs,
             TeleportController teleportController,
-            DecentralandEnvironment dclEnvironment,
-            IWorldPermissionsService worldPermissionsService)
+            DecentralandEnvironment dclEnvironment)
         {
             var retrieveSceneFromFixedRealm = new RetrieveSceneFromFixedRealm();
             var retrieveSceneFromVolatileWorld = new RetrieveSceneFromVolatileWorld(staticContainer.RealmData, urlsSource);
 
             var realmNavigatorDebugView = new RealmNavigatorDebugView(debugContainerBuilder);
 
             var realmController = new RealmController(
-                identityCache,
                 staticContainer.WebRequestsContainer.WebRequestController,
                 teleportController,
                 retrieveSceneFromFixedRealm,
@@ -66,8 +63,7 @@ public static RealmContainer Create(
                 appArgs,
                 urlsSource,
                 dclEnvironment,
-                staticContainer.WorldManifestProvider,
-                worldPermissionsService
+                staticContainer.WorldManifestProvider
             );
 
             BuildDebugWidget(teleportController, debugContainerBuilder, loadingScreen, loadingScreenTimeout);

Explorer/Assets/DCL/UserInAppInitializationFlow/DCL.UserInAppInitializationFlow.asmdef

@@ -32,7 +32,8 @@
         "GUID:c80c82a8f4e04453b85fbab973d6774a",
         "GUID:54d33bbd50a28174e8ba0110106203c2",
         "GUID:875a5d5129614170bd769ed012c2eb3d",
-        "GUID:8614faad1014549c88b57654b0fb41bd"
+        "GUID:8614faad1014549c88b57654b0fb41bd",
+        "GUID:f8127c6ac263abf468221dcbccbde182"
     ],
     "includePlatforms": [],
     "excludePlatforms": [],