claude review

Author: lorenzo-ranciaffi

Explorer/Assets/DCL/Communities/CommunityDataService/CommunityDataService.cs

@@ -13,6 +13,7 @@
 using DCL.Web3.Identities;
 using Decentraland.SocialService.V2;
 using MVC;
+using UnityEngine.Pool;
 using Utility;
 
 namespace DCL.Communities
@@ -239,9 +240,8 @@ private void CommunityDeleted(string communityId)
 
         public void SetCommunities(IEnumerable<GetUserCommunitiesData.CommunityData> newCommunities)
         {
-            string[] previouslyJoined = joinedCommunityIds.Count == 0 ? Array.Empty<string>() : new string[joinedCommunityIds.Count];
-            if (previouslyJoined.Length > 0)
-                joinedCommunityIds.CopyTo(previouslyJoined);
+            using PooledObject<HashSet<string>> _ = HashSetPool<string>.Get(out HashSet<string> previouslyJoined);
+            previouslyJoined.UnionWith(joinedCommunityIds);
 
             communities.Clear();
             joinedCommunityIds.Clear();
@@ -257,7 +257,7 @@ public void SetCommunities(IEnumerable<GetUserCommunitiesData.CommunityData> new
                     CommunityRemoved?.Invoke(id);
 
             foreach (string id in joinedCommunityIds)
-                if (Array.IndexOf(previouslyJoined, id) < 0)
+                if (!previouslyJoined.Contains(id))
                     CommunityJoined?.Invoke(id);
         }
 

Explorer/Assets/DCL/ExplorePanel/ExplorePanelController.cs

@@ -46,7 +46,7 @@ public class ExplorePanelController : ControllerBase<ExplorePanelView, ExplorePa
         private readonly JoinedCommunitiesVoiceLiveTracker communitiesLiveTracker;
         private bool includeCommunities;
 
-        private IDisposable? communitiesLiveBadgeSubscription;
+        private ReactivePropertyExtensions.DisposableSubscription<bool> communitiesLiveBadgeSubscription;
 
         private Dictionary<ExploreSections, TabSelectorView> tabsBySections;
         private Dictionary<ExploreSections, ISection> exploreSections;
@@ -121,8 +121,7 @@ public override void Dispose()
             setupExploreSectionsCts.SafeCancelAndDispose();
             checkForLiveEventsCts.SafeCancelAndDispose();
 
-            communitiesLiveBadgeSubscription?.Dispose();
-            communitiesLiveBadgeSubscription = null;
+            communitiesLiveBadgeSubscription.Dispose();
         }
 
         private async UniTaskVoid OnShowSectionFromNotificationAsync(object[] _, ExploreSections sectionToShow)

Explorer/Assets/DCL/UI/Sidebar/SidebarController.cs

@@ -67,7 +67,7 @@ public class SidebarController : ControllerBase<SidebarView>
         private readonly bool isNearbyVoiceChatEnabled;
         private readonly HttpEventsApiService eventsApiService;
 
-        private IDisposable? communitiesLiveBadgeSubscription;
+        private ReactivePropertyExtensions.DisposableSubscription<bool> communitiesLiveBadgeSubscription;
 
         private readonly CancellationTokenSource profileWidgetCts = new ();
         private CancellationTokenSource checkForLiveEventsCts = new ();
@@ -174,8 +174,7 @@ public override void Dispose()
             openPanelCts.SafeCancelAndDispose();
             checkForLiveEventsCts.SafeCancelAndDispose();
 
-            communitiesLiveBadgeSubscription?.Dispose();
-            communitiesLiveBadgeSubscription = null;
+            communitiesLiveBadgeSubscription.Dispose();
         }
 
         private void OnChatStateChanged(ChatEvents.ChatStateChangedEvent eventData) =>

Explorer/Assets/DCL/VoiceChat/CommunityVoiceChat/JoinedCommunitiesVoiceLiveTracker.cs

@@ -10,7 +10,7 @@ public class JoinedCommunitiesVoiceLiveTracker : IDisposable
         private readonly ICommunityCallOrchestrator orchestrator;
         private readonly ICommunityDataService communityDataService;
 
-        private readonly Dictionary<string, IDisposable> perCommunitySubscriptions = new ();
+        private readonly Dictionary<string, ReactivePropertyExtensions.DisposableSubscription<bool>> perCommunitySubscriptions = new ();
         private readonly HashSet<string> liveJoinedCommunityIds = new ();
         private readonly ReactiveProperty<bool> hasAnyJoinedCommunityLive = new (false);
 
@@ -60,7 +60,7 @@ private void AddSubscription(string communityId)
 
         private void RemoveSubscription(string communityId)
         {
-            if (perCommunitySubscriptions.TryGetValue(communityId, out IDisposable? subscription))
+            if (perCommunitySubscriptions.TryGetValue(communityId, out var subscription))
             {
                 subscription.Dispose();
                 perCommunitySubscriptions.Remove(communityId);
@@ -87,7 +87,7 @@ public void Dispose()
             communityDataService.CommunityJoined -= OnCommunityJoined;
             communityDataService.CommunityRemoved -= OnCommunityRemoved;
 
-            foreach (IDisposable subscription in perCommunitySubscriptions.Values)
+            foreach (var subscription in perCommunitySubscriptions.Values)
                 subscription.Dispose();
 
             perCommunitySubscriptions.Clear();