fix: added double click setting, opt in by default (#8179)

* Added double tap setting, opt in by default

* Added feature flag --double-click-walk

Author: olavra

Explorer/Assets/DCL/Character/CharacterMotion/Systems/UpdatePointAndClickInputSystem.cs

@@ -8,6 +8,7 @@
 using DCL.CharacterMotion.Utils;
 using DCL.Diagnostics;
 using DCL.Input;
+using DCL.Prefs;
 using ECS.Abstract;
 using ECS.LifeCycle.Components;
 using System.Collections.Generic;
@@ -125,6 +126,9 @@ private bool TryResolveDoubleClick(Camera cam, float maxDistance, out Vector3 ta
             if (!navigateToAction.WasPerformedThisFrame())
                 return false;
 
+            if (!DCLPlayerPrefs.GetBool(DCLPrefKeys.SETTINGS_DOUBLE_TAP_TO_MOVE, false))
+                return false;
+
             var mouse = Mouse.current;
 
             if (mouse == null)

Explorer/Assets/DCL/FeatureFlags/FeatureFlagsStrings.cs

@@ -73,6 +73,7 @@ public static class FeatureFlagsStrings
         public const string REPORT_USER = "alfa-report-user";
         public const string POINT_AT = "alfa-point-at";
         public const string AVATAR_CONTEXT_MENU = "alfa-avatar-context-menu";
+        public const string DOUBLE_CLICK_WALK = "alfa-double-click-walk";
 
         public static class Endpoints
         {

Explorer/Assets/DCL/FeatureFlags/FeaturesRegistry.cs

@@ -54,6 +54,7 @@ public FeaturesRegistry(
                 [FeatureId.REPORT_USER] = appArgs.ResolveFeatureFlagArg(AppArgsFlags.REPORT_USER, featureFlags.IsEnabled(FeatureFlagsStrings.REPORT_USER) || Application.isEditor),
                 [FeatureId.POINT_AT] = appArgs.ResolveFeatureFlagArg(AppArgsFlags.POINT_AT, featureFlags.IsEnabled(FeatureFlagsStrings.POINT_AT) || Application.isEditor),
                 [FeatureId.AVATAR_CONTEXT_MENU] = appArgs.ResolveFeatureFlagArg(AppArgsFlags.AVATAR_CONTEXT_MENU, featureFlags.IsEnabled(FeatureFlagsStrings.AVATAR_CONTEXT_MENU) || Application.isEditor),
+                [FeatureId.DOUBLE_CLICK_WALK] = appArgs.ResolveFeatureFlagArg(AppArgsFlags.DOUBLE_CLICK_WALK, featureFlags.IsEnabled(FeatureFlagsStrings.DOUBLE_CLICK_WALK) || Application.isEditor),
                 // Note: COMMUNITIES feature is not cached here because it depends on user identity
             });
 
@@ -172,5 +173,6 @@ public enum FeatureId
         REPORT_USER,
         POINT_AT,
         AVATAR_CONTEXT_MENU,
+        DOUBLE_CLICK_WALK,
     }
 }

Explorer/Assets/DCL/Infrastructure/Global/AppArgs/AppArgsFlags.cs

@@ -94,6 +94,7 @@ public static class AppArgsFlags
         public const string REPORT_USER = "report-user";
 
         public const string AVATAR_CONTEXT_MENU = "avatar-context-menu";
+        public const string DOUBLE_CLICK_WALK = "double-click-walk";
 
         public static class Multiplayer
         {

Explorer/Assets/DCL/PluginSystem/Global/CharacterMotionPlugin.cs

@@ -121,7 +121,8 @@ public void InjectToWorld(ref ArchSystemsWorldBuilder<Arch.Core.World> builder,
                 new HandPointAtComponent(),
                 new TorsoIKComponent());
 
-            UpdatePointAndClickInputSystem.InjectToWorld(ref builder, destinationMarkerPrefab);
+            if (FeaturesRegistry.Instance.IsEnabled(FeatureId.DOUBLE_CLICK_WALK))
+                UpdatePointAndClickInputSystem.InjectToWorld(ref builder, destinationMarkerPrefab);
             InterpolateCharacterSystem.InjectToWorld(ref builder, scenesCache);
             TeleportPositionCalculationSystem.InjectToWorld(ref builder, landscape);
             TeleportCharacterSystem.InjectToWorld(ref builder, sceneReadinessReportQueue);

Explorer/Assets/DCL/Prefs/DCLPrefKeys.cs

@@ -93,6 +93,8 @@ public static class DCLPrefKeys
 
         public const string SETTINGS_HEAD_SYNC_ENABLED = "Settings_HeadSync";
 
+        public const string SETTINGS_DOUBLE_TAP_TO_MOVE = "Settings_DoubleTapToMove";
+
         public const string RECENTLY_VISITED_PLACES = "Recently_Visited_Places";
 
         public const string SKYBOX_FIXED_TIME = "Skybox_FixedTime";

Explorer/Assets/DCL/Settings/Configuration/SettingsMenuConfiguration.asset

@@ -92,6 +92,7 @@ MonoBehaviour:
       - rid: 3126482891795070976
       - rid: 3126482891795070977
       - rid: 5190442991532376251
+      - rid: 3126482891795070978
     - <GroupTitle>k__BackingField: Point At
       <FeatureFlagName>k__BackingField: 0
       <FeatureId>k__BackingField: 53
@@ -735,3 +736,19 @@ MonoBehaviour:
           <IsEnabled>k__BackingField: 1
           defaultIsOn: 0
         <Feature>k__BackingField: 10
+    - rid: 3126482891795070978
+      type: {class: ToggleModuleBinding, ns: DCL.Settings.Configuration, asm: Settings}
+      data:
+        <FeatureId>k__BackingField: 0
+        <View>k__BackingField:
+          m_AssetGUID: 39458b71e0ed84549b1b280c4fb1f105
+          m_SubObjectName:
+          m_SubObjectType:
+          m_SubObjectGUID:
+          m_EditorAssetChanged: 0
+        <Config>k__BackingField:
+          <ModuleName>k__BackingField: Double tap to move
+          <Description>k__BackingField: Double-click on any surface to walk there automatically.
+          <IsEnabled>k__BackingField: 1
+          defaultIsOn: 0
+        <Feature>k__BackingField: 11

Explorer/Assets/DCL/Settings/Configuration/ToggleModuleBinding.cs

@@ -39,6 +39,7 @@ public enum ToggleFeatures
             SCENE_SHADOWS_FEATURE,
             SCENE_LIGHTS_FEATURE,
             FULLSCREEN_FEATURE,
+            DOUBLE_TAP_TO_MOVE,
             // add other features...
         }
 
@@ -80,6 +81,7 @@ public override async UniTask<SettingsFeatureController> CreateModuleAsync(
                 ToggleFeatures.SCENE_SHADOWS_FEATURE => CreateSimpleToggle(viewInstance, qualitySettingsController, qualitySettingsController.SetSceneLightShadows, x => x.SceneLightShadows),
                 ToggleFeatures.SCENE_LIGHTS_FEATURE => CreateSimpleToggle(viewInstance, qualitySettingsController, qualitySettingsController.SetSceneLights, x => x.SceneLights),
                 ToggleFeatures.FULLSCREEN_FEATURE => new FullscreenSettingsController(viewInstance),
+                ToggleFeatures.DOUBLE_TAP_TO_MOVE => new DoubleTapToMoveSettingsController(viewInstance),
                 // add other cases...
                 _ => throw new ArgumentOutOfRangeException(nameof(viewInstance))
             };

Explorer/Assets/DCL/Settings/ModuleControllers/DoubleTapToMoveSettingsController.cs

@@ -0,0 +1,32 @@
+using DCL.FeatureFlags;
+using DCL.Prefs;
+using DCL.Settings.ModuleViews;
+
+namespace DCL.Settings.ModuleControllers
+{
+    public class DoubleTapToMoveSettingsController : SettingsFeatureController
+    {
+        private readonly SettingsToggleModuleView view;
+
+        public DoubleTapToMoveSettingsController(SettingsToggleModuleView view)
+        {
+            this.view = view;
+
+            if (!FeaturesRegistry.Instance.IsEnabled(FeatureId.DOUBLE_CLICK_WALK))
+            {
+                view.SetActive(false);
+                return;
+            }
+
+            bool value = DCLPlayerPrefs.GetBool(DCLPrefKeys.SETTINGS_DOUBLE_TAP_TO_MOVE, false);
+            view.ToggleView.Toggle.SetIsOnWithoutNotify(value);
+            view.ToggleView.Toggle.onValueChanged.AddListener(OnToggleValueChanged);
+        }
+
+        public override void Dispose() =>
+            view.ToggleView.Toggle.onValueChanged.RemoveAllListeners();
+
+        private static void OnToggleValueChanged(bool isOn) =>
+            DCLPlayerPrefs.SetBool(DCLPrefKeys.SETTINGS_DOUBLE_TAP_TO_MOVE, isOn, true);
+    }
+}