fix: account for outfits deploy window from catalysts (#7731)

* fix: account for deploy window from catalysts

* minor fix

---------

Co-authored-by: Ashley Canning <ashley.canning@decentraland.org>

Author: davidejensen

Explorer/Assets/DCL/Backpack/AvatarSection/Outfits/Repository/OutfitsRepository.cs

@@ -1,5 +1,6 @@
-using Cysharp.Threading.Tasks;
+using Cysharp.Threading.Tasks;
 using DCL.Diagnostics;
+using DCL.FeatureFlags;
 using DCL.Ipfs;
 using System;
 using System.Collections.Generic;
@@ -12,6 +13,7 @@
 using Newtonsoft.Json;
 using Utility;
 using Utility.Json;
+using Utility.Times;
 
 namespace DCL.Backpack.AvatarSection.Outfits.Repository
 {
@@ -26,18 +28,48 @@ public class OutfitsRepository
         private static readonly JsonSerializerSettings SERIALIZER_SETTINGS = new ()
             { Converters = new List<JsonConverter> { new ColorJsonConverter() } };
 
+        private const int DEFAULT_DEPLOY_WINDOW_IN_SECONDS = 15;
+
         private readonly PublishIpfsEntityCommand publishIpfsEntityCommand;
         private readonly INftNamesProvider nftNamesProvider;
 
+        private ulong passedTimeSinceLastDeployment = 0;
+        private ulong lastDeployTimestampInSeconds = 0;
+
+        private UniTaskCompletionSource? currentResolutionTask;
+        private List<OutfitItem>? currentOutfits;
+        private int currentVersion;
+
         public OutfitsRepository(PublishIpfsEntityCommand publishIpfsEntityCommand,
             INftNamesProvider nftNamesProvider)
         {
             this.publishIpfsEntityCommand = publishIpfsEntityCommand;
             this.nftNamesProvider = nftNamesProvider;
         }
 
+        private static int deployWindowInSeconds
+        {
+            get
+            {
+                if (FeatureFlagsConfiguration.Instance.TryGetJsonPayload(FeatureFlagsStrings.OUTFITS_DEPLOY_WINDOW,
+                        "deploy_window_in_seconds",
+                        out OutfitsDeployWindowConfig? config) && config.HasValue && config.Value.DeployWindowInSeconds > 0)
+                    return config.Value.DeployWindowInSeconds;
+
+                return DEFAULT_DEPLOY_WINDOW_IN_SECONDS;
+            }
+        }
+
+        [Serializable]
+        private struct OutfitsDeployWindowConfig
+        {
+            [JsonProperty("deploy_window_in_seconds")] public int DeployWindowInSeconds;
+        }
+
         /// <summary>
         ///     Deploys the complete set of outfits for a user to the Catalyst network.
+        ///     Multiple rapid calls are coalesced: only the latest state is deployed,
+        ///     after a 15-second delay that respects the backend rate limit.
         /// </summary>
         public async UniTask SetAsync(Profile? profile, List<OutfitItem> outfits, CancellationToken ct)
         {
@@ -47,33 +79,69 @@ public async UniTask SetAsync(Profile? profile, List<OutfitItem> outfits, Cancel
             if (string.IsNullOrEmpty(profile?.UserId))
                 throw new ArgumentException("Cannot save outfits for a user with an empty UserId");
 
-            INftNamesProvider.PaginatedNamesResponse namesForExtraSlots = await nftNamesProvider.GetAsync(new Web3Address(profile.UserId), 1, 1, ct);
+            currentOutfits = outfits;
+            currentVersion++;
+            var deployWindow = (ulong)deployWindowInSeconds;
 
-            var metadata = new OutfitsMetadata
+            if (currentResolutionTask != null)
             {
-                outfits = outfits, namesForExtraSlots = namesForExtraSlots.Names.Count > 0
-                    ? new List<string>
-                    {
-                        namesForExtraSlots.Names[0],
-                    }
-                    : new List<string>(),
-            };
+                await UniTask.WhenAny(currentResolutionTask.Task, UniTask.WaitUntilCanceled(ct));
+                return;
+            }
 
-            var outfitsEntity = new OutfitsEntity(string.Empty, metadata)
+            currentResolutionTask = new UniTaskCompletionSource();
+
+            try
             {
-                version = OutfitsEntity.DEFAULT_VERSION, pointers = new[]
+                passedTimeSinceLastDeployment = Math.Clamp((DateTime.UtcNow.UnixTimeAsMilliseconds() / 1000) - lastDeployTimestampInSeconds, 0, deployWindow);
+
+                int localVersion;
+
+                do
                 {
-                    $"{profile.UserId}:outfits",
-                },
-                timestamp = DateTimeOffset.UtcNow.ToUnixTimeMilliseconds(), type = IpfsRealmEntityType.Outfits.ToEntityString(), content = Array.Empty<ContentDefinition>(),
-            };
+                    localVersion = currentVersion;
+                    List<OutfitItem> localOutfits = currentOutfits!;
+
+                    await UniTask.Delay(TimeSpan.FromSeconds(deployWindow - (double)passedTimeSinceLastDeployment), cancellationToken: ct);
+
+                    INftNamesProvider.PaginatedNamesResponse namesForExtraSlots = await nftNamesProvider.GetAsync(new Web3Address(profile.UserId), 1, 1, ct);
+
+                    var metadata = new OutfitsMetadata
+                    {
+                        outfits = localOutfits, namesForExtraSlots = namesForExtraSlots.Names.Count > 0
+                            ? new List<string>
+                            {
+                                namesForExtraSlots.Names[0],
+                            }
+                            : new List<string>(),
+                    };
 
-            try { await publishIpfsEntityCommand.ExecuteAsync(outfitsEntity, ct, SERIALIZER_SETTINGS); }
+                    var outfitsEntity = new OutfitsEntity(string.Empty, metadata)
+                    {
+                        version = OutfitsEntity.DEFAULT_VERSION, pointers = new[]
+                        {
+                            $"{profile.UserId}:outfits",
+                        },
+                        timestamp = DateTimeOffset.UtcNow.ToUnixTimeMilliseconds(), type = IpfsRealmEntityType.Outfits.ToEntityString(), content = Array.Empty<ContentDefinition>(),
+                    };
+
+                    await publishIpfsEntityCommand.ExecuteAsync(outfitsEntity, ct, SERIALIZER_SETTINGS);
+                    passedTimeSinceLastDeployment = 0;
+                }
+                while (localVersion != currentVersion);
+
+                currentResolutionTask.TrySetResult();
+            }
             catch (Exception e)
             {
-                ReportHub.LogException(e, ReportCategory.OUTFITS);
+                currentResolutionTask.TrySetException(e);
                 throw;
             }
+            finally
+            {
+                currentResolutionTask = null;
+                lastDeployTimestampInSeconds = DateTime.UtcNow.UnixTimeAsMilliseconds() / 1000;
+            }
         }
     }
 }

Explorer/Assets/DCL/FeatureFlags/FeatureFlagsStrings.cs

@@ -49,6 +49,7 @@ public static class FeatureFlagsStrings
         public const string MINIMUM_REQUIREMENTS = "alfa-minimum-requirements";
         public const string CHAT_TRANSLATION_ENABLED = "alfa-chat-translation";
         public const string OUTFITS_ENABLED = "alfa-outfits";
+        public const string OUTFITS_DEPLOY_WINDOW = "alfa-outfits-deploy-window";
         public const string GIFTING_ENABLED = "alfa-gifting";
         public const string BANNED_USERS_FROM_SCENE = "alfa-banned-users-from-scene";
         public const string CHAT_MESSAGE_BUFFER_CONFIG = "alfa-chat-message-buffer-config";