Commit 71ebbef
fix: pin BoneHider's object sweeps to the two-argument FindObjectsByType overload
Both BoneHider menu items passed FindObjectsInactive.Exclude as the only
argument, leaving the sort mode to whichever overload the compiler resolves -
the shape the review read as a compile break. They only flip a flag on every
result, so instance-ID ordering is work nobody consumes, and the repo's other
call site (NearbyAudioSourceFactoryShould.cs:46) already spells the pair out.
Naming FindObjectsSortMode.None explicitly restores the pre-change
FindObjectsOfType<T>() semantics (inactive excluded, unsorted) and leaves no
overload ambiguity to resolve.
Utility/AssemblyInfo.cs now carries the constraint behind that assembly's
csc.rsp: Utility must compile with zero compiler diagnostics, because any
message emitted for Utility.dll makes Unity's assembly updater read
Utility.mvfrm and crashes the incremental macOS Cloud Build. That is the reason
for -nullable:annotations + -nowarn:0168; a .rsp file has nowhere to hold it,
so without this the flags read as an arbitrary downgrade and get "fixed" back.
FIXNOTES.md records the two review items that take no code change: the
CheckNamespace ban behind the 21 removed suppressions already landed in
05db1c0 (#9396), an ancestor of this PR's base, so merge ordering is
satisfied and no .editorconfig override is wanted (§ Namespaces prescribes
leaving the inspection visible); and the fresh green Editor-assembly build owed
to this branch's head cannot be produced outside the Unity Cloud lanes.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018c638dR1vPysCMbYt2qQg51 parent aa0b122 commit 71ebbef
2 files changed
Lines changed: 8 additions & 3 deletions
File tree
- Explorer/Assets/DCL
- AvatarRendering/AvatarShape/Editor
- Infrastructure/Utility
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
11 | | - | |
| 11 | + | |
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
| |||
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
30 | | - | |
| 30 | + | |
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
2 | 7 | | |
3 | 8 | | |
4 | 9 | | |
0 commit comments