Merge pull request #9362 from decentraland/release/2026-07-13

release: 2026-07-13

Author: anicalbano

.github/workflows/test.yml

@@ -344,12 +344,12 @@ jobs:
           echo "baseline=$baseline" >> "$GITHUB_OUTPUT"
           echo "Baseline warnings: ${baseline:-<none>}"
 
-      # Hard gate: a PR may only merge if it strictly reduces the warning count.
-      # Exception: release/hotfix PRs may merge when the count is unchanged (equality passes).
+      # Hard gate: a dev-targeted PR may only merge if it strictly reduces the warning count.
+      # Release/hotfix PRs skip this gate — each commit already passed it when merging into dev.
       # No baseline yet -> pass (the first dev push seeds it). Add the 'no-warning-ratchet'
-      # label to bypass on a PR that legitimately cannot touch warnings.
+      # label to bypass on a dev PR that legitimately cannot touch warnings.
       - name: Enforce warning reduction (PR)
-        if: github.event_name == 'pull_request'
+        if: github.event_name == 'pull_request' && github.event.pull_request.base.ref == 'dev'
         env:
           COUNT: ${{ steps.warnings.outputs.count }}
           BASELINE: ${{ steps.baseline.outputs.baseline }}

CLAUDE.md

@@ -123,6 +123,7 @@ Reviewers have repeatedly identified AI-generated code by these smells. Check yo
 * **Interfaces with one implementation and no test coverage.** Delete the interface. The concrete class is the contract.
 * **Per-frame logic inside a presenter/controller.** If you're writing `Tick(float dt)` or polling in a UI class, the work belongs in an `ECS` system (`BaseUnityLoopSystem` or `ControllerECSBridgeSystem`). Camera, time, player, and input are already ECS singletons — reach for `TryGet` in a system, not `Camera.main` in a presenter. Profiler markers come free in systems.
 * **Defensive null-checks against non-null declarations.** If the declared type is `T` (not `T?`), don't null-check it. Trust the annotations. Every redundant check is a lie to the reader about what can happen.
+* **`null!` on DTO fields for schema-required properties.** When a DTO class deserializes a JSON response from an API whose OpenAPI/schema definition marks the field as `required`, initializing with `= null!` is the correct pattern — it signals "non-null at runtime because the server guarantees it, but C# needs an initializer." The DTO class *must* include a schema-link comment (e.g. `// Server schema: social-service-ea docs/schemas.yaml#/…/SchemaName`) so reviewers can verify the contract. Fields that are *optional* in the schema must be declared nullable (`T?`) with no `null!`. This exception applies only to deserialized DTO fields — local variables, method return types, and non-DTO code must never use `null!`; use `T?` and propagate the nullable contract instead.
 * **Debug/mock code in production hot paths.** Runtime bools like `DebugRandomizeX` execute on every call in retail builds. Guard debug branches with `#if UNITY_EDITOR` or move them to an editor-only companion system — never rely on a runtime flag alone.
 * **Plugins initializing or mutating containers.** Containers are constructed top-down from the composition root. Plugins **read** from containers. A plugin that writes into a container is a signal the dependency graph is inverted — create a scoped container instead.
 * **`ObjectProxy` is an anti-pattern** — never introduce a new instance. The codebase has been swept of it; the only legitimate remaining uses model true runtime lifecycles (`StaticContainer.MainPlayerAvatarBaseProxy` — avatar set/released as the player loads, and `ExposedCameraData.CameraEntityProxy` — entity created during world build). Every other use was a wiring-order mistake and was eliminated by restructuring. To decouple without it, pick the matching recipe from `docs/architecture-overview.md` § "Deferred dependencies — decoupling without ObjectProxy": create the service before its consumers (hoist it out of a UI container into its own container), model an optional feature as a nullable dependency or null-object, let the container that owns a late-created service also construct the plugins that need it (`DynamicWorldContainer.WorldPlugins`), or pass per-scene data through `ECSWorldInstanceSharedDependencies`.

Explorer/Assets/DCL/ApplicationsGuards/ApplicationMinimumSpecsGuard/Tests/FakeSystemInfoProvider.cs

@@ -1,4 +1,6 @@
-namespace DCL.ApplicationMinimumSpecsGuard.Tests
+using DCL.ApplicationMinimumSpecsGuard;
+
+namespace DCL.ApplicationsGuards.ApplicationMinimumSpecsGuard.Tests
 {
     /// <summary>
     ///     A fake implementation of ISystemInfoProvider for testing purposes.
@@ -12,4 +14,4 @@ public class FakeSystemInfoProvider : ISystemInfoProvider
         public int GraphicsMemorySize { get; set; } = 8192;
         public int SystemMemorySize { get; set; } = 16384;
     }
-}
+}

Explorer/Assets/DCL/ApplicationsGuards/ApplicationMinimumSpecsGuard/Tests/SystemSpecUtilsShould.cs

@@ -1,8 +1,9 @@
+using DCL.ApplicationMinimumSpecsGuard;
 using DCL.FeatureFlags;
 using NUnit.Framework;
 using System.Collections.Generic;
 
-namespace DCL.ApplicationMinimumSpecsGuard.Tests
+namespace DCL.ApplicationsGuards.ApplicationMinimumSpecsGuard.Tests
 {
     public class SystemSpecUtilsShould
     {

Explorer/Assets/DCL/AvatarRendering/AvatarShape/Tests/EditMode/AvatarHideShould.cs

@@ -1,4 +1,3 @@
-using DCL.AvatarRendering.AvatarShape.Tests.EditMode;
 using DCL.AvatarRendering.Loading.Components;
 using DCL.AvatarRendering.Wearables.Components;
 using DCL.AvatarRendering.Wearables.Helpers;
@@ -7,7 +6,7 @@
 using System.Collections.Generic;
 using UnityEngine;
 
-namespace DCL.Tests
+namespace DCL.AvatarRendering.AvatarShape.Tests
 {
     public class AvatarHideShould
     {

Explorer/Assets/DCL/AvatarRendering/AvatarShape/Tests/EditMode/AvatarHighlightSystemShould.cs

@@ -2,7 +2,6 @@
 using DCL.AvatarRendering.AvatarShape.Components;
 using DCL.Interaction.Raycast.Components;
 using ECS.TestSuite;
-using NSubstitute;
 using NUnit.Framework;
 using UnityEngine;
 

Explorer/Assets/DCL/AvatarRendering/AvatarShape/Tests/EditMode/AvatarTransformMatrixJobWrapperShould.cs

@@ -3,85 +3,88 @@
 using NUnit.Framework;
 using UnityEngine;
 
-[Ignore("This produces 200mb worth of logs - @Nick revert this after your change")]
-public class AvatarTransformMatrixJobWrapperShould
+namespace DCL.AvatarRendering.AvatarShape.Tests
 {
-    private AvatarTransformMatrixJobWrapper jobWrapper;
-
-    [SetUp]
-    public void SetUp()
-    {
-        jobWrapper = new AvatarTransformMatrixJobWrapper();
-    }
-
-    [TearDown]
-    public void TearDown()
+    [Ignore("This produces 200mb worth of logs - @Nick revert this after your change")]
+    public class AvatarTransformMatrixJobWrapperShould
     {
-        jobWrapper.Dispose();
-    }
-
-    [Test]
-    public void AddNewAvatarIncrementsAvatarIndex()
-    {
-        var avatarBase = new GameObject().AddComponent<AvatarBase>();
-        var transformMatrixComponent = AvatarTransformMatrixComponent.NewDefault();
-        transformMatrixComponent.IndexInGlobalJobArray.TryGetValue(out int initialIndex);
+        private AvatarTransformMatrixJobWrapper jobWrapper;
 
-        jobWrapper.RegisterAvatar(avatarBase, ref transformMatrixComponent);
+        [SetUp]
+        public void SetUp()
+        {
+            jobWrapper = new AvatarTransformMatrixJobWrapper();
+        }
 
-        transformMatrixComponent.IndexInGlobalJobArray.TryGetValue(out int afterIndex);
-        Assert.AreNotEqual(initialIndex, afterIndex);
-    }
+        [TearDown]
+        public void TearDown()
+        {
+            jobWrapper.Dispose();
+        }
 
-    [Test]
-    public void ResizeArraysDoublesCapacity()
-    {
-        // Add avatars until we exceed the initial capacity and force a resize
-        for (int i = 0; i < AvatarTransformMatrixJobWrapper.AVATAR_ARRAY_SIZE + 1; i++)
+        [Test]
+        public void AddNewAvatarIncrementsAvatarIndex()
         {
             var avatarBase = new GameObject().AddComponent<AvatarBase>();
             var transformMatrixComponent = AvatarTransformMatrixComponent.NewDefault();
+            transformMatrixComponent.IndexInGlobalJobArray.TryGetValue(out int initialIndex);
+
             jobWrapper.RegisterAvatar(avatarBase, ref transformMatrixComponent);
+
+            transformMatrixComponent.IndexInGlobalJobArray.TryGetValue(out int afterIndex);
+            Assert.AreNotEqual(initialIndex, afterIndex);
         }
 
-        // After resizing, the internal array size should be doubled
-        Assert.AreEqual(AvatarTransformMatrixJobWrapper.AVATAR_ARRAY_SIZE * 2, jobWrapper.CurrentAvatarAmountSupported);
-    }
+        [Test]
+        public void ResizeArraysDoublesCapacity()
+        {
+            // Add avatars until we exceed the initial capacity and force a resize
+            for (int i = 0; i < AvatarTransformMatrixJobWrapper.AVATAR_ARRAY_SIZE + 1; i++)
+            {
+                var avatarBase = new GameObject().AddComponent<AvatarBase>();
+                var transformMatrixComponent = AvatarTransformMatrixComponent.NewDefault();
+                jobWrapper.RegisterAvatar(avatarBase, ref transformMatrixComponent);
+            }
 
-    [Test]
-    public void ReleasedIndexesAreReused()
-    {
-        var avatarBase = new GameObject().AddComponent<AvatarBase>();
-        var transformMatrixComponent1 = AvatarTransformMatrixComponent.NewDefault();
-        var transformMatrixComponent2 = AvatarTransformMatrixComponent.NewDefault();
+            // After resizing, the internal array size should be doubled
+            Assert.AreEqual(AvatarTransformMatrixJobWrapper.AVATAR_ARRAY_SIZE * 2, jobWrapper.CurrentAvatarAmountSupported);
+        }
 
-        // Add the first avatar
-        jobWrapper.RegisterAvatar(avatarBase, ref transformMatrixComponent1);
-        transformMatrixComponent1.IndexInGlobalJobArray.TryGetValue(out int firstIndex);
+        [Test]
+        public void ReleasedIndexesAreReused()
+        {
+            var avatarBase = new GameObject().AddComponent<AvatarBase>();
+            var transformMatrixComponent1 = AvatarTransformMatrixComponent.NewDefault();
+            var transformMatrixComponent2 = AvatarTransformMatrixComponent.NewDefault();
 
-        // Release the first avatar
-        jobWrapper.ReleaseAvatar(ref transformMatrixComponent1);
+            // Add the first avatar
+            jobWrapper.RegisterAvatar(avatarBase, ref transformMatrixComponent1);
+            transformMatrixComponent1.IndexInGlobalJobArray.TryGetValue(out int firstIndex);
 
-        // Add a second avatar and check if it reuses the released index
-        jobWrapper.RegisterAvatar(avatarBase, ref transformMatrixComponent2);
-        transformMatrixComponent2.IndexInGlobalJobArray.TryGetValue(out int secondIndex);
+            // Release the first avatar
+            jobWrapper.ReleaseAvatar(ref transformMatrixComponent1);
 
-        Assert.AreEqual(firstIndex, secondIndex);
-    }
+            // Add a second avatar and check if it reuses the released index
+            jobWrapper.RegisterAvatar(avatarBase, ref transformMatrixComponent2);
+            transformMatrixComponent2.IndexInGlobalJobArray.TryGetValue(out int secondIndex);
 
-    [Test]
-    public void MatrixAndBoolArraysResize()
-    {
-        // Fill the wrapper to trigger a resize
-        for (int i = 0; i < AvatarTransformMatrixJobWrapper.AVATAR_ARRAY_SIZE + 1; i++)
-        {
-            var avatarBase = new GameObject().AddComponent<AvatarBase>();
-            var transformMatrixComponent = AvatarTransformMatrixComponent.NewDefault();
-            jobWrapper.RegisterAvatar(avatarBase, ref transformMatrixComponent);
+            Assert.AreEqual(firstIndex, secondIndex);
         }
 
-        // The matrices and bools should have been resized to double their initial size
-        Assert.AreEqual(AvatarTransformMatrixJobWrapper.AVATAR_ARRAY_SIZE * 2, jobWrapper.MatrixFromAllAvatarsLength);
-        Assert.AreEqual(AvatarTransformMatrixJobWrapper.AVATAR_ARRAY_SIZE * 2, jobWrapper.UpdateAvatarLength);
+        [Test]
+        public void MatrixAndBoolArraysResize()
+        {
+            // Fill the wrapper to trigger a resize
+            for (int i = 0; i < AvatarTransformMatrixJobWrapper.AVATAR_ARRAY_SIZE + 1; i++)
+            {
+                var avatarBase = new GameObject().AddComponent<AvatarBase>();
+                var transformMatrixComponent = AvatarTransformMatrixComponent.NewDefault();
+                jobWrapper.RegisterAvatar(avatarBase, ref transformMatrixComponent);
+            }
+
+            // The matrices and bools should have been resized to double their initial size
+            Assert.AreEqual(AvatarTransformMatrixJobWrapper.AVATAR_ARRAY_SIZE * 2, jobWrapper.MatrixFromAllAvatarsLength);
+            Assert.AreEqual(AvatarTransformMatrixJobWrapper.AVATAR_ARRAY_SIZE * 2, jobWrapper.UpdateAvatarLength);
+        }
     }
 }

Explorer/Assets/DCL/AvatarRendering/AvatarShape/Tests/EditMode/FakeWearable.cs

@@ -7,9 +7,8 @@
 using SceneRunner.Scene;
 using System;
 using System.Collections.Generic;
-using UnityEngine;
 
-namespace DCL.AvatarRendering.AvatarShape.Tests.EditMode
+namespace DCL.AvatarRendering.AvatarShape.Tests
 {
     public class FakeWearable : IWearable
     {

Explorer/Assets/DCL/AvatarRendering/AvatarShape/Tests/EditMode/TextureArrayShouldBase.cs

@@ -1,7 +1,6 @@
-using System.Collections.Generic;
-using System.Net.Mime;
 using DCL.AvatarRendering.AvatarShape.Rendering.TextureArray;
 using NUnit.Framework;
+using System.Collections.Generic;
 using UnityEngine;
 
 namespace DCL.AvatarRendering.AvatarShape.Tests

Explorer/Assets/DCL/AvatarRendering/AvatarShape/Tests/EditMode/ToonTextureArrayShould.cs

@@ -1,4 +1,3 @@
-using DCL.AvatarRendering.AvatarShape.Rendering.TextureArray;
 using NUnit.Framework;
 
 namespace DCL.AvatarRendering.AvatarShape.Tests