Merge branch 'chore/visual-test-app-args' of github.com:decentraland/unity-explorer into test/visual-tests

Author: pravusjif

Explorer/Assets/DCL/Infrastructure/Global/AppArgs/AppArgsFlags.cs

@@ -57,6 +57,7 @@ public static class AppArgsFlags
         public const string CREATOR_HUB_BIN_PATH = "creator-hub-bin-path";
 
         public const string USE_LOG_MATRIX = "use-log-matrix";
+        public const string GRAPHICS = "graphics";
         public const string WINDOWED_MODE = "windowed-mode";
         public const string RESOLUTION = "resolution";
         public const string DISABLE_WINDOW_RESTRICTIONS = "disable-window-restrictions";

Explorer/Assets/DCL/Infrastructure/Global/Dynamic/Bootstraper.cs

@@ -2,12 +2,10 @@
 using CommunicationData.URLHelpers;
 using Cysharp.Threading.Tasks;
 using DCL.Audio;
-using DCL.CharacterCamera;
 using DCL.Chat.History;
 using DCL.DebugUtilities;
 using DCL.Diagnostics;
 using DCL.FeatureFlags;
-using DCL.InWorldCamera;
 using DCL.Multiplayer.Connections.DecentralandUrls;
 using DCL.Notifications.NewNotification;
 using DCL.Optimization.PerformanceBudgeting;
@@ -352,31 +350,32 @@ await dynamicWorldContainer.UserInAppInAppInitializationFlow.ExecuteAsync(
                     playerEntity: playerEntity
                 ), ct);
 
-            OpenDefaultUI(dynamicWorldContainer.MvcManager, globalWorld.EcsWorld, ct);
+            OpenDefaultUI(dynamicWorldContainer.MvcManager, ct);
 
             splashScreen.Hide();
         }
 
-        private void OpenDefaultUI(IMVCManager mvcManager, World ecsWorld, CancellationToken ct)
+        private void OpenDefaultUI(IMVCManager mvcManager, CancellationToken ct)
         {
             mvcManager.ShowAsync(NewNotificationController.IssueCommand(), ct).Forget();
             mvcManager.ShowAsync(MainUIController.IssueCommand(), ct).Forget();
 
             if (appArgs.HasFlag(AppArgsFlags.DISABLE_HUD))
-                DisableHudOnStartupAsync(ecsWorld, ct).Forget();
+                DisableHudOnStartupAsync(mvcManager, ct).Forget();
         }
 
-        private static async UniTaskVoid DisableHudOnStartupAsync(World ecsWorld, CancellationToken ct)
+        internal static async UniTask DisableHudOnStartupAsync(IMVCManager mvcManager, CancellationToken ct)
         {
             try
             {
-                // Wait a frame: MVC views are lazy; SetViewCanvasActive no-ops until viewFactory has run.
+                // Wait a frame so lazily-mounted MVC views exist before toggling.
                 await UniTask.NextFrame(ct).SuppressCancellationThrow();
 
                 if (ct.IsCancellationRequested)
                     return;
 
-                ecsWorld.Add(ecsWorld.CacheCamera(), new ToggleUIRequest { Enable = false, Except = null });
+                // Bypass ToggleUIRequest (used by U key) so scene SDK UIDocuments stay visible.
+                mvcManager.SetAllViewsCanvasActive(false);
             }
             catch (Exception e) { ReportHub.LogException(e, ReportCategory.STARTUP); }
         }

Explorer/Assets/DCL/Infrastructure/Global/Tests/EditMode/BootstraperShould.cs

@@ -0,0 +1,37 @@
+using Cysharp.Threading.Tasks;
+using Global.Dynamic;
+using MVC;
+using NSubstitute;
+using NUnit.Framework;
+using System.Collections;
+using System.Threading;
+using UnityEngine.TestTools;
+
+namespace Global.Tests.EditMode
+{
+    public class BootstraperShould
+    {
+        [UnityTest]
+        public IEnumerator DisableHudOnStartup_OnlyTouchesMVCCanvases_NotSceneUIDocuments()
+        {
+            IMVCManager mvcManager = Substitute.For<IMVCManager>();
+
+            yield return Bootstrap.DisableHudOnStartupAsync(mvcManager, CancellationToken.None).ToCoroutine();
+
+            mvcManager.Received(1).SetAllViewsCanvasActive(false);
+            mvcManager.DidNotReceiveWithAnyArgs().SetAllViewsCanvasActive(default(IController), default);
+        }
+
+        [UnityTest]
+        public IEnumerator DisableHudOnStartup_DoesNothing_WhenCancelledBeforeFrameAdvances()
+        {
+            IMVCManager mvcManager = Substitute.For<IMVCManager>();
+            var cts = new CancellationTokenSource();
+            cts.Cancel();
+
+            yield return Bootstrap.DisableHudOnStartupAsync(mvcManager, cts.Token).ToCoroutine();
+
+            mvcManager.DidNotReceiveWithAnyArgs().SetAllViewsCanvasActive(default);
+        }
+    }
+}

Explorer/Assets/DCL/Infrastructure/Global/Tests/EditMode/BootstraperShould.cs.meta

@@ -62,6 +62,12 @@ public QualitySettingsController(
             this.appArgs = appArgs;
             this.analytics = analytics;
 
+            if (SavedQualitySettingsApplier.TryGetPresetOverride(appArgs, out QualityPresetLevel overridePreset))
+            {
+                ApplyPresetInternal(overridePreset, persist: false);
+                return;
+            }
+
             QualityPresetLevel savedPreset = SavedQualitySettingsApplier.ReadSavedPreset();
 
             if (savedPreset == QualityPresetLevel.Custom)
@@ -73,7 +79,10 @@ public QualitySettingsController(
             else { SetPreset(savedPreset); }
         }
 
-        public void SetPreset(QualityPresetLevel level)
+        public void SetPreset(QualityPresetLevel level) =>
+            ApplyPresetInternal(level, persist: true);
+
+        private void ApplyPresetInternal(QualityPresetLevel level, bool persist)
         {
             if (level == QualityPresetLevel.Custom) { throw new ArgumentException("Cannot set custom preset from QualitySettingsController"); }
 
@@ -85,9 +94,11 @@ public void SetPreset(QualityPresetLevel level)
             CurrentPreset = level;
             presetData = preset;
 
-            DCLPlayerPrefs.SetInt(DCLPrefKeys.PS_QUALITY_PRESET, EnumUtils.ToInt(level));
-
-            DeleteCustomSettings();
+            if (persist)
+            {
+                DCLPlayerPrefs.SetInt(DCLPrefKeys.PS_QUALITY_PRESET, EnumUtils.ToInt(level));
+                DeleteCustomSettings();
+            }
 
             FpsLimit = preset.FpsLimit;
             VSync = preset.VSyncEnabled;
@@ -107,11 +118,14 @@ public void SetPreset(QualityPresetLevel level)
             ShadowDistance = preset.ShadowDistance;
             PlayCurrentSceneStreamsOnly = preset.PlayCurrentSceneStreamsOnly;
 
-            ApplyAllSettings();
+            ApplyAllSettings(persist);
             OnPresetChanged?.Invoke(level);
         }
 
-        public void ApplyAllSettings()
+        public void ApplyAllSettings() =>
+            ApplyAllSettings(persist: true);
+
+        private void ApplyAllSettings(bool persist)
         {
             URPSettingsApplier.ApplyVSync(VSync, FpsLimit);
             upscalingController.UpdateUpscaling(ResolutionScale);
@@ -125,7 +139,7 @@ public void ApplyAllSettings()
             landscapeData.DetailDistance = LandscapeDistance;
 
             URPSettingsApplier.ApplySunShadows(SunShadows);
-            DCLPlayerPrefs.SetBool(DCLPrefKeys.PS_SUN_LENS_FLARE, SunLensFlare);
+            if (persist) DCLPlayerPrefs.SetBool(DCLPrefKeys.PS_SUN_LENS_FLARE, SunLensFlare);
             URPSettingsApplier.ApplySunLensFlare(SunLensFlare);
             URPSettingsApplier.ApplySceneLight(SceneLights);
             URPSettingsApplier.ApplyMaxObjectsPerLight(MaxSceneLights);

Explorer/Assets/DCL/Quality/Runtime/QualitySettingsController.cs

@@ -1,4 +1,7 @@
+using DCL.Diagnostics;
 using DCL.Prefs;
+using Global.AppArgs;
+using System;
 using Utility;
 
 namespace DCL.Quality.Runtime
@@ -8,6 +11,26 @@ namespace DCL.Quality.Runtime
     /// </summary>
     public static class SavedQualitySettingsApplier
     {
+        /// <summary>
+        ///     Reads a quality preset override from app arguments (e.g. --graphics high).
+        ///     Custom is rejected — only Low/Medium/High are valid.
+        /// </summary>
+        public static bool TryGetPresetOverride(IAppArgs appArgs, out QualityPresetLevel preset)
+        {
+            preset = default;
+
+            if (!appArgs.TryGetValue(AppArgsFlags.GRAPHICS, out string? value) || string.IsNullOrEmpty(value))
+                return false;
+
+            if (!Enum.TryParse(value, ignoreCase: true, out preset) || preset == QualityPresetLevel.Custom)
+            {
+                ReportHub.LogWarning(ReportCategory.SETTINGS_MENU, $"Invalid value for --{AppArgsFlags.GRAPHICS}: '{value}'. Expected Low, Medium or High.");
+                return false;
+            }
+
+            return true;
+        }
+
         public struct SavedValues
         {
             public int FpsLimit;

Explorer/Assets/DCL/Quality/Runtime/SavedQualitySettingsApplier.cs

@@ -241,6 +241,19 @@ More detailed instructions on how to test can be found in the description of rel
 
 ---
 
+### `graphics`
+**Type:** String (`Low`, `Medium`, or `High`, case-insensitive)
+**Description:** Forces a graphics quality preset on startup, overriding whatever preset is saved in PlayerPrefs. The override is ephemeral — PlayerPrefs are not modified, so launching again without the flag restores the user's saved preset (including any `Custom` overrides). `Custom` is not accepted as a value.
+
+**Usage:**
+```bash
+--graphics high
+--graphics medium
+--graphics low
+```
+
+---
+
 ## Development Tools Flags
 
 ### `identity-expiration-duration`
@@ -360,6 +373,25 @@ More detailed instructions on how to test can be found in the description of rel
 
 ---
 
+## Visual Test Determinism
+
+Visual regression tests need a deterministic scene: a fixed window, no time-of-day drift, no procedural terrain, and no overlapping HUD UI on top of the rendered output. The flags below are the canonical set passed to the Explorer when capturing or comparing reference frames.
+
+| Flag | Effect in visual tests |
+| --- | --- |
+| `--landscape-terrain-enabled false` | Disables the procedural landscape terrain so the empty/grid background is identical across runs. Requires `--debug` (the flag is gated to debug builds). |
+| `--skybox-time-enabled false` | Freezes the skybox time-of-day cycle so lighting, sun position, and shadows stay constant frame-to-frame. |
+| `--resolution 1920x1080` | Forces a fixed render resolution. Capturing at the same resolution that the reference frames were taken at avoids upscaler/MSAA differences. Only honored in fullscreen mode. |
+| `--windowed-mode` | Forces windowed mode so the OS doesn't apply display-server-specific fullscreen scaling. Pair with `--resolution` to lock the captured framebuffer size. |
+| `--disable-hud` | Hides the HUD (chat, minimap, notifications, etc.) so transient UI doesn't pollute the captured frame. SDK UI from scenes remains visible. |
+
+**Example launch:**
+```bash
+--debug --landscape-terrain-enabled false --skybox-time-enabled false --resolution 1920x1080 --windowed-mode --disable-hud
+```
+
+---
+
 ## Notes
 
 - Most boolean flags are presence flags (they don't require a value). Simply including `--flag-name` enables the feature.