fix: comms fail to recover after network disconnect (#8812)

Author: sandrade-dcl

Explorer/Assets/DCL/Multiplayer/Connections/Archipelago/Rooms/ChatConnectiveRoom.cs

@@ -54,7 +54,7 @@ protected override UniTask PrewarmAsync(CancellationToken token)
         protected override async UniTask CycleStepAsync(CancellationToken token)
         {
             if (CurrentState() is not IConnectiveRoom.State.Running // CurrentState will be != Running at start, so we need to connect
-                || Room().Info.ConnectionState == LKConnectionState.ConnDisconnected) // If the room was running but our connection was lost at some point, we need to reconnect
+                || Room().Info.ConnectionState != LKConnectionState.ConnConnected) // If the room was running but our connection was lost (or stuck reconnecting), we need to reconnect
             {
                 string connectionString = await ConnectionStringAsync(token);
                 await TryConnectToRoomAsync(connectionString, token);

Explorer/Assets/DCL/Multiplayer/Connections/GateKeeper/Meta/SceneRoomMetaDataSource.cs

@@ -94,7 +94,12 @@ public async UniTask<Result<MetaData>> MetaDataAsync(MetaData.Input input, Cance
 
             StreamableLoadingResult<SceneDefinitions> result = promise.Result!.Value;
 
-            if (result.Succeeded && entityDefinitionList.Count > 0)
+            // Don't collapse a network failure into "no scene at this position":
+            // that path parks the room until the player changes parcel.
+            if (!result.Succeeded)
+                return Result<MetaData>.ErrorResult(result.Exception?.Message ?? "Failed to fetch scene definition");
+
+            if (entityDefinitionList.Count > 0)
             {
                 SceneEntityDefinition? sceneDefinition = entityDefinitionList[0];
                 string? id = sceneDefinition.id;

Explorer/Assets/DCL/Multiplayer/Connections/GateKeeper/Rooms/GateKeeperSceneRoom.cs

@@ -155,11 +155,11 @@ async UniTask WaitForMetadataIsDirtyAsync(CancellationToken token)
                 }
                 else
                 {
-                    if (!meta.Equals(currentMetaData.GetValueOrDefault()) || Room().Info.ConnectionState == LKConnectionState.ConnDisconnected)
+                    if (!meta.Equals(currentMetaData.GetValueOrDefault()) || Room().Info.ConnectionState != LKConnectionState.ConnConnected)
                     {
                         string connectionString = await ConnectionStringAsync(meta, token);
 
-                        if (Room().Info.ConnectionState == LKConnectionState.ConnDisconnected)
+                        if (Room().Info.ConnectionState != LKConnectionState.ConnConnected)
                             currentMetaData = null;
 
                         // if the player returns to the previous scene but the new room has been connected, the previous connection should be preserved