fix: bugsweep week 2026-W34 - #9769
Closed
alejandro-jimenez-dcl wants to merge 12 commits into
Closed
Conversation
…ing (#9735) Both SignedFetchWrap and AuthChainHeaderNames pre-built a fixed-size header name array (hardcoded 5 entries and enum-count-sized respectively). A chain with a sixth link threw IndexOutOfRangeException. Replace with direct string interpolation matching what RPCSocialServices and PulseMultiplayerBus already do, and what every other client (godot-explorer, bevy-explorer, lamb2) does. No behaviour change for the current 3-link chains.
… not an array (#9733) The profiles API occasionally returns a response where the "avatars" field is absent or not a JSON array. DeserializeProfileList threw ArgumentException in both that case and the empty-array case, surfacing as an unhandled exception in the web request pipeline. Return null instead so callers receive no profile rather than a crash.
…etPlaybackPropertiesAsync (#9695) WaitUntil(() => control.GetBufferedTimes().Count > 0) never resolved when media errored or closed mid-wait: UUAV stays out of Ready/Playing/Paused/Ended and AVPro likewise never returns a buffered range. Extend the predicate to also exit on GetLastError() != ErrorCode.None and return early so the subsequent seek and play calls are skipped, avoiding a hang on both backends.
…r.LoadImageAsync instead of attempting Addressables fallback (#9679) When the web request was cancelled (Dispose triggering internalCts.Cancel), the first catch (Exception e) block tried the Addressables fallback without a token. That fallback could throw (key not found), escaping the catch block and propagating through GetAtlasChunkPrefabAsync without being suppressed. Split the catch to re-throw OperationCanceledException immediately and protect the Addressables fallback in its own try/catch so a failed fallback cannot escape either.
Contributor
🚦 CI Status
New build in progress, come back later! Lint did not finish (
|
decentraland-bot
self-requested a review
August 17, 2026 14:55
Contributor
Author
|
This was a test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
What does this PR change?
Automated weekly bug sweep for ISO week 2026-W34. Open issues created in the last 7 days were triaged; 5 were fixed and 23 were skipped (duplicates, native-only crashes, open PRs already covering the fix, or scope too wide for a single sweep commit).
Fixed
x-identity-auth-chain-4); longer chains throw instead of being sent #9735SignedFetchWrap/AuthChainHeaderNames: auth-chain headers were emitted from a fixed-size 5-element array, causingIndexOutOfRangeExceptionfor any chain with 6+ links. Replaced both arrays with direct string interpolation.ProfileConverter.DeserializeProfileList: threwArgumentExceptionwhen the profiles API response had noavatarsfield or it was not an array. Changed to returnnull(which theProfile?return path already handles).MediaPlayerExtensions.SetPlaybackPropertiesAsync:WaitUntilhung forever when media entered an error state. Added error-code check to the predicate and an early return guard after the wait.SatelliteChunkController.LoadImageAsync:OperationCanceledExceptionwas caught by the general catch block, triggering an Addressables fallback that could also throw. Re-throw OCE first; wrap the fallback in its own try/catch.GPUInstancingService:FindKernelthrows when the platform does not support compute shaders. Guard the constructor withSystemInfo.supportsComputeShaders; setIsEnabled = falseand return early on unsupported platforms.Not worked on
Test Instructions
Steps (standard run):
\\�ash
metaforge explorer run XXXX
\\
Expected result: Explorer loads without exceptions from the five fixed issues. GPU instancing silently disabled on unsupported platforms. Media players do not hang on load errors. Satellite map cancellation does not trigger Addressables fallback. Auth-chain requests work for chains of any length.
Steps (fresh account):
\\�ash
metaforge account create --clear
metaforge explorer run XXXX
\\
Test Steps
FindKernelexception.avatarsfield; confirm null returned instead of exception.Quality Checklist