Skip to content

Commit 47d690d

Browse files
committed
netsync: Don't request recently removed mix msgs.
This modifies the logic that determines if a mixing message should be requested to avoid requesting recently removed mixing messages by making use of the newer RecentMessage method that queries both the existing messages in the mixing pool and recently removed messages.
1 parent f0bd46a commit 47d690d

1 file changed

Lines changed: 3 additions & 6 deletions

File tree

internal/netsync/manager.go

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1551,15 +1551,12 @@ func (m *SyncManager) needMixMsg(hash *chainhash.Hash) bool {
15511551
return false
15521552
}
15531553

1554-
if m.cfg.MixPool.HaveMessage(hash) {
1554+
// No need for mix messages that are already available in the mixing pool or
1555+
// were recently removed.
1556+
if _, ok := m.cfg.MixPool.RecentMessage(hash); ok {
15551557
return false
15561558
}
15571559

1558-
// TODO: It would be ideal here to not 'need' previously-observed
1559-
// messages that are known/expected to fail validation, or messages
1560-
// that have already been removed from mixpool. An LRU of recently
1561-
// removed mixpool messages may work well.
1562-
15631560
return true
15641561
}
15651562

0 commit comments

Comments
 (0)