Skip to content

Commit bb6e8b4

Browse files
committed
Update wire to fix a potential use-after-free
MsgTx decoding could result in caller-provided scripts being incorrectly added to the script freelist when decoding errors. These scripts will be reused during later deserializations, overwriting the existing scripts caller previously provided. This is, in other words, the same as a use-after-free violation in languages with manual memory management. wire v1.7.4 provides a mitigation for this issue, as well as other performance improvements and addrv2 message support that dcrwallet will eventually benefit from.
1 parent 1d35454 commit bb6e8b4

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ require (
2525
github.com/decred/dcrd/rpc/jsonrpc/types/v4 v4.4.0
2626
github.com/decred/dcrd/rpcclient/v8 v8.1.0
2727
github.com/decred/dcrd/txscript/v4 v4.1.2
28-
github.com/decred/dcrd/wire v1.7.2
28+
github.com/decred/dcrd/wire v1.7.4
2929
github.com/decred/go-socks v1.1.0
3030
github.com/decred/slog v1.2.0
3131
github.com/decred/vspd/client/v4 v4.0.2

go.sum

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,8 +58,8 @@ github.com/decred/dcrd/rpcclient/v8 v8.1.0 h1:FLZ1j4ub7+O9oCIcKf+frYCrZW++G3FSzk
5858
github.com/decred/dcrd/rpcclient/v8 v8.1.0/go.mod h1:iTHqLrHnS2VLJPHQk7guy0BP3jKvMew9STDqWWhFNA4=
5959
github.com/decred/dcrd/txscript/v4 v4.1.2 h1:1EP7ZmBDl2LBeAMTEygxY8rVNN3+lkGqrsb4u64x+II=
6060
github.com/decred/dcrd/txscript/v4 v4.1.2/go.mod h1:r5/8qfCnl6TFrE369gggUayVIryM1oC7BLoRfa27Ckw=
61-
github.com/decred/dcrd/wire v1.7.2 h1:04vpHHE3t78rDztjZx82JV2EEOMDUtUUB1347H32kho=
62-
github.com/decred/dcrd/wire v1.7.2/go.mod h1:eP9XRsMloy+phlntkTAaAm611JgLv8NqY1YJoRxkNKU=
61+
github.com/decred/dcrd/wire v1.7.4 h1:eiURpeK7wDbcseA9oWR/vGjo97W7oqcyWhYWq2FBg3Y=
62+
github.com/decred/dcrd/wire v1.7.4/go.mod h1:NZK8QD5W2ObX6p+Q0TUzYNpQtk4Ov3pBIvc6ZUK88FU=
6363
github.com/decred/go-socks v1.1.0 h1:dnENcc0KIqQo3HSXdgboXAHgqsCIutkqq6ntQjYtm2U=
6464
github.com/decred/go-socks v1.1.0/go.mod h1:sDhHqkZH0X4JjSa02oYOGhcGHYp12FsY1jQ/meV8md0=
6565
github.com/decred/slog v1.2.0 h1:soHAxV52B54Di3WtKLfPum9OFfWqwtf/ygf9njdfnPM=

0 commit comments

Comments
 (0)