Skip to content

[Code scan] Align DPRc example type_map with its data metadata #145

Description

@njzjz

This issue was found by a Codex global scan of the repository at commit 19f9265.

The DPRc MACE and NequIP example inputs use this model type_map order:

"type_map": [
"C",
"P",
"O",
"H",
"OW",
"HW"
],

"type_map": [
"C",
"P",
"O",
"H",
"OW",
"HW"
],

But the bundled data metadata uses a different order:

C
H
HW
O
OW
P

Input order: C, P, O, H, OW, HW
Data order: C, H, HW, O, OW, P

If DeePMD does not remap exactly as intended for this example, the same integer types in type.raw will be interpreted as different elements during training. Even if remapping is supported, the example currently looks inconsistent to users copying it as a template.

Suggested fix: align the example input type_map order with type_map.raw, or add a short comment/documentation note explaining the intended remapping behavior.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions