Skip to content

Commit cd91980

Browse files
authored
tut 46: fix images download (#454)
1 parent 0284159 commit cd91980

1 file changed

Lines changed: 18 additions & 23 deletions

File tree

tutorials/46_Multimodal_RAG.ipynb

Lines changed: 18 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -130,26 +130,26 @@
130130
"outputId": "08febdb6-3e36-4330-bed8-385710eb3339",
131131
"scrolled": true
132132
},
133-
"outputs": [
134-
{
135-
"data": {
136-
"text/plain": [
137-
"('capybara.jpg', <http.client.HTTPMessage at 0x7b1a2bfad8d0>)"
138-
]
139-
},
140-
"execution_count": 3,
141-
"metadata": {},
142-
"output_type": "execute_result"
143-
}
144-
],
133+
"outputs": [],
145134
"source": [
146-
"from urllib.request import URLopener\n",
135+
"import shutil\n",
136+
"from urllib.request import Request, urlopen\n",
137+
"\n",
138+
"HEADERS = {\"User-Agent\": \"haystack-tutorials\"}\n",
147139
"\n",
148-
"url_opener = URLopener()\n",
149-
"url_opener.addheader(\"User-Agent\", \"Mozilla/5.0\")\n",
140+
"def download_image(url, filename):\n",
141+
" req = Request(url, headers=HEADERS)\n",
142+
" with urlopen(req) as r, open(filename, \"wb\") as f:\n",
143+
" shutil.copyfileobj(r, f)\n",
150144
"\n",
151-
"url_opener.retrieve(\"https://upload.wikimedia.org/wikipedia/commons/2/26/Pink_Lady_Apple_%284107712628%29.jpg?download\", \"apple.jpg\")\n",
152-
"url_opener.retrieve(\"https://upload.wikimedia.org/wikipedia/commons/thumb/e/e1/Cattle_tyrant_%28Machetornis_rixosa%29_on_Capybara.jpg/960px-Cattle_tyrant_%28Machetornis_rixosa%29_on_Capybara.jpg?download\", \"capybara.jpg\")"
145+
"download_image(\n",
146+
" \"https://upload.wikimedia.org/wikipedia/commons/2/26/Pink_Lady_Apple_%284107712628%29.jpg\",\n",
147+
" \"apple.jpg\",\n",
148+
")\n",
149+
"download_image(\n",
150+
" \"https://upload.wikimedia.org/wikipedia/commons/thumb/e/e1/Cattle_tyrant_%28Machetornis_rixosa%29_on_Capybara.jpg/960px-Cattle_tyrant_%28Machetornis_rixosa%29_on_Capybara.jpg\",\n",
151+
" \"capybara.jpg\",\n",
152+
")"
153153
]
154154
},
155155
{
@@ -350,12 +350,7 @@
350350
}
351351
],
352352
"source": [
353-
"from urllib.request import URLopener\n",
354-
"\n",
355-
"url_opener = URLopener()\n",
356-
"url_opener.addheader(\"User-Agent\", \"Mozilla/5.0\")\n",
357-
"\n",
358-
"url_opener.retrieve(\"https://arxiv.org/pdf/1706.03762\", \"attention_is_all_you_need.pdf\")"
353+
"download_image(\"https://arxiv.org/pdf/1706.03762\", \"attention_is_all_you_need.pdf\")"
359354
]
360355
},
361356
{

0 commit comments

Comments
 (0)