fix: namehash

Author: 0xAustrian

src/contracts/L2Resolver.sol

@@ -33,7 +33,7 @@ contract L2Resolver is IL2Resolver, IERC165 {
   address public immutable REVERSE_ADMIN;
 
   /// @inheritdoc IL2Resolver
-  bytes32 public constant PARENT_NODE = keccak256('l2.eth');
+  bytes32 public constant PARENT_NODE_NAMEHASH = 0xe0266f32655869693dc63423876e5a7367f6e55552b718bdf9c96d0b31f8155d;
 
   /// @inheritdoc IL2Resolver
   mapping(bytes32 _node => mapping(string _key => bytes _data)) public records;
@@ -67,7 +67,7 @@ contract L2Resolver is IL2Resolver, IERC165 {
       } else {
         // If the node is not owned by the ENSRegistry, then it could be a wildcard and caller must be an approved
         // operator or the owner of the parent node
-        address _parentOwner = _getOwner(PARENT_NODE);
+        address _parentOwner = _getOwner(PARENT_NODE_NAMEHASH);
         if (_parentOwner == address(0)) revert NotAuthorized();
         if (!_isApprovedOperatorOrOwner(msg.sender, _parentOwner)) revert NotAuthorized();
       }

src/interfaces/IL2Resolver.sol

@@ -120,8 +120,8 @@ interface IL2Resolver {
   function REVERSE_ADMIN() external view returns (address _adminAddress);
 
   /**
-   * @notice The parent node namehash for wildcard resolution and authorization.
-   * @return _parentNode The parent node namehash.
+   * @notice The parent node (l2.eth) namehash for wildcard resolution and authorization.
+   * @return _parentNodeNamehash The parent node namehash.
    */
-  function PARENT_NODE() external view returns (bytes32 _parentNode);
+  function PARENT_NODE_NAMEHASH() external view returns (bytes32 _parentNodeNamehash);
 }

test/unit/L2Resolver.t.sol

@@ -17,7 +17,7 @@ contract UnitL2Resolver is Test {
   address internal _reverseAdmin = makeAddr('ReverseAdmin');
   bytes32 internal _reverseLookupNode;
   string internal _key;
-  bytes32 internal _parentNode = keccak256('l2.eth');
+  bytes32 internal _parentNodeNamehash = 0xe0266f32655869693dc63423876e5a7367f6e55552b718bdf9c96d0b31f8155d; // l2.eth
 
   function setUp() external {
     _l2Resolver = new L2Resolver(_ensRegistry, _nameWrapper, _reverseAdmin);
@@ -222,10 +222,12 @@ contract UnitL2Resolver is Test {
   ) external whenTheNodeHasNoENSRegistryOwner(_node) {
     vm.assume(_parentNodeOwner != address(0));
     vm.assume(_parentNodeOwner != _nameWrapper);
-    vm.assume(_node != _parentNode);
+    vm.assume(_node != _parentNodeNamehash);
 
     _mockAndExpect(
-      address(_ensRegistry), abi.encodeWithSelector(IENS.owner.selector, _parentNode), abi.encode(_parentNodeOwner)
+      address(_ensRegistry),
+      abi.encodeWithSelector(IENS.owner.selector, _parentNodeNamehash),
+      abi.encode(_parentNodeOwner)
     );
 
     // it emits the RecordSet event
@@ -247,10 +249,12 @@ contract UnitL2Resolver is Test {
     vm.assume(_parentNodeOwner != address(0));
     vm.assume(_parentNodeOwner != _nameWrapper);
     vm.assume(_caller != _parentNodeOwner);
-    vm.assume(_node != _parentNode);
+    vm.assume(_node != _parentNodeNamehash);
 
     _mockAndExpect(
-      address(_ensRegistry), abi.encodeWithSelector(IENS.owner.selector, _parentNode), abi.encode(_parentNodeOwner)
+      address(_ensRegistry),
+      abi.encodeWithSelector(IENS.owner.selector, _parentNodeNamehash),
+      abi.encode(_parentNodeOwner)
     );
 
     _mockAndExpect(
@@ -278,14 +282,14 @@ contract UnitL2Resolver is Test {
     vm.assume(_parentNodeOwner != address(0));
     vm.assume(_parentNodeOwner != _nameWrapper);
     vm.assume(_caller != _parentNodeOwner);
-    vm.assume(_node != _parentNode);
+    vm.assume(_node != _parentNodeNamehash);
 
     _mockAndExpect(
-      address(_ensRegistry), abi.encodeWithSelector(IENS.owner.selector, _parentNode), abi.encode(_nameWrapper)
+      address(_ensRegistry), abi.encodeWithSelector(IENS.owner.selector, _parentNodeNamehash), abi.encode(_nameWrapper)
     );
     _mockAndExpect(
       address(_nameWrapper),
-      abi.encodeWithSelector(INameWrapper.ownerOf.selector, _parentNode),
+      abi.encodeWithSelector(INameWrapper.ownerOf.selector, _parentNodeNamehash),
       abi.encode(_parentNodeOwner)
     );
 
@@ -320,10 +324,12 @@ contract UnitL2Resolver is Test {
     vm.assume(_parentNodeOwner != address(0));
     vm.assume(_parentNodeOwner != _nameWrapper);
     vm.assume(_caller != _parentNodeOwner);
-    vm.assume(_node != _parentNode);
+    vm.assume(_node != _parentNodeNamehash);
 
     _mockAndExpect(
-      address(_ensRegistry), abi.encodeWithSelector(IENS.owner.selector, _parentNode), abi.encode(_parentNodeOwner)
+      address(_ensRegistry),
+      abi.encodeWithSelector(IENS.owner.selector, _parentNodeNamehash),
+      abi.encode(_parentNodeOwner)
     );
 
     _mockAndExpect(
@@ -353,10 +359,10 @@ contract UnitL2Resolver is Test {
     vm.assume(_parentNodeOwner != address(0));
     vm.assume(_parentNodeOwner != _nameWrapper);
     vm.assume(_caller != _parentNodeOwner);
-    vm.assume(_node != _parentNode);
+    vm.assume(_node != _parentNodeNamehash);
 
     _mockAndExpect(
-      address(_ensRegistry), abi.encodeWithSelector(IENS.owner.selector, _parentNode), abi.encode(address(0))
+      address(_ensRegistry), abi.encodeWithSelector(IENS.owner.selector, _parentNodeNamehash), abi.encode(address(0))
     );
 
     // it reverts