refactor: make partition timestamp parsing engine-independent

Author: DrakeLin

kernel/Cargo.toml

@@ -32,7 +32,7 @@ pre-release-hook = [
 delta_kernel_derive = { path = "../derive-macros", version = "0.28.0" }
 bytes = "1.10"
 chrono = "0.4.41"
-chrono-tz = { version = "0.10.4", optional = true }
+chrono-tz = "0.10.4"
 crc = "3.2.2"
 indexmap = "2.10.0"
 itertools = "0.14"
@@ -100,7 +100,7 @@ need-arrow = [] # need-arrow is a marker that the feature needs arrow dep
 arrow-58 = ["dep:arrow_58", "dep:parquet_58", "dep:object_store_13"]
 arrow-59 = ["dep:arrow_59", "dep:parquet_59", "dep:object_store_13"]
 arrow-conversion = ["need-arrow"]
-arrow-expression = ["need-arrow", "dep:chrono-tz"]
+arrow-expression = ["need-arrow"]
 
 # Schema diffing functionality (experimental)
 schema-diff = []

kernel/src/engine/arrow_expression/evaluate_expression.rs

@@ -3,19 +3,16 @@ use std::borrow::Cow;
 use std::collections::HashMap;
 use std::sync::Arc;
 
-use chrono::Utc;
 use itertools::Itertools;
 use tracing::warn;
 
-use super::timestamp_timezone::TimestampTimezone;
 use crate::arrow::array::types::*;
 use crate::arrow::array::{
     self as arrow_array, make_array, new_null_array, Array, ArrayBuilder, ArrayData, ArrayRef,
     AsArray, BooleanArray, Datum, ListArray, MapArray, MutableArrayData, NullBufferBuilder,
     RecordBatch, StringArray, StructArray,
 };
 use crate::arrow::buffer::{NullBuffer, OffsetBuffer};
-use crate::arrow::compute::kernels::cast_utils::{string_to_datetime, Parser};
 use crate::arrow::compute::kernels::cmp::{distinct, eq, gt, gt_eq, lt, lt_eq, neq, not_distinct};
 use crate::arrow::compute::kernels::comparison::in_list_utf8;
 use crate::arrow::compute::kernels::numeric::{add, div, mul, sub};
@@ -44,6 +41,7 @@ use crate::expressions::{
     UnaryPredicateOp, VariadicExpression, VariadicExpressionOp,
 };
 use crate::schema::{DataType, PrimitiveType, StructField, StructType};
+use crate::timestamp_timezone::{parse_partition_scalar, TimestampTimezone};
 
 #[internal_api]
 pub(crate) trait ProvidesColumnByName {
@@ -934,44 +932,6 @@ fn coalesce_arrays(
     Ok(make_array(mutable.freeze()))
 }
 
-/// Parses one raw partition-value string into its target [`Scalar`], or `None` for a null value.
-///
-/// An empty string casts via [`PrimitiveType::empty_string_partition_cast`].
-/// `timestamp_timezone` applies only to `TIMESTAMP` values without an embedded offset or named
-/// timezone; it does not affect `DATE` or `TIMESTAMP_NTZ`.
-fn parse_partition_scalar(
-    prim: &PrimitiveType,
-    raw: &str,
-    timestamp_timezone: TimestampTimezone,
-) -> DeltaResult<Option<Scalar>> {
-    if raw.is_empty() {
-        return Ok(prim.empty_string_partition_cast());
-    }
-    match prim {
-        PrimitiveType::Date => {
-            let days = Date32Type::parse(raw).ok_or_else(|| {
-                Error::ParseError(raw.to_string(), DataType::Primitive(prim.clone()))
-            })?;
-            return Ok(Some(Scalar::Date(days)));
-        }
-        PrimitiveType::Timestamp => {
-            let micros = timestamp_timezone.parse_timestamp(raw).ok_or_else(|| {
-                Error::ParseError(raw.to_string(), DataType::Primitive(prim.clone()))
-            })?;
-            return Ok(Some(Scalar::Timestamp(micros)));
-        }
-        PrimitiveType::TimestampNtz => {
-            let micros = string_to_datetime(&Utc, raw)
-                .map_err(|_| Error::ParseError(raw.to_string(), DataType::Primitive(prim.clone())))?
-                .timestamp_micros();
-            return Ok(Some(Scalar::TimestampNtz(micros)));
-        }
-        _ => {}
-    }
-    let scalar = prim.parse_scalar(raw)?;
-    Ok((!matches!(scalar, Scalar::Null(_))).then_some(scalar))
-}
-
 /// Evaluates `MAP_TO_STRUCT(map_col, output_schema)`: extracts keys from a `Map<String, String>`
 /// and parses each value into its target type, producing a `StructArray`. An empty-string value
 /// casts via [`PrimitiveType::empty_string_partition_cast`].

kernel/src/engine/arrow_expression/mod.rs

@@ -20,7 +20,6 @@ use crate::{EngineData, EvaluationHandler, ExpressionEvaluator, PredicateEvaluat
 
 pub mod evaluate_expression;
 pub mod opaque;
-mod timestamp_timezone;
 
 #[cfg(test)]
 mod tests;

kernel/src/engine/arrow_expression/timestamp_timezone.rs

@@ -114,6 +114,7 @@ pub mod table_changes;
 pub mod table_configuration;
 pub mod table_features;
 pub mod table_properties;
+pub(crate) mod timestamp_timezone;
 pub mod transaction;
 pub mod transforms;
 

kernel/src/lib.rs

@@ -1983,6 +1983,7 @@ pub enum PrimitiveType {
     Date,
     /// Microsecond precision timestamp, adjusted to UTC.
     Timestamp,
+    /// Microsecond precision local timestamp without timezone adjustment.
     #[serde(rename = "timestamp_ntz")]
     TimestampNtz,
     Void,