Skip to content

Document type widening requirements for parquet readers #1612

Description

@DrakeLin

From PR #1573 review: We are relying on parquet readers to perform type widening (e.g., reading INT as LONG, FLOAT as DOUBLE) when reading checkpoint statistics.

Problem

The kernel's schema comparison code (can_widen_to) assumes that parquet readers will handle type widening:
- Integer widening: byte → short → int → long
- Float widening: float → double

However, this is not currently documented as a requirement in the parquet reader contract/interface.

Request

  1. Document in the `ParquetHandler` trait what type widening behavior is expected/required
  2. Clarify whether this is a hard requirement or best-effort behavior
  3. Consider adding tests to verify type widening behavior in the default parquet implementation

Related

  - PR #1573: feat: Add function to check if schema supports parsed stats")

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions