Merge pull request #157 from denis1011101/feature/game-share-card

feat: share the game card the way the list shows it

Author: denis1011101

app/controllers/game_share_cards_controller.rb

@@ -2,22 +2,12 @@ class GameShareCardsController < ApplicationController
   skip_before_action :authenticate_user!, only: :show
 
   def show
-    game = Game.includes(:court, :participations).find(params[:game_id])
-    data = Telegram::Helpers::GameCardRenderer.render_data(game, locale: telegram_locale)
+    game = Game.includes(:court, :tournament, :participations).find(params[:game_id])
+    data = Games::ShareCardRenderer.render_data(game, locale: I18n.locale)
 
     send_data data,
       filename: "getcourt-game-#{game.id}.png",
       type: "image/png",
       disposition: "inline"
   end
-
-  private
-
-  def telegram_locale
-    locale = I18n.locale.to_s
-    return locale if Telegram::I18n::LOCALES.include?(locale)
-
-    default_locale = I18n.default_locale.to_s
-    Telegram::I18n::LOCALES.include?(default_locale) ? default_locale : Telegram::I18n::DEFAULT_LOCALE
-  end
 end

app/services/games/share_card_renderer.rb

@@ -0,0 +1,31 @@
+# frozen_string_literal: true
+
+require "open3"
+
+module Images
+  # Растеризует наш собственный SVG в PNG. Работу делает отдельный процесс
+  # (`lib/images/svg_to_png.rb`): в приложении загрузчик SVG закрыт Active Storage,
+  # и открывать его в веб-процессе, который рядом обрабатывает чужие загрузки, нельзя.
+  module SvgRasterizer
+    class Error < StandardError; end
+
+    SCRIPT = Rails.root.join("lib/images/svg_to_png.rb").to_s
+
+    def self.render_png(svg, dpi:)
+      out, err, status = Open3.capture3(child_env, RbConfig.ruby, SCRIPT, dpi.to_s, stdin_data: svg, binmode: true)
+      raise Error, "svg render failed (#{status.exitstatus}): #{err.to_s.lines.last&.strip}" unless status.success?
+
+      out
+    end
+
+    # Дочернему процессу нужен ruby-vips из бандла — bundler в родителе уже прописан
+    # в окружении, но под systemd переменных может не быть, поэтому подстраховываемся.
+    def self.child_env
+      {
+        "BUNDLE_GEMFILE" => ENV["BUNDLE_GEMFILE"].presence || Rails.root.join("Gemfile").to_s,
+        "RUBYOPT" => [ ENV["RUBYOPT"], "-rbundler/setup" ].compact_blank.join(" ")
+      }
+    end
+    private_class_method :child_env
+  end
+end

app/services/images/svg_rasterizer.rb

@@ -12,12 +12,12 @@ def render(game, locale: Telegram::I18n::DEFAULT_LOCALE)
           png = Tempfile.new([ "game-share-card-", ".png" ], Rails.root.join("tmp"))
           png.close
 
-          render_image(svg_markup(game, locale: locale)).write_to_file(png.path)
+          File.binwrite(png.path, render_data(game, locale: locale))
           png.path
         end
 
         def render_data(game, locale: Telegram::I18n::DEFAULT_LOCALE)
-          render_image(svg_markup(game, locale: locale)).write_to_buffer(".png")
+          Images::SvgRasterizer.render_png(svg_markup(game, locale: locale), dpi: 72)
         end
 
         private
@@ -130,15 +130,6 @@ def owner_value(game)
         def esc(value)
           CGI.escapeHTML(value.to_s)
         end
-
-        def render_image(svg)
-          load_vips!
-          Vips::Image.svgload_buffer(svg, dpi: 72)
-        end
-
-        def load_vips!
-          require "vips" unless defined?(Vips::Image)
-        end
       end
     end
   end

app/services/telegram/helpers/game_card_renderer.rb

@@ -0,0 +1,15 @@
+# frozen_string_literal: true
+
+# Отдельный процесс: читает SVG из stdin, пишет PNG в stdout.
+#
+# Внутри приложения этого сделать нельзя. Active Storage глушит загрузчики libvips
+# (`Vips.block_untrusted`), чтобы librsvg не разбирал чужие файлы, а снимать блокировку
+# на лету — значит открыть окно, в которое соседний поток веб-процесса успеет прогнать
+# через тот же загрузчик пользовательскую картинку. Здесь Rails не загружается, блокировки
+# нет, и рендерится только наш собственный, заведомо доверенный SVG.
+require "vips"
+
+dpi = Integer(ARGV[0] || 72)
+svg = $stdin.binmode.read
+
+$stdout.binmode.write(Vips::Image.svgload_buffer(svg, dpi: dpi).write_to_buffer(".png"))

lib/images/svg_to_png.rb

@@ -4,7 +4,7 @@ class GameShareCardsControllerTest < ActionDispatch::IntegrationTest
   test "renders generated game share card image" do
     png_header = "\x89PNG\r\n\x1A\n".b
 
-    stub_singleton(Telegram::Helpers::GameCardRenderer, :render_data, ->(*) { png_header }) do
+    stub_singleton(Games::ShareCardRenderer, :render_data, ->(*) { png_header }) do
       get game_share_card_path(games(:one))
     end
 

test/controllers/game_share_cards_controller_test.rb

@@ -0,0 +1,65 @@
+require "test_helper"
+
+class Games::ShareCardRendererTest < ActiveSupport::TestCase
+  test "card markup repeats the badges, the comment and the free spots of the games list" do
+    game = games(:feed_upcoming)
+    # Корт из фикстуры разрешает не любое покрытие, а карточке важны только атрибуты игры.
+    game.assign_attributes(
+      kind: "training",
+      sport: "tennis",
+      surface: "hard",
+      environment: "outdoor",
+      skill_level: "intermediate",
+      with_coach: true,
+      recurring: true,
+      urgent_player_search: true,
+      comment: "Ракетки и мячи свои"
+    )
+
+    svg = markup_for(game)
+
+    assert_includes svg, "Feed Court"
+    assert_includes svg, "Tennis"
+    assert_includes svg, "Intermediate"
+    assert_includes svg, "Hard"
+    assert_includes svg, "Outdoor"
+    assert_includes svg, I18n.t("games.badges.training", locale: :en)
+    assert_includes svg, I18n.t("games.badges.coach", locale: :en)
+    assert_includes svg, I18n.t("games.badges.weekly", locale: :en)
+    assert_includes svg, I18n.t("games.badges.player_search", locale: :en)
+    assert_includes svg, "Ракетки и мячи свои"
+    assert_includes svg, I18n.t("games.card.spots_left", count: 4, locale: :en)
+  end
+
+  test "weather badge is skipped for indoor games" do
+    game = games(:feed_upcoming)
+    game.assign_attributes(environment: "indoor")
+
+    called = false
+    stub_singleton(Weather::GoogleForecast, :for_game, ->(*) { called = true; nil }) do
+      Games::ShareCardRenderer.send(:svg_markup, game, locale: :en)
+    end
+
+    assert_not called, "indoor game must not go to the forecast"
+  end
+
+  test "renders a png" do
+    data = markup_free_render(games(:feed_upcoming))
+
+    assert_equal "\x89PNG\r\n\x1A\n".b, data[0, 8].b
+  end
+
+  private
+
+  def markup_for(game)
+    stub_singleton(Weather::GoogleForecast, :for_game, nil) do
+      Games::ShareCardRenderer.send(:svg_markup, game, locale: :en)
+    end
+  end
+
+  def markup_free_render(game)
+    stub_singleton(Weather::GoogleForecast, :for_game, nil) do
+      Games::ShareCardRenderer.render_data(game, locale: :en)
+    end
+  end
+end

test/services/games/share_card_renderer_test.rb

@@ -0,0 +1,21 @@
+require "test_helper"
+
+class Images::SvgRasterizerTest < ActiveSupport::TestCase
+  SVG = %(<svg width="10" height="4" xmlns="http://www.w3.org/2000/svg"><rect width="10" height="4" fill="#000000"/></svg>).freeze
+
+  test "renders svg that this process is not allowed to load itself" do
+    data = Images::SvgRasterizer.render_png(SVG, dpi: 72)
+
+    assert_equal "\x89PNG\r\n\x1A\n".b, data[0, 8].b
+  end
+
+  test "leaves the svg loader blocked in the app process" do
+    Images::SvgRasterizer.render_png(SVG, dpi: 72)
+
+    assert_raises(Vips::Error) { Vips::Image.svgload_buffer(SVG) }
+  end
+
+  test "raises when the child cannot render" do
+    assert_raises(Images::SvgRasterizer::Error) { Images::SvgRasterizer.render_png("not an svg at all", dpi: 72) }
+  end
+end

test/services/images/svg_rasterizer_test.rb

@@ -20,12 +20,7 @@ class Telegram::Helpers::GameCardRendererTest < ActiveSupport::TestCase
     stub_singleton(Telegram::Helpers::GameFormatting, :game_title, "Tennis") do
       stub_singleton(Telegram::Helpers::GameFormatting, :game_datetime, "2026-04-09 22:00") do
         stub_singleton(User, :find_by, user) do
-          fake_image = Object.new
-          fake_image.define_singleton_method(:write_to_file) do |output_path|
-            File.binwrite(output_path, "\x89PNG\r\n\x1A\nfake".b)
-          end
-
-          stub_singleton(Telegram::Helpers::GameCardRenderer, :render_image, fake_image) do
+          stub_singleton(Images::SvgRasterizer, :render_png, "\x89PNG\r\n\x1A\nfake".b) do
             path = Telegram::Helpers::GameCardRenderer.render(game, locale: :en)
           end
         end